http://bugs.winehq.org/show_bug.cgi?id=23241
Summary: Icons are blacked out/blank in some Altium Designer 2009 GUI elements Product: Wine Version: 1.2-rc3 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comctl32 AssignedTo: wine-bugs@winehq.org ReportedBy: johnvoltz@gmail.com
Some of the icons in the Altium Designer GUIs are blanked out, black squares. Regression testing reveals the cause as:
93437fc963378e2b56632aac12fc05f90645619b is the first bad commit commit 93437fc963378e2b56632aac12fc05f90645619b Author: Dmitry Timoshkov dmitry@codeweavers.com Date: Wed Apr 7 18:27:52 2010 +0900
comctl32: Do not use width of the passed to ImageList_Add bitmap as an icon width.
:040000 040000 ddd03ea559490af9b50e5e57de31141e8d4c6f3e 6c63b6238463e6a1841ba1b050d2f34c0567d9a2 M dlls
http://bugs.winehq.org/show_bug.cgi?id=23241
--- Comment #1 from John Voltz johnvoltz@gmail.com 2010-06-18 13:36:28 --- Created an attachment (id=28937) --> (http://bugs.winehq.org/attachment.cgi?id=28937) Screenshot of the bug
Notice the black squares where the icons should appear.
http://bugs.winehq.org/show_bug.cgi?id=23241
--- Comment #2 from John Voltz johnvoltz@gmail.com 2010-06-18 13:46:52 --- Created an attachment (id=28938) --> (http://bugs.winehq.org/attachment.cgi?id=28938) Patch to revert
This patch reverts the commit that caused the bug.
http://bugs.winehq.org/show_bug.cgi?id=23241
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
--- Comment #3 from Austin English austinenglish@gmail.com 2010-06-18 13:49:38 --- Please attach a +imagelist trace.
http://bugs.winehq.org/show_bug.cgi?id=23241
--- Comment #4 from John Voltz johnvoltz@gmail.com 2010-06-18 14:02:36 --- Created an attachment (id=28939) --> (http://bugs.winehq.org/attachment.cgi?id=28939) +imagelist trace log with the bug
+imagelist trace with the bug
http://bugs.winehq.org/show_bug.cgi?id=23241
--- Comment #5 from John Voltz johnvoltz@gmail.com 2010-06-18 14:11:11 --- Created an attachment (id=28940) --> (http://bugs.winehq.org/attachment.cgi?id=28940) +imagelist trace without bug
with the bug removed
http://bugs.winehq.org/show_bug.cgi?id=23241
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wylda@volny.cz
--- Comment #6 from Wylda wylda@volny.cz 2010-06-19 08:19:27 ---
Did you used native comctl32? I see this problem in case of 1.2-rc4 & native comctl32 under CyberBoard Player.
John, please verify, that in winecfg -> Libraties there is "comctl32 (builtin)".
http://bugs.winehq.org/show_bug.cgi?id=23241
--- Comment #7 from Dmitry Timoshkov dmitry@codeweavers.com 2010-06-20 01:39:42 --- Created an attachment (id=29006) --> (http://bugs.winehq.org/attachment.cgi?id=29006) Allocate maximum images at the imagelist creation
Does the attached patch help? If not, please generate another +imagelist log with the patch applied.
http://bugs.winehq.org/show_bug.cgi?id=23241
John Voltz johnvoltz@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #8 from John Voltz johnvoltz@gmail.com 2010-06-20 14:37:30 ---
Does the attached patch help? If not, please generate another +imagelist log with the patch applied.
Yes, that seems to have fixed it. Thanks!
http://bugs.winehq.org/show_bug.cgi?id=23241
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|FIXED |
--- Comment #9 from Nikolay Sivov bunglehead@gmail.com 2010-06-20 14:46:47 --- No fixed yet, patch wasn't committed.
http://bugs.winehq.org/show_bug.cgi?id=23241
--- Comment #10 from John Voltz johnvoltz@gmail.com 2010-06-20 16:10:41 --- Created an attachment (id=29035) --> (http://bugs.winehq.org/attachment.cgi?id=29035) screenshot of new problem
Does the attached patch help? If not, please generate another +imagelist log with the patch applied.
Okay, it still seems to have a problem after using Dmitry's patch. The icon background is a pinkish color in some cases. See the screenshot.
http://bugs.winehq.org/show_bug.cgi?id=23241
--- Comment #11 from John Voltz johnvoltz@gmail.com 2010-06-20 16:12:20 --- Created an attachment (id=29036) --> (http://bugs.winehq.org/attachment.cgi?id=29036) +imagelist trace after Dmitry's patch
Here's a trace log with Dmitry's patch.
http://bugs.winehq.org/show_bug.cgi?id=23241
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #12 from Dmitry Timoshkov dmitry@codeweavers.com 2010-06-21 00:48:56 --- (In reply to comment #10)
Okay, it still seems to have a problem after using Dmitry's patch. The icon background is a pinkish color in some cases. See the screenshot.
This is another problem, please open a separate bug report for it.
http://bugs.winehq.org/show_bug.cgi?id=23241
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #29036|application/octet-stream |text/plain mime type| |
http://bugs.winehq.org/show_bug.cgi?id=23241
--- Comment #13 from Dmitry Timoshkov dmitry@codeweavers.com 2010-06-21 01:07:27 --- (In reply to comment #12)
(In reply to comment #10)
Okay, it still seems to have a problem after using Dmitry's patch. The icon background is a pinkish color in some cases. See the screenshot.
This is another problem, please open a separate bug report for it.
... and perform the regression test, this looks like another regression. You may need to apply my patch first at the point of the regression reported in this bug report to make sure that the painting regression didn't exist at that time.
http://bugs.winehq.org/show_bug.cgi?id=23241
--- Comment #14 from John Voltz johnvoltz@gmail.com 2010-06-21 06:45:01 ---
This is another problem, please open a separate bug report for it.
... and perform the regression test, this looks like another regression. You may need to apply my patch first at the point of the regression reported in this bug report to make sure that the painting regression didn't exist at that time.
I don't understand. If I revert commit 93437fc963378e2b56632aac12fc05f90645619b all of the problems go away, including the pinkish background. If you are positive that this is a different problem I will try another regression test.
http://bugs.winehq.org/show_bug.cgi?id=23241
--- Comment #15 from Dmitry Timoshkov dmitry@codeweavers.com 2010-06-23 03:58:41 --- Please try http://www.winehq.org/pipermail/wine-patches/2010-June/089874.html
http://bugs.winehq.org/show_bug.cgi?id=23241
--- Comment #16 from Dmitry Timoshkov dmitry@codeweavers.com 2010-06-23 22:19:39 --- (In reply to comment #15)
Please try http://www.winehq.org/pipermail/wine-patches/2010-June/089874.html
The patch has been committed, please test with latest Wine git.
http://bugs.winehq.org/show_bug.cgi?id=23241
John Voltz johnvoltz@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #17 from John Voltz johnvoltz@gmail.com 2010-06-24 10:23:15 ---
The patch has been committed, please test with latest Wine git.
I tested it this morning and this time it looks like it really is fixed. Thanks for working on this, Dmitry!
http://bugs.winehq.org/show_bug.cgi?id=23241
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #18 from Alexandre Julliard julliard@winehq.org 2010-06-25 12:41:45 --- Closing bugs fixed in 1.2-rc5.
https://bugs.winehq.org/show_bug.cgi?id=23241
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |1066194f94b59ba4df249e0dcfa | |9e0da6e4c6f5e CC| |focht@gmx.net Regression SHA1| |93437fc963378e2b56632aac12f | |c05f90645619b
-
wine-bugs＠winehq.org