[Bug 35405] New: NoLimits Coaster 2, Direct3D not supported

http://bugs.winehq.org/show_bug.cgi?id=35405

Bug ID: 35405
           Summary: NoLimits Coaster 2, Direct3D not supported
           Product: Wine
           Version: 1.7.10
          Hardware: x86-64
                OS: Mac OS X
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
    Classification: Unclassified

NoLimits Coaster 2 was recently released. When attempting to open the
application, it gives the message: "windowed Direct3D rendering not supported
in current display mode"

A demo can be downloaded and tested here:
http://www.maddata.com/nolimits2/download03/NoLimits_2000_Demo_Install.exe

[Bug 35405] NoLimits Coaster 2, Direct3D not supported

http://bugs.winehq.org/show_bug.cgi?id=35405

Ken Thomases  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Ken Thomases  ---
Are you using a Retina MacBook Pro?  Have you configured the display to
"scaled" at a resolution between "Best" and "More Space" (perhaps 1920x1200)?

If so, it's an issue I'm aware of.  Basically, the Mac APIs for reporting the
current display mode shows, for example, 1920x1200 while those for listing all
of the available display modes don't include 1920x1200!  They basically claim
that the current display mode is not available.

This is presumably confusing Wine or the game, causing it to show that error
message.

You can try temporarily switching your resolution to either Best or the highest
More Space setting to see if that fixes it.

[Bug 35405] NoLimits Coaster 2, Direct3D not supported

http://bugs.winehq.org/show_bug.cgi?id=35405

--- Comment #2 from Michael  ---
Unfortunately it is not a Retina MacBook Pro.  I did try taking it off the
Scaled display anyways, but still have the same issue.

[Bug 35405] NoLimits Coaster 2, Direct3D not supported

http://bugs.winehq.org/show_bug.cgi?id=35405

--- Comment #3 from Ken Thomases  ---
Huh.  Then we could probably use a +tid,+display,+d3d log.  See points 10.1 and
10.2 from here: http://wiki.winehq.org/FAQ#get_log

[Bug 35405] NoLimits Coaster 2, Direct3D not supported

http://bugs.winehq.org/show_bug.cgi?id=35405

--- Comment #4 from Michael  ---
Created attachment 47255
  --> http://bugs.winehq.org/attachment.cgi?id=47255
Debug Log

+tid,+display,+d3d

[Bug 35405] NoLimits Coaster 2, Direct3D not supported

http://bugs.winehq.org/show_bug.cgi?id=35405

--- Comment #5 from Michael  ---
Debug log added, thanks for the help.

[Bug 35405] NoLimits Coaster 2, Direct3D not supported

http://bugs.winehq.org/show_bug.cgi?id=35405

--- Comment #6 from Ken Thomases  ---
0009:trace:d3d:wined3d_check_device_type wined3d 0x1889e0, adapter_idx 0,
device_type WINED3D_DEVICE_TYPE_HAL, display_format WINED3DFMT_B8G8R8X8_UNORM,
backbuffer_format WINED3DFMT_UNKNOWN, windowed 0x1.
...
0009:trace:d3d:wined3d_check_device_type Unsupported display/backbuffer format
combination WINED3DFMT_B8G8R8X8_UNORM / WINED3DFMT_UNKNOWN.

Seems like a wined3d bug, I think.
dlls/wined3d/directx.c:wined3d_check_device_type() has a number of checks of
the display and backbuffer format.  For several of the checks, the comment says
the restriction only applies for full-screen mode but the check doesn't take
windowed vs. full-screen into account.  The game is using windowed mode, but a
supposedly full-screen-only check rejects the display/backbuffer format
combination.

In fact, that function has a check which specifically allows WINED3DFMT_UNKNOWN
in windowed mode, but the subsequent logic makes it impossible for that to
pass.

[Bug 35405] NoLimits Coaster 2, Direct3D not supported

http://bugs.winehq.org/show_bug.cgi?id=35405

--- Comment #7 from Ken Thomases  ---
Created attachment 47256
  --> http://bugs.winehq.org/attachment.cgi?id=47256
Allow windowed WINED3DFMT_UNKNOWN

I can confirm the bug with the demo.

The attached patch fixes the problem for me.  The demo proceeds to load and
play.  There are rendering problems galore, but that's a separate issue.

I have no idea if this patch is correct.  I based it entirely on the comments
in the code, not any deeper understanding of the issue.  One of the wined3d
developers should review.

[Bug 35405] NoLimits Coaster 2, Direct3D not supported

http://bugs.winehq.org/show_bug.cgi?id=35405

Ken Thomases  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, patch
             Status|UNCONFIRMED                 |NEW
                URL|                            |http://www.maddata.com/noli
                   |                            |mits2/download03/NoLimits_2
                   |                            |000_Demo_Install.exe
     Ever confirmed|0                           |1

--- Comment #8 from Ken Thomases  ---
Marking confirmed.

[Bug 35405] NoLimits Coaster 2, Direct3D not supported

http://bugs.winehq.org/show_bug.cgi?id=35405

--- Comment #9 from Michael  ---
I'm able to load the game with this patch, thank-you!

[Bug 35405] NoLimits Coaster 2, Direct3D not supported

http://bugs.winehq.org/show_bug.cgi?id=35405

--- Comment #10 from Austin English  ---
(In reply to comment #7)
> Created attachment 47256 [details]
> Allow windowed WINED3DFMT_UNKNOWN
>
> I can confirm the bug with the demo.
>
> The attached patch fixes the problem for me.  The demo proceeds to load and
> play.  There are rendering problems galore, but that's a separate issue.
>
> I have no idea if this patch is correct.  I based it entirely on the
> comments in the code, not any deeper understanding of the issue.  One of the
> wined3d developers should review.

I see the same issue in wine-1.7.11 on Fedora 19. Patch works there as well.

[Bug 35405] NoLimits Coaster 2, Direct3D not supported

https://bugs.winehq.org/show_bug.cgi?id=35405

--- Comment #11 from Henri Verbeet  ---
(In reply to comment #7)
> I have no idea if this patch is correct.  I based it entirely on the
> comments in the code, not any deeper understanding of the issue.  One of the
> wined3d developers should review.

It looks correct to me at first sight, but of course we'd like a test case.

[Bug 35405] NoLimits Coaster 2, Direct3D not supported

https://bugs.winehq.org/show_bug.cgi?id=35405

Ken Thomases  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47256|0                           |1
        is obsolete|                            |

--- Comment #12 from Ken Thomases  ---
Comment on attachment 47256
  --> https://bugs.winehq.org/attachment.cgi?id=47256
Allow windowed WINED3DFMT_UNKNOWN

I have submitted a more thorough fix for CheckDeviceType() for windowed mode:
http://source.winehq.org/patches/data/101903

I have also submitted an overhaul of the tests of CheckDeviceType() which also
test windowed mode: http://source.winehq.org/patches/data/101904

[Bug 35405] NoLimits Coaster 2, Direct3D not supported

https://bugs.winehq.org/show_bug.cgi?id=35405

Ken Thomases  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |d2c56a60271abc4d231c1f61510
                   |                            |a7d24129ee815
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from Ken Thomases  ---
I believe this is fixed by
http://source.winehq.org/git/wine.git/?a=commit;h=d2c56a60271abc4d231c1f6151...

[Bug 35405] NoLimits Coaster 2, Direct3D not supported

https://bugs.winehq.org/show_bug.cgi?id=35405

--- Comment #14 from Michael  ---
(In reply to comment #13)
> I believe this is fixed by
> http://source.winehq.org/git/wine.git/?a=commit;
> h=d2c56a60271abc4d231c1f61510a7d24129ee815

Thank-you for your work on this Ken.  I really appreciate it.

[Bug 35405] NoLimits Coaster 2, Direct3D not supported

https://bugs.winehq.org/show_bug.cgi?id=35405

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #15 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.12.

[Bug 35405] NoLimits Coaster 2, Direct3D not supported

http://bugs.winehq.org/show_bug.cgi?id=35405

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 35405] NoLimits Coaster 2, Direct3D not supported

http://bugs.winehq.org/show_bug.cgi?id=35405

--- Comment #16 from [e-mail] ---
How do I add the patch into the game?

[Bug 35405] NoLimits Coaster 2, Direct3D not supported

http://bugs.winehq.org/show_bug.cgi?id=35405

--- Comment #17 from Bruno Jesus  ---
(In reply to theroc214 from comment #16)
> How do I add the patch into the game?

The patch was applied to wine, not the game. Ensure you are using a wine
version >= 1.7.12

For further help please refer to the forums.