[Bug 48761] New: ConEmu does not highlight selection

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48761

Bug ID: 48761
           Summary: ConEmu does not highlight selection
           Product: Wine
           Version: 5.4
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

ConEmu does not highlight selected text/block while selecting by mouse and
after the block is selected. The selected text/block is however correctly
highlighted after alt+tab to another application and back. It seems that some
events are not generated properly.

The selection is otherwise functional so it is a minor issue. Fixing that would
make ConEmu perfect ;-)

[Bug 48761] ConEmu does not highlight selection

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48761

Roman Pišl  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://conemu.github.io/
                 CC|                            |[e-mail]
           Keywords|                            |download

[Bug 48761] ConEmu does not highlight selection

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48761

--- Comment #1 from Roman Pišl  ---
Created attachment 66671
  --> https://bugs.winehq.org/attachment.cgi?id=66671
Fix

ConEmu calls:

InvalidateRect(mh_WndDC, NULL, FALSE);
GetClientRect(mh_WndDC, &rcClient)
RedrawWindow(mh_WndDC, &rcClient, NULL,
RDW_INTERNALPAINT|RDW_NOERASE|RDW_NOFRAME|RDW_UPDATENOW|RDW_VALIDATE);

so the whole window is validated before WM_PAINT is sent.

Attaching fix that doesn't break any tests. But is that correct solution?

[Bug 48761] ConEmu does not highlight selection

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48761

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Keywords|                            |patch

[Bug 48761] ConEmu does not highlight selection

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48761

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]

--- Comment #2 from Louis Lenders  ---
Still present + confirming, wine-7.0-rc2

Roman, did you ever send your patches in for review? Would be nice if this got
fixed

[Bug 48761] ConEmu does not highlight selection

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48761

--- Comment #3 from Roman Pišl  ---
(In reply to Louis Lenders from comment #2)
> Still present + confirming, wine-7.0-rc2
>
> Roman, did you ever send your patches in for review? Would be nice if this
> got fixed

Yes, see:
https://www.winehq.org/pipermail/wine-devel/2020-April/164991.html
https://www.winehq.org/pipermail/wine-devel/2020-April/164993.html
https://www.winehq.org/pipermail/wine-devel/2020-April/164992.html
https://www.winehq.org/pipermail/wine-devel/2020-April/164995.html
https://www.winehq.org/pipermail/wine-devel/2020-April/165003.html

I think this bug is for someone more competent..

[Bug 48761] ConEmu does not highlight selection

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48761

--- Comment #4 from Louis Lenders  ---
(In reply to Roman Pišl from comment #3)
> (In reply to Louis Lenders from comment #2)
> > Still present + confirming, wine-7.0-rc2
> >
> > Roman, did you ever send your patches in for review? Would be nice if this
> > got fixed
>
> Yes, see:
> https://www.winehq.org/pipermail/wine-devel/2020-April/164991.html
> https://www.winehq.org/pipermail/wine-devel/2020-April/164993.html
> https://www.winehq.org/pipermail/wine-devel/2020-April/164992.html
> https://www.winehq.org/pipermail/wine-devel/2020-April/164995.html
> https://www.winehq.org/pipermail/wine-devel/2020-April/165003.html
>
> I think this bug is for someone more competent..

Ok, then i guess we have to be patient. Hopefully somehow this could be picked
by someone  else ever. ConEmu works great apart from this issue and the ctrl^c
thing.

Regards

[Bug 48761] ConEmu does not highlight selection

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48761

Roman Pišl  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66671|0                           |1
        is obsolete|                            |

--- Comment #5 from Roman Pišl  ---
Created attachment 71458
  --> https://bugs.winehq.org/attachment.cgi?id=71458
Fix for RDW_VALIDATE

Rebased and simplified version of the fix.

[Bug 48761] ConEmu does not highlight selection

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48761

--- Comment #6 from Roman Pišl  ---
This fell off the list again.

https://source.winehq.org/patches/data/222810
https://source.winehq.org/patches/data/222811