[Bug 16704] New: wineconsole: Allow specifying the console backend to use when wineconsole is launched implicitly

http://bugs.winehq.org/show_bug.cgi?id=16704

Summary: wineconsole: Allow specifying the console backend to use
                    when wineconsole is launched implicitly
           Product: Wine
           Version: CVS/GIT
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: programs
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=18363)
 --> (http://bugs.winehq.org/attachment.cgi?id=18363)
Proposed patch for fixing the issue

When wineconsole is launched implicitly, when an application in wine opens a
console, it currently defaults to using the user backend of wineconsole,
without any possibility of changing which backend to use.

The console application to launch can be changed using the WINECONSOLE
environment variable, and wine appends --use-event=xx to that command line when
launching the console program. Setting WINECONSOLE to "wineconsole
--backend=curses" is ignored, since wineconsole chooses the user backend as
soon as the --use-event argument is parsed. This isn't necessary, since the
user backend is the default one. By removing the explicit setting of the user
backend when parsing the --use-event argument, choosing another backend through
the WINECONSOLE environment variable works as expected.

The attached patch implements this proposed change.

[Bug 16704] wineconsole: Allow specifying the console backend to use when wineconsole is launched implicitly

http://bugs.winehq.org/show_bug.cgi?id=16704

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         OS/Version|All                         |other
           Platform|All                         |Other
            Version|CVS/GIT                     |1.1.11

[Bug 16704] wineconsole: Allow specifying the console backend to use when wineconsole is launched implicitly

http://bugs.winehq.org/show_bug.cgi?id=16704

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                 CC|                            |[e-mail]

--- Comment #1 from Austin English   2009-07-08 14:45:12 ---
Please send patches to [e-mail]

[Bug 16704] wineconsole: Allow specifying the console backend to use when wineconsole is launched implicitly

http://bugs.winehq.org/show_bug.cgi?id=16704

--- Comment #2 from Martin Storsjö   2009-07-08 14:50:16 ---
Yes, this patch was initially sent to [e-mail] in November 2008
(http://www.winehq.org/pipermail/wine-patches/2008-November/065234.html) but
received no attention at that point.

[Bug 16704] wineconsole: Allow specifying the console backend to use when wineconsole is launched implicitly

http://bugs.winehq.org/show_bug.cgi?id=16704

--- Comment #3 from Austin English   2009-07-08 14:52:10 ---
(In reply to comment #2)
> Yes, this patch was initially sent to [e-mail] in November 2008
> (http://www.winehq.org/pipermail/wine-patches/2008-November/065234.html) but
> received no attention at that point.

Try resending to wine-devel and ask for comments.

[Bug 16704] wineconsole: Allow specifying the console backend to use when wineconsole is launched implicitly

http://bugs.winehq.org/show_bug.cgi?id=16704

--- Comment #4 from Austin English   2009-07-08 15:11:09 ---
Is this still an issue in current (1.1.25 or newer) wine?

[Bug 16704] wineconsole: Allow specifying the console backend to use when wineconsole is launched implicitly

http://bugs.winehq.org/show_bug.cgi?id=16704

--- Comment #5 from Martin Storsjö   2009-07-09 04:06:11 ---
Yes, the issue is unchanged in the latest version in git.

[Bug 16704] wineconsole: Allow specifying the console backend to use when wineconsole is launched implicitly

http://bugs.winehq.org/show_bug.cgi?id=16704

--- Comment #6 from Austin English   2009-07-09 13:48:29 ---
(In reply to comment #5)
> Yes, the issue is unchanged in the latest version in git.

I resent it for you:
http://www.winehq.org/pipermail/wine-patches/2009-July/075683.html

[Bug 16704] wineconsole: Allow specifying the console backend to use when wineconsole is launched implicitly

http://bugs.winehq.org/show_bug.cgi?id=16704

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #7 from Austin English   2010-07-23 15:11:47 ---
Still present in wine-1.2-422-ge158bb0.

[Bug 16704] wineconsole: Allow specifying the console backend to use when wineconsole is launched implicitly

http://bugs.winehq.org/show_bug.cgi?id=16704

--- Comment #8 from Martin Storsjö  2010-12-21 06:42:12 CST ---
The patch you resent in July 2009 actually is an incorrect version, removing
the general default, not removing the statement where the previous value is
overwritten when handling the --use-event parameter. Did I send it in that form
somewhere, or did you modify it?

While the patch still hasn't been applied, and still would be useful, I'm not
able to reproduce the cases that triggered a wineconsole to be launched
implicitly any longer, with the latest version from git. In all those cases,
AllocConsole is able to find an existing console internally, so the actual need
for this isn't that big any longer.

[Bug 16704] wineconsole: Allow specifying the console backend to use when wineconsole is launched implicitly

http://bugs.winehq.org/show_bug.cgi?id=16704

--- Comment #9 from Austin English  2010-12-21 14:52:40 CST ---
(In reply to comment #8)
> The patch you resent in July 2009 actually is an incorrect version, removing
> the general default, not removing the statement where the previous value is
> overwritten when handling the --use-event parameter. Did I send it in that form
> somewhere, or did you modify it?
>
> While the patch still hasn't been applied, and still would be useful, I'm not
> able to reproduce the cases that triggered a wineconsole to be launched
> implicitly any longer, with the latest version from git. In all those cases,
> AllocConsole is able to find an existing console internally, so the actual need
> for this isn't that big any longer.

The patch was the same as you sent. Feel free to send a fixed version.

[Bug 16704] wineconsole: Allow specifying the console backend to use when wineconsole is launched implicitly

http://bugs.winehq.org/show_bug.cgi?id=16704

--- Comment #10 from Martin Storsjö  2010-12-21 16:08:58 CST ---
Sent the old patch again.

[Bug 16704] wineconsole: Allow specifying the console backend to use when wineconsole is launched implicitly

http://bugs.winehq.org/show_bug.cgi?id=16704

Martin Storsjö  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Martin Storsjö  2010-12-23 12:24:00 CST ---
Fixed by
http://source.winehq.org/git/wine.git/?a=commitdiff;h=0f3ff8b4b162202e687ebe...

[Bug 16704] wineconsole: Allow specifying the console backend to use when wineconsole is launched implicitly

http://bugs.winehq.org/show_bug.cgi?id=16704

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard  2010-12-24 13:13:13 CST ---
Closing bugs fixed in 1.3.10.

[Bug 16704] wineconsole: Allow specifying the console backend to use when wineconsole is launched implicitly

http://bugs.winehq.org/show_bug.cgi?id=16704

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.2.x

[Bug 16704] wineconsole: Allow specifying the console backend to use when wineconsole is launched implicitly

http://bugs.winehq.org/show_bug.cgi?id=16704

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.2.x                       |---