[Bug 47255] New: Xenonauts crashes in wined3d

https://bugs.winehq.org/show_bug.cgi?id=47255

Bug ID: 47255
           Summary: Xenonauts crashes in wined3d
           Product: Wine
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: regression
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: db201072655946662c041a66ee434c30c245e5b0
      Distribution: ---

Created attachment 64541
  --> https://bugs.winehq.org/attachment.cgi?id=64541
terminal output

Xenonauts v1.65 crashes immediately after launch.
Reverting commit db201072655946662c041a66ee434c30c245e5b0 fixes the crash.
No demo version is available. Let me know what debug log would be of help.

wine-4.8-343-g27bf52d12c
OpenGL vendor string: NVIDIA Corporation
OpenGL renderer string: GeForce GT 730/PCIe/SSE2
OpenGL core profile version string: 4.6.0 NVIDIA 418.52.07

[Bug 47255] Xenonauts crashes in wined3d

https://bugs.winehq.org/show_bug.cgi?id=47255

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://www.fileplanet.com/
                   |                            |archive/p-823/Aura-2-The-Sa
                   |                            |cred-Rings-Demo
            Version|unspecified                 |4.9
           Keywords|                            |download

--- Comment #1 from Béla Gyebrószki  ---
Aura 2: The Sacred Rings, Art of Murder: Cards of Destiny are also affected by
this bug.

To my untrained eyes, these messages in the logs seem to be common among these
games:
> > 003b:err:d3d:wined3d_context_gl_init Failed to set pixel format 27 on device context 0x1e0052.
> > 003b:err:d3d:swapchain_create_context Failed to create a new context for the swapchain

They were also present before the regression, so maybe it's unrelated afterall.

In Aura 2 the crash occurs when you right-click to open the inventory bar
located at the bottom of the screen.
To reproduce the problem in Aura 2 demo:
- Install then start the game with TSR.exe. You can skip videos by pressing
<Space> or rename/remove the Video directory to get faster access to the point
where the crash occurs.
-  Start a new game from the main menu and press the right mouse button when
the game is loaded. The game crashes at this point.

AUR2_US_Demo_2007March26.exe (540 MB)
md5sum: 8afc5f4cf34da8c6ad5e4c5779a4840b

[Bug 47255] Xenonauts crashes in wined3d

https://bugs.winehq.org/show_bug.cgi?id=47255

Alexandr Oleynikov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Alexandr Oleynikov  ---
This issue also affects Overwatch. It crashes on the same message:
0156:err:d3d:swapchain_create_context Failed to create a new context for the
swapchain
What's weird is that it crashes even if I use a third-party D3D11/DXGI
impelementation like DXVK.
Reverting offending commit fixes the issue.

[Bug 47255] Multiple programs crash inside wined3d (Xenonauts, Overwatch, Aura 2: The Sacred Rings, Art of Murder: Cards of Destiny , LINE)

https://bugs.winehq.org/show_bug.cgi?id=47255

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Xenonauts crashes in        |Multiple programs  crash
                   |wined3d                     |inside wined3d (Xenonauts,
                   |                            |Overwatch, Aura 2: The
                   |                            |Sacred Rings, Art of
                   |                            |Murder: Cards of Destiny ,
                   |                            |LINE)
                 CC|                            |[e-mail]

--- Comment #3 from Louis Lenders  ---
Adjust title.For me LINE is also affected (free and small download:

https://web.archive.org/web/20190330095509if_/https://desktop.line-scdn.net/...

[Bug 47255] Multiple programs crash inside wined3d (Xenonauts, Overwatch, Aura 2: The Sacred Rings, Art of Murder: Cards of Destiny , LINE)

https://bugs.winehq.org/show_bug.cgi?id=47255

--- Comment #4 from Matteo Bruni  ---
Created attachment 64599
  --> https://bugs.winehq.org/attachment.cgi?id=64599
Possible fix

I only tested Aura 2. When you press the right mouse button, the game creates a
new d3d8 device on the desktop window. That currently fails in Wine (it's a
variant of bug 33476), swapchain->context[0] is left untouched and if that
happens to contain non-NULL, the game crashes.

The patch fixes the crash for me. BTW the context, and thus the device,
creation still fails so the inventory doesn't actually appear. I don't expect
it to be any different before the regression commit though.

Please test the patch, also with the other affected games.

[Bug 47255] Multiple programs crash inside wined3d (Xenonauts, Overwatch, Aura 2: The Sacred Rings, Art of Murder: Cards of Destiny , LINE)

https://bugs.winehq.org/show_bug.cgi?id=47255

--- Comment #5 from Louis Lenders  ---
Hi Matteo,

For LINE the crash is gone with the patch you attached; the app starts fine
again with patch applied

[Bug 47255] Multiple programs crash inside wined3d (Xenonauts, Overwatch, Aura 2: The Sacred Rings, Art of Murder: Cards of Destiny , LINE)

https://bugs.winehq.org/show_bug.cgi?id=47255

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 47255] Multiple programs crash inside wined3d (Xenonauts, Overwatch, Aura 2: The Sacred Rings, Art of Murder: Cards of Destiny , LINE)

https://bugs.winehq.org/show_bug.cgi?id=47255

--- Comment #6 from Béla Gyebrószki  ---
(In reply to Matteo Bruni from comment #4)
> The patch fixes the crash for me. BTW the context, and thus the device,
> creation still fails so the inventory doesn't actually appear. I don't
> expect it to be any different before the regression commit though.

You are right, the missing inventory panel bug was present before the
regression, it's bug #24613.
> Please test the patch, also with the other affected games.

The patch fixes the problem in all the affected games that I know of. Thank
you.

[Bug 47255] Multiple programs crash inside wined3d (Xenonauts, Overwatch, Aura 2: The Sacred Rings, Art of Murder: Cards of Destiny , LINE)

https://bugs.winehq.org/show_bug.cgi?id=47255

張修銘  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 47255] Multiple programs crash inside wined3d (Xenonauts, Overwatch, Aura 2: The Sacred Rings, Art of Murder: Cards of Destiny , LINE)

https://bugs.winehq.org/show_bug.cgi?id=47255

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from [e-mail] ---
(In reply to Béla Gyebrószki from comment #6)
> (In reply to Matteo Bruni from comment #4)
> > The patch fixes the crash for me. BTW the context, and thus the device,
> > creation still fails so the inventory doesn't actually appear. I don't
> > expect it to be any different before the regression commit though.
>
> You are right, the missing inventory panel bug was present before the
> regression, it's bug #24613.
> > Please test the patch, also with the other affected games.
>
> The patch fixes the problem in all the affected games that I know of. Thank
> you.

it also fixes bug 47299

[Bug 47255] Multiple programs crash inside wined3d (Xenonauts, Overwatch, Aura 2: The Sacred Rings, Art of Murder: Cards of Destiny , LINE)

https://bugs.winehq.org/show_bug.cgi?id=47255

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Józef Kucia  ---
*** Bug 47299 has been marked as a duplicate of this bug. ***

[Bug 47255] Multiple programs crash inside wined3d (Xenonauts, Overwatch, Aura 2: The Sacred Rings, Art of Murder: Cards of Destiny , LINE)

https://bugs.winehq.org/show_bug.cgi?id=47255

Sveinar Søpler  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Sveinar Søpler  ---
(In reply to Matteo Bruni from comment #4)
> Please test the patch, also with the other affected games.

Yeah, seems this fixes things for World of Warcraft at recent GIT aswell.
https://bugs.winehq.org/show_bug.cgi?id=47265#c21

If anyone can verify that would be nice.

[Bug 47255] Multiple programs crash inside wined3d (Xenonauts, Overwatch, Aura 2: The Sacred Rings, Art of Murder: Cards of Destiny , LINE)

https://bugs.winehq.org/show_bug.cgi?id=47255

--- Comment #10 from Sveinar Søpler  ---
(In reply to Sveinar Søpler from comment #9)
> (In reply to Matteo Bruni from comment #4)
> > Please test the patch, also with the other affected games.
>
> Yeah, seems this fixes things for World of Warcraft at recent GIT aswell.
> https://bugs.winehq.org/show_bug.cgi?id=47265#c21
>
> If anyone can verify that would be nice.

Well.. i guess i can verify my own testing.
https://bugs.winehq.org/show_bug.cgi?id=47265#c22

To keep it short, this patch creates another bug (atleast for me) with
mouselook and turning the character in-game. The character/screen will "skip"
when turning, and that makes the character kinda behave wildly.

[Bug 47255] Multiple programs crash inside wined3d (Xenonauts, Overwatch, Aura 2: The Sacred Rings, Art of Murder: Cards of Destiny , LINE)

https://bugs.winehq.org/show_bug.cgi?id=47255

--- Comment #11 from Alexandr Oleynikov  ---
(In reply to Sveinar Søpler from comment #10)
> (In reply to Sveinar Søpler from comment #9)
> > (In reply to Matteo Bruni from comment #4)
> > > Please test the patch, also with the other affected games.
> >
> > Yeah, seems this fixes things for World of Warcraft at recent GIT aswell.
> > https://bugs.winehq.org/show_bug.cgi?id=47265#c21
> >
> > If anyone can verify that would be nice.
>
> Well.. i guess i can verify my own testing.
> https://bugs.winehq.org/show_bug.cgi?id=47265#c22
>
> To keep it short, this patch creates another bug (atleast for me) with
> mouselook and turning the character in-game. The character/screen will
> "skip" when turning, and that makes the character kinda behave wildly.

I doubt a wined3d patch could cause a regression in input. Are you sure you
haven't experience this bug in Wine versions before this and that what you are
describing isn't bug 42675?

[Bug 47255] Multiple programs crash inside wined3d (Xenonauts, Overwatch, Aura 2: The Sacred Rings, Art of Murder: Cards of Destiny , LINE)

https://bugs.winehq.org/show_bug.cgi?id=47255

--- Comment #12 from Sveinar Søpler  ---
(In reply to Alexandr Oleynikov from comment #11)
> I doubt a wined3d patch could cause a regression in input. Are you sure you
> haven't experience this bug in Wine versions before this and that what you
> are describing isn't bug 42675?

https://bugs.winehq.org/show_bug.cgi?id=47265#c25

And to quote myself:
Just finished almost 2 hours with wine-staging-4.9 + Andrew's patch and vkd3d
in WoW now with no crashing or horrible issues :)

[Bug 47255] Multiple programs crash inside wined3d (Xenonauts, Overwatch, Aura 2: The Sacred Rings, Art of Murder: Cards of Destiny , LINE)

https://bugs.winehq.org/show_bug.cgi?id=47255

pattietreutel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 47255] Multiple programs crash inside wined3d (Xenonauts, Overwatch, Aura 2: The Sacred Rings, Art of Murder: Cards of Destiny , LINE)

https://bugs.winehq.org/show_bug.cgi?id=47255

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |d88c403e548cfe2171ac2260319
                   |                            |7ffbc0e70b4c2
         Resolution|---                         |FIXED

--- Comment #13 from Béla Gyebrószki  ---
Fixed with
https://source.winehq.org/git/wine.git/commit/d88c403e548cfe2171ac22603197ff...

[Bug 47255] Multiple programs crash inside wined3d (Xenonauts, Overwatch, Aura 2: The Sacred Rings, Art of Murder: Cards of Destiny , LINE)

https://bugs.winehq.org/show_bug.cgi?id=47255

Olivier F. R. Dierick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #14 from Olivier F. R. Dierick  ---
*** Bug 47321 has been marked as a duplicate of this bug. ***

[Bug 47255] Multiple programs crash inside wined3d (Xenonauts, Overwatch, Aura 2: The Sacred Rings, Art of Murder: Cards of Destiny , LINE)

https://bugs.winehq.org/show_bug.cgi?id=47255

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #15 from Alexandre Julliard  ---
Closing bugs fixed in 4.10.

[Bug 47255] Multiple programs crash inside wined3d (Xenonauts, Overwatch, Aura 2: The Sacred Rings, Art of Murder: Cards of Destiny , LINE)

https://bugs.winehq.org/show_bug.cgi?id=47255

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #16 from Louis Lenders  ---
*** Bug 47259 has been marked as a duplicate of this bug. ***

[Bug 47255] Multiple programs crash inside wined3d (Xenonauts, Overwatch, Aura 2: The Sacred Rings, Art of Murder: Cards of Destiny , LINE)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47255

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                URL|https://www.fileplanet.com/ |https://web.archive.org/web
                   |archive/p-823/Aura-2-The-Sa |/20210709121900/http://down
                   |cred-Rings-Demo             |load.fileplanet.com/ftp1/03
                   |                            |2007/AUR2_US_Demo_2007March
                   |                            |26.exe?st=lBxlmkaAEoHfMfbAZ
                   |                            |z3tnQ&e=1625843844