[Bug 54731] New: vbscript: stack_pop_bool doesn't support floats or ole color

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54731

Bug ID: 54731
           Summary: vbscript: stack_pop_bool doesn't support floats or ole
                    color
           Product: Wine
           Version: 8.4
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: vbscript
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

While working on porting Visual Pinball to cross platform, I've found some
scripts where comparisons that use floats and OLECOLOR directly fail. For
example:

If Light005.State Then
   ' State is a float V_R4 like 1.2
End If

If Light005.Colorfull Then
   ' Colorfull is an OLECOLOR VT_UI4
End If

Fixing involves updating stack_pop_bool to support more types as seen in
VARIANT_Coerce.

[Bug 54731] vbscript: stack_pop_bool doesn't support floats or ole color

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54731

--- Comment #1 from Jason Millard  ---
MR 2507 submitted.

[Bug 54731] vbscript: stack_pop_bool doesn't support floats or ole color

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54731

--- Comment #2 from Nikolay Sivov  ---
https://gitlab.winehq.org/wine/wine/-/merge_requests/3132

[Bug 54731] vbscript: stack_pop_bool doesn't support floats or ole color

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54731

--- Comment #3 from Jason Millard  ---
Fantastic! Tested and working great.

Apologizes on dropping the ball on MR 2507. Got sidetracked at the time and
forgot about wrapping it up.

[Bug 54731] vbscript: stack_pop_bool doesn't support floats or ole color

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54731

--- Comment #4 from Jason Millard  ---
Since there has been some updates on vbscript recently, figured I'd bump this.

I'm not sure why https://gitlab.winehq.org/wine/wine/-/merge_requests/3132
keeps failing the tests.

We have been using this patch for months and it does work fine.

[Bug 54731] vbscript: stack_pop_bool doesn't support floats or ole color

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54731

Robert Wilhelm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]

--- Comment #5 from Robert Wilhelm  ---

The failing test is

while null
    call ok(false, "while null evaluated")
wend

Looking at the MR, 
for case VT_NULL *b is assigned a value two time. 
At second time from uninitialized Variant v.

[Bug 54731] vbscript: stack_pop_bool doesn't support floats or ole color

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54731

--- Comment #6 from Jason Millard  ---
Strange that is passes on the linux-test-64 side?

[Bug 54731] vbscript: stack_pop_bool doesn't support floats or ole color

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54731

--- Comment #7 from Nikolay Sivov  ---
(In reply to Robert Wilhelm from comment #5)
> The failing test is
>
> while null
>     call ok(false, "while null evaluated")
> wend
>
> Looking at the MR, 
> for case VT_NULL *b is assigned a value two time. 
> At second time from uninitialized Variant v.

Good catch, I'll push an update.

[Bug 54731] vbscript: stack_pop_bool doesn't support floats or ole color

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54731

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |0a7f5646e48358222327f90d773
                   |                            |39e762922d7ad
             Status|NEW                         |RESOLVED

--- Comment #8 from Nikolay Sivov  ---
Marking fixed,
https://gitlab.winehq.org/wine/wine/-/commit/0a7f5646e48358222327f90d77339e7....

[Bug 54731] vbscript: stack_pop_bool doesn't support floats or ole color

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54731

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 9.0-rc1.