[Bug 33234] New: Improve user management

http://bugs.winehq.org/show_bug.cgi?id=33234

Bug #: 33234
           Summary: Improve user management
           Product: Wine-Testbot
           Version: unspecified
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

When an account request is sent to a WineTestBot administrator the URL he gfets
sent to is the UserDetails.pl one but it only has an 'Approve' button, not a
'Reject' one.

This makes it unclear how to reject spam requests for instance (bug 31798), but
this has now been documented. Still, rejecting an application actually requires
going to another page and deleting the provisional account. This should be
simpler: there should be a 'Reject' button right on the UserDetails page that
does that.

Furthermore, the status of the account, 'Pending approval' and 'Pending
activation', should be clearly indicated both on the UserDetails page and on
the UsersList page.

[Bug 33234] Improve user management

http://bugs.winehq.org/show_bug.cgi?id=33234

--- Comment #1 from François Gouget  2013-04-05 10:27:29 CDT ---
The missing reject button has been added in the commit below. Next giving a
better user status (I have a draft patch for that but I'm not entirely happy
with it).

commit e92578b7804177c3af9b9954781eb685d3c8bcc8
Author: Francois Gouget 
Date:   Thu Apr 4 12:29:44 2013 +0200

testbot/Users: Add a 'Reject' button for accounts waiting for approval.

[Bug 33234] Improve user management

http://bugs.winehq.org/show_bug.cgi?id=33234

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]

[Bug 33234] Improve user management

https://bugs.winehq.org/show_bug.cgi?id=33234

--- Comment #2 from François Gouget  ---
Created attachment 52533
  --> https://bugs.winehq.org/attachment.cgi?id=52533
Abuse the 'Status' field to show more details about accounts

This draft patch abuses the user Status field to show more information about
the account through color codes.

[Bug 33234] Improve user management

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=33234

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from François Gouget  ---
The patch is in and there are bugs for the other account-management issues. So
I'm closing this bug.

commit 5e371818f866e5f7958108d49502574161841680
Author: Francois Gouget 
Date:   Thu Dec 5 10:39:48 2019 +0100

testbot/web: Abuse the Status field to show more details about accounts.

This allows quickly identifying accounts that have been approved but
    where the user did not pick a password.

Signed-off-by: Francois Gouget 
    Signed-off-by: Alexandre Julliard

[Bug 33234] Improve user management

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=33234

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from François Gouget  ---
Closing.