[Bug 30432] New: UpdateResource doesn't update PE checksum neither Resource Table virtual address

http://bugs.winehq.org/show_bug.cgi?id=30432

Bug #: 30432
           Summary: UpdateResource doesn't update PE checksum neither
                    Resource Table virtual address
           Product: Wine
           Version: 1.3.26
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: kernel32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Hi,

I'm implementing a mt.exe clone which only can add a manifest to an EXE or DLL
file.

When I call BeginUpdateResource, UpdateResource and EndUpdateResource under
Windows to add a .manifest to a .exe the modified .exe has a valid checksum and
its Resource Table virtual address in PE header is defined.

Later if I call LoadLibrary and FindResourceEx with the resulting, it returns a
correct pointer on the manifest resource.

But if I call the same functions under Linux with WINE, the manifest seems to
be added to the EXE but the EXE checksum is set to 0 and Resource Table virtual
address too, so if I check the Manifest with FindResourceEx it returns NULL
because it can't find it.

I have some .exe with and without manifest and the corresponding .manifest if
you're interested to compare PE header.

I also have a test case to check if manifest is found.

Please could you fix that ?

Thanks

[Bug 30432] UpdateResource doesn't update PE checksum neither Resource Table virtual address

http://bugs.winehq.org/show_bug.cgi?id=30432

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Jerome Leclanche  2012-04-14 10:11:03 CDT ---
Please attach the test case, it'll help

[Bug 30432] UpdateResource doesn't update PE checksum neither Resource Table virtual address

http://bugs.winehq.org/show_bug.cgi?id=30432

--- Comment #2 from Cédric OCHS  2012-04-14 10:21:25 CDT ---
Created attachment 39792
  --> http://bugs.winehq.org/attachment.cgi?id=39792
testcase with an exe without manifest and manifest to add

There is the compiled test case with VC++ 2010 Express.

test.exe is a basic executable without manifest
test.exe.manifest is the manifest to be added to the exe

testcase.exe is the testcase that tries to add manifest to the exe and next
check if the manifest is accessible.

When launching under Window, I got :

Manifest added
Found manifest

Under Linux with WINE, I got :

Manifest added
Could not locate manifest

[Bug 30432] UpdateResource doesn't update PE checksum neither Resource Table virtual address

http://bugs.winehq.org/show_bug.cgi?id=30432

--- Comment #3 from Cédric OCHS  2012-04-14 10:22:34 CDT ---
Created attachment 39793
  --> http://bugs.winehq.org/attachment.cgi?id=39793
Testcase source

There is the C++ source of the testcase that is using all necessary
kernel32.dll API.

[Bug 30432] UpdateResource doesn't update PE checksum neither Resource Table virtual address

http://bugs.winehq.org/show_bug.cgi?id=30432

Cédric OCHS  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 30432] UpdateResource doesn't update PE checksum neither Resource Table virtual address

http://bugs.winehq.org/show_bug.cgi?id=30432

--- Comment #4 from Cédric OCHS  2012-04-14 14:47:43 CDT ---
I investigated further on this issue and it seems to occur only if the
executable doesn't have any resource before adding the manifest.

[Bug 30432] UpdateResource doesn't update PE checksum neither Resource Table virtual address

http://bugs.winehq.org/show_bug.cgi?id=30432

--- Comment #5 from Cédric OCHS  2012-04-14 14:51:24 CDT ---
Created attachment 39797
  --> http://bugs.winehq.org/attachment.cgi?id=39797
Resulting test.exe under Windows and under Linux with WINE

There are the 2 resulting exe :

- test_with_manifest_windows.exe under Windows
- test_with_manifest_wine.exe under Linux with WINE

[Bug 30432] UpdateResource doesn't update Resource Table virtual address

http://bugs.winehq.org/show_bug.cgi?id=30432

Cédric OCHS  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|UpdateResource doesn't      |UpdateResource doesn't
                   |update PE checksum neither  |update Resource Table
                   |Resource Table virtual      |virtual address
                   |address                     |

[Bug 30432] UpdateResource doesn't update Resource Table virtual address

http://bugs.winehq.org/show_bug.cgi?id=30432

--- Comment #6 from Cédric OCHS  2012-04-14 15:39:29 CDT ---
I updated issue title because PE checksum is optional and a bad value is not
important.

[Bug 30432] UpdateResource doesn't update Resource Table virtual address

https://bugs.winehq.org/show_bug.cgi?id=30432

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, testcase
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #7 from Austin English  ---
The original testcase still fails in git:
austin@aw25 ~/test $ wine testcase.exe 
fixme:heap:HeapSetInformation (nil) 1 (nil) 0
fixme:process:SetProcessDEPPolicy (1): stub
fixme:heap:HeapSetInformation (nil) 1 (nil) 0
fixme:process:SetProcessShutdownParameters (00000380, 00000000): partial stub.
fixme:heap:HeapSetInformation (nil) 1 (nil) 0
Manifest added
Could not locate manifest
austin@aw25 ~/test $ wine --version
wine-1.7.16-178-g7e874ae

I'm not sure what the updated testcase is supposed to do, but they both pass
for me:
austin@aw25 ~ $ wine test_with_manifest_windows.exe ; echo $?
fixme:heap:HeapSetInformation (nil) 1 (nil) 0
0
austin@aw25 ~ $ wine test_with_manifest_wine.exe ; echo $?
fixme:heap:HeapSetInformation (nil) 1 (nil) 0
0

[Bug 30432] UpdateResource doesn't update Resource Table virtual address

https://bugs.winehq.org/show_bug.cgi?id=30432

--- Comment #8 from Cédric OCHS  ---
Yes, both functions are called successfully but result is not correct :)

The manifest was not added to executable, you can check it manually by viewing
the executable with a Hex editor.

And the test program displayed :

Manifest added
Could not locate manifest

While it should display :

Manifest added
Found manifest

[Bug 30432] UpdateResource doesn't update Resource Table virtual address

http://bugs.winehq.org/show_bug.cgi?id=30432

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Sebastian Lackner  ---
Created attachment 48791
  --> http://bugs.winehq.org/attachment.cgi?id=48791
kernel32: Update VirtualAddress of resource section in write_raw_resources.

I'm wondering that noone else looked at this issue yet - if I don't miss
anything the virtual address should be relatively easy to fix. I've attached a
patch that lets the test succeed with "Found manifest". Please report back if
it solves the issue (and doesn't break anything else), if yes I'll send it to
wine-patches.

The checksum is a bit more difficult to fix, because either kernel32 would have
to import imagehlp (which is most likely not allowd) or we have to duplicate
code. This file already seems to contain a function to calculate the checksum:
http://source.winehq.org/source/dlls/imagehlp/modify.c#L88

[Bug 30432] UpdateResource doesn't update Resource Table virtual address

http://bugs.winehq.org/show_bug.cgi?id=30432

--- Comment #10 from Cédric OCHS  ---
Thanks a lot for the patch Sebastian, I'm compiling WINE with it and I'll check
it :)

About checksum, I don't think it's so important because it works anyway with a
wrong one (always to 0).

[Bug 30432] UpdateResource doesn't update Resource Table virtual address

http://bugs.winehq.org/show_bug.cgi?id=30432

--- Comment #11 from Cédric OCHS  ---
It seems to work perfectly :)

Thanks again and great job for this patch !

[Bug 30432] UpdateResource doesn't update Resource Table virtual address

http://bugs.winehq.org/show_bug.cgi?id=30432

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 30432] UpdateResource doesn't update Resource Table virtual address

http://bugs.winehq.org/show_bug.cgi?id=30432

--- Comment #12 from Sebastian Lackner  ---
Thanks for testing :)

My patch (including some additional tests) was submitted to wine-patches:
http://source.winehq.org/patches/data/105118

BTW: As it turns out this problem can even be reproduced with the wine test
suite - it just wasn't noticed because the tests didn't explicitly check the
resource directory virtual address.

[Bug 30432] UpdateResource doesn't update Resource Table virtual address

http://bugs.winehq.org/show_bug.cgi?id=30432

--- Comment #13 from Sebastian Lackner  ---
My patch got upstream today, so this problem should be fixed with commit:

http://source.winehq.org/git/wine.git/patch/270d66efc74c11d86ea1c62d289c825a...

Which will be included in wine >= 1.7.21.

[Bug 30432] UpdateResource doesn't update Resource Table virtual address

https://bugs.winehq.org/show_bug.cgi?id=30432

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |270d66efc74c11d86ea1c62d289
                   |                            |c825a225b1f37
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #14 from Nikolay Sivov  ---
Most likely fixed with 270d66efc74c11d86ea1c62d289c825a225b1f37.

[Bug 30432] UpdateResource doesn't update Resource Table virtual address

https://bugs.winehq.org/show_bug.cgi?id=30432

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #15 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.36.