http://bugs.winehq.org/show_bug.cgi?id=12478
Summary: Palringo: Pressing shift-enter in a chat window closes it Product: Wine Version: CVS/GIT Platform: PC URL: http://www.palringo.com OS/Version: Linux Status: UNCONFIRMED Severity: minor Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: andrew@palringo.com
This seems like it might be related to bug 12328.
Pressing Shift-Enter in a chat window should insert a new line, however, since WINE 0.9.59 and in GIT it closes the window.
http://bugs.winehq.org/show_bug.cgi?id=12478
Andrew Smith andrew@palringo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression
http://bugs.winehq.org/show_bug.cgi?id=12478
Lei Zhang thestig@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Component|-unknown |user32 Ever Confirmed|0 |1
--- Comment #1 from Lei Zhang thestig@google.com 2008-04-10 10:08:52 --- I don't think we're handling shift + enter or ctrl + enter correctly right now. I'll look into it.
http://bugs.winehq.org/show_bug.cgi?id=12478
--- Comment #2 from Andrew Smith andrew@palringo.com 2008-04-11 04:48:20 --- Ah thanks.
Just done a little checking back in GIT and found that
http://source.winehq.org/git/wine.git/?a=commitdiff;h=41ea8f0e8a6fab93fa08da...
that commit broke the shift-enter (i.e. the commit before worked and with that one it didn't), I tried to get the latest GIT and revert just that patch but it all failed and alas I'm not sure how to go about checking things.
http://bugs.winehq.org/show_bug.cgi?id=12478
--- Comment #3 from Lei Zhang thestig@google.com 2008-04-15 03:18:31 --- Created an attachment (id=12200) --> (http://bugs.winehq.org/attachment.cgi?id=12200) quick hack around the problem
Attached is a quick hack that lets you use shift + enter again.
I'm pretty sure this isn't the correct solution. It would be helpful if you can write a simple test app to demonstrate how palringo handles enter vs. shift + enter.
http://bugs.winehq.org/show_bug.cgi?id=12478
Lei Zhang thestig@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #12200|0 |1 is obsolete| |
--- Comment #4 from Lei Zhang thestig@google.com 2008-04-19 12:35:59 --- Created an attachment (id=12304) --> (http://bugs.winehq.org/attachment.cgi?id=12304) better patch
Elias Benali (Eee El P Tee R AT users.sourceforge.net) discovered a similar problem in the Windows's version of notepad. Here's what I think is the correct solution is. It still needs some unit tests to prove its correct, of course.
http://bugs.winehq.org/show_bug.cgi?id=12478
Lei Zhang thestig@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #12304|0 |1 is obsolete| |
--- Comment #5 from Lei Zhang thestig@google.com 2008-04-23 20:04:30 --- (From update of attachment 12304) Patches sent:
http://www.winehq.org/pipermail/wine-patches/2008-April/053914.html http://www.winehq.org/pipermail/wine-patches/2008-April/053915.html
http://bugs.winehq.org/show_bug.cgi?id=12478
Lei Zhang thestig@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #6 from Lei Zhang thestig@google.com 2008-04-24 10:32:49 --- Patch committed:
http://www.winehq.org/pipermail/wine-cvs/2008-April/042900.html
Marking as fixed. Please reopen if it's not.
http://bugs.winehq.org/show_bug.cgi?id=12478
--- Comment #7 from Andrew Smith andrew@palringo.com 2008-04-24 11:18:12 --- I've just tested with wine-0.9.60-255-ga3512ab (not sure which commit that is) and it all seems to work great, thanks :-)
http://bugs.winehq.org/show_bug.cgi?id=12478
Lei Zhang thestig@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |susancragin@earthlink.net
--- Comment #8 from Lei Zhang thestig@google.com 2008-04-25 13:45:37 --- *** Bug 12737 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=12478
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #9 from Alexandre Julliard julliard@winehq.org 2008-05-02 12:38:13 --- Closing bugs fixed in 0.9.61.
http://bugs.winehq.org/show_bug.cgi?id=12478
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|CVS/GIT |unspecified
-
wine-bugs＠winehq.org