[Bug 45836] New: Legend of grimrock 2: game doesn' t start anymore since wine 3.14 (unexpected NEW_IDENTIFIER error)

https://bugs.winehq.org/show_bug.cgi?id=45836

Bug ID: 45836
           Summary: Legend of grimrock 2: game doesn't start anymore since
                    wine 3.14 (unexpected NEW_IDENTIFIER error)
           Product: Wine
           Version: 3.14
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 62301
  --> https://bugs.winehq.org/attachment.cgi?id=62301
Logs wine 3.14

Hi,
since wine 3.14, when I try to start the game Legend of Grimrock 2 I get a
popup with following content (and of course the game doesn't go further):
"The following error occurred while starting up the game:
:1:216: error: syntax error, unexpected NEW_IDENTIFIER

Please check that your computer meets the minimum system requirements and that
your graphics card and sound card drivers are up to date."

Last working version was wine 3.13, I attach logs for version 3.13 and 3.14

Thank you for your help! Hope you can solve this big regression, the game
worked perfectly until version 3.14 :)

Thierry.

[Bug 45836] Legend of grimrock 2: game doesn' t start anymore since wine 3.14 (unexpected NEW_IDENTIFIER error)

https://bugs.winehq.org/show_bug.cgi?id=45836

--- Comment #1 from [e-mail] ---
Created attachment 62302
  --> https://bugs.winehq.org/attachment.cgi?id=62302
Logs wine 3.13

[Bug 45836] Legend of grimrock 2: game doesn' t start anymore since wine 3.14 (unexpected NEW_IDENTIFIER error)

https://bugs.winehq.org/show_bug.cgi?id=45836

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 45836] Legend of grimrock 2: game doesn' t start anymore since wine 3.14 (unexpected NEW_IDENTIFIER error)

https://bugs.winehq.org/show_bug.cgi?id=45836

--- Comment #2 from [e-mail] ---
Hi,
by reverting following patch the game works fine again:

d3dcompiler: Use d3dcompiler_47 for importlib.
author    Jacek Caban     
    Thu, 19 Jul 2018 12:36:28 +0000 (14:36 +0200)
committer    Alexandre Julliard     
    Tue, 14 Aug 2018 07:38:05 +0000 (09:38 +0200)
commit    169c033bda314358ee3ed085bffedf4bf763bfcf

Tested successfully on wine 3.14 and wine 3.16

Thierry.

[Bug 45836] Legend of grimrock 2: game doesn' t start anymore since wine 3.14 (unexpected NEW_IDENTIFIER error)

https://bugs.winehq.org/show_bug.cgi?id=45836

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 45836] Legend of grimrock 2: game doesn' t start anymore since wine 3.14 (unexpected NEW_IDENTIFIER error)

https://bugs.winehq.org/show_bug.cgi?id=45836

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |169c033bda314358ee3ed085bff
                   |                            |edf4bf763bfcf

[Bug 45836] Legend of grimrock 2: game doesn' t start anymore since wine 3.14 (unexpected NEW_IDENTIFIER error)

https://bugs.winehq.org/show_bug.cgi?id=45836

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Louis Lenders  ---
Could you add a log of console output running the game with
WINEDEBUG=+loaddll  ?

[Bug 45836] Legend of grimrock 2: game doesn' t start anymore since wine 3.14 (unexpected NEW_IDENTIFIER error)

https://bugs.winehq.org/show_bug.cgi?id=45836

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 45836] Legend of grimrock 2: game doesn' t start anymore since wine 3.14 (unexpected NEW_IDENTIFIER error)

https://bugs.winehq.org/show_bug.cgi?id=45836

--- Comment #4 from [e-mail] ---
Created attachment 62384
  --> https://bugs.winehq.org/attachment.cgi?id=62384
Logs wine 3.13 with debug (working ok)

[Bug 45836] Legend of grimrock 2: game doesn' t start anymore since wine 3.14 (unexpected NEW_IDENTIFIER error)

https://bugs.winehq.org/show_bug.cgi?id=45836

--- Comment #5 from [e-mail] ---
Created attachment 62385
  --> https://bugs.winehq.org/attachment.cgi?id=62385
Logs patched wine 3.14 with debug (working ok)

[Bug 45836] Legend of grimrock 2: game doesn' t start anymore since wine 3.14 (unexpected NEW_IDENTIFIER error)

https://bugs.winehq.org/show_bug.cgi?id=45836

--- Comment #6 from [e-mail] ---
Created attachment 62386
  --> https://bugs.winehq.org/attachment.cgi?id=62386
Logs wine 3.14 with debug (not working version)

[Bug 45836] Legend of grimrock 2: game doesn' t start anymore since wine 3.14 (unexpected NEW_IDENTIFIER error)

https://bugs.winehq.org/show_bug.cgi?id=45836

--- Comment #7 from [e-mail] ---
(In reply to Louis Lenders from comment #3)
> Could you add a log of console output running the game with
> WINEDEBUG=+loaddll  ?

Done :)

[Bug 45836] Legend of grimrock 2: game doesn' t start anymore since wine 3.14 (unexpected NEW_IDENTIFIER error)

https://bugs.winehq.org/show_bug.cgi?id=45836

--- Comment #8 from Louis Lenders  ---
So to summarize:

wine 3.13 (working ok:
0009:trace:loaddll:load_native_dll Loaded
L"C:\windows\system32\d3dcompiler_43.dll" at 0x650000: native

patched wine 3.14 (working ok:
0009:trace:loaddll:load_native_dll Loaded
L"C:\windows\system32\d3dcompiler_43.dll" at 0x650000: native

wine 3.14 with debug (not working version)
0009:trace:loaddll:load_builtin_dll Loaded
L"C:\windows\system32\d3dcompiler_47.dll" at 0x7de10000: builtin

I guess with patched wine you mean wine with reverted commit "Use
d3dcompiler_47 for importlib"?

So it`s using now builtin d3dcompiler_47, instead of d3dcompiler_43, for which
you have a native version lying around in system32 I guess

Putting a native d3dcompiler_47 in system32 should solve your problem I guess
(could you try that?), and I don`t think it`s really a regression, because you
would get the same error in wine-3.13 using builtin d3dcompiler_43 (could you
try that?)

Not sure what to do with bugreport for now, it`s really a bug in d3dcompiler
and not a regression I`d guess

[Bug 45836] Legend of grimrock 2: game doesn' t start anymore since wine 3.14 (unexpected NEW_IDENTIFIER error)

https://bugs.winehq.org/show_bug.cgi?id=45836

--- Comment #9 from [e-mail] ---
> I guess with patched wine you mean wine with reverted commit "Use
> d3dcompiler_47 for importlib"?

Yes, exactly.
> So it`s using now builtin d3dcompiler_47, instead of d3dcompiler_43, for
> which you have a native version lying around in system32 I guess

Yes, you're right.
> Putting a native d3dcompiler_47 in system32 should solve your problem I
> guess (could you try that?),

Yes, again you're right, by installing component d3dx9_43 and copying a native
d3dcompiler_47.dll into my system32, the game works again! Works with wine 3.14
and 3.16.
> and I don`t think it`s really a regression,
> because you would get the same error in wine-3.13 using builtin
> d3dcompiler_43 (could you try that?)

Yes, I removed the native d3dcompiler_43.dll from my system32, used wine 3.13,
and got an ":1:222: error: syntax error, unexpected NEW_IDENTIFIER" error.
So again, you're right.
> Not sure what to do with bugreport for now, it`s really a bug in d3dcompiler
> and not a regression I`d guess

Thank you Louis, you solved my problem. Without a wine expert, I would not have
understood the real problem here ;)
It would have been great to have some warning about inconsistent dll
installation since the switch from d3dcompiler_43.dll to d3dcompiler_47.dll,
but maybe I'm asking too much since it's not really a wine bug ;)

[Bug 45836] Legend of grimrock 2: game doesn' t start anymore since wine 3.14 (unexpected NEW_IDENTIFIER error)

https://bugs.winehq.org/show_bug.cgi?id=45836

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #10 from [e-mail] ---
I close my bug report since Louis found a solution to my problem.
Thank you again Louis!

Thierry.

[Bug 45836] Legend of grimrock 2: game doesn' t start anymore since wine 3.14 (unexpected NEW_IDENTIFIER error) ( native d3dcompiler is workaround)

https://bugs.winehq.org/show_bug.cgi?id=45836

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|169c033bda314358ee3ed085bff |
                   |edf4bf763bfcf               |
     Ever confirmed|0                           |1
             Status|RESOLVED                    |REOPENED
         Resolution|WONTFIX                     |---
            Summary|Legend of grimrock 2: game  |Legend of grimrock 2: game
                   |doesn't start anymore since |doesn't start anymore since
                   |wine 3.14 (unexpected       |wine 3.14 (unexpected
                   |NEW_IDENTIFIER error)       |NEW_IDENTIFIER error)
                   |                            |(native d3dcompiler is
                   |                            |workaround)
          Component|-unknown                    |directx-d3d
           Keywords|regression                  |

--- Comment #11 from Louis Lenders  ---
Hi, thanks for reporting back

It`s still a valid bug so i`m reopening this bugreport. 
Also others might run into the same issue.

I removed regression keyword and changed title to reflect problem. Regards

[Bug 45836] Legend of Grimrock 2: HLSL shader parsing failure

https://bugs.winehq.org/show_bug.cgi?id=45836

Matteo Bruni  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Legend of grimrock 2: game  |Legend of Grimrock 2: HLSL
                   |doesn't start anymore since |shader parsing failure
                   |wine 3.14 (unexpected       |
                   |NEW_IDENTIFIER error)       |
                   |(native d3dcompiler is      |
                   |workaround)                 |
          Component|directx-d3d                 |directx-d3dx9

[Bug 45836] Legend of Grimrock 2 fails to load due to HLSL compilation failure

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=45836

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Wine                        |vkd3d
            Summary|Legend of Grimrock 2: HLSL  |Legend of Grimrock 2 fails
                   |shader parsing failure      |to load due to HLSL
                   |                            |compilation failure
             Status|REOPENED                    |NEW
          Component|d3d-util                    |hlsl
            Version|3.14                        |1.6

--- Comment #12 from Gijs Vermeulen  ---
Still present with wine-8.0rc2. I tested the GOG version and forced d3dx9_43,
d3dcompiler_43 and 47 to builtin.

0024:fixme:d3dcompiler:D3DCompile2 Ignoring flags 0x8.
0024:err:d3dcompiler:D3DCompile2 Failed to compile shader, vkd3d result -4.
0024:err:d3dcompiler:D3DCompile2 Shader log:
0024:err:d3dcompiler:D3DCompile2     <anonymous>:1:122: E5005: Function "tex2D"
is not defined.
0024:err:d3dcompiler:D3DCompile2

[Bug 45836] Legend of Grimrock 2 fails to load due to HLSL compilation failure

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=45836

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #13 from Gijs Vermeulen  ---
Grouping HLSL bugs by missing functionality.

*** This bug has been marked as a duplicate of bug 33979 ***

[Bug 45836] Legend of Grimrock 2 fails to load due to HLSL compilation failure

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=45836

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Gijs Vermeulen  ---
Closing DUPLICATE.