[Bug 45982] New: SofTalk 1.56: Exit abnormally when pressing "Play" button ("Run-time error '5': Invalid procedure call or argument")

https://bugs.winehq.org/show_bug.cgi?id=45982

Bug ID: 45982
           Summary: SofTalk 1.56: Exit abnormally when pressing "Play"
                    button ("Run-time error '5': Invalid procedure call or
                    argument")
           Product: Wine
           Version: 3.18
          Hardware: x86-64
               URL: https://www.vector.co.jp/soft/winnt/art/se412443.html
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: kernel32
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
      Distribution: ---

This is a regression (this app works in 1.9.10) but I could not find the first
bad commit due to another regression (error on startup) that was introduced by
6938fec4aeb3b94ed184e3c272e7e278f354117e [1] and fixed by
429ca40fc89df38342a28047cf387ade9e2a05dc [2]:

* Before 6938fec4aeb3b94ed184e3c272e7e278f354117e: Works
* From 6938fec4aeb3b94ed184e3c272e7e278f354117e to
85cff1717d0aeb66aa1f5d8f271ddc6a21d2e1dd: Error on startup
* Since 429ca40fc89df38342a28047cf387ade9e2a05dc: Run-time error (this bug)

Steps to reproduce:

1. Download stk01560.zip from
https://www.vector.co.jp/soft/winnt/art/se412443.html
2. Download Winetricks from
https://raw.githubusercontent.com/Winetricks/winetricks/master/src/winetrick...
3. Run "chmod +x winetricks"
4. Run "./winetricks vb6run comctl32ocx"
5. Unpack stk01560.zip
6. Run softalk/SofTalk.exe on Japanese locale
7. Type "が" and press "Play (▶)" button

$ sha1sum stk01560.zip
2fa9d9e199796503748479d605b29c9607e8dec0  stk01560.zip

[1]:
https://source.winehq.org/git/wine.git/commitdiff/6938fec4aeb3b94ed184e3c272...
[2]:
https://source.winehq.org/git/wine.git/commitdiff/429ca40fc89df38342a28047cf...

[Bug 45982] SofTalk 1.56: Exit abnormally when pressing "Play" button (" Run-time error '5': Invalid procedure call or argument")

https://bugs.winehq.org/show_bug.cgi?id=45982

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 45982] SofTalk 1.56: Exit abnormally when pressing "Play" button (" Run-time error '5': Invalid procedure call or argument")

https://bugs.winehq.org/show_bug.cgi?id=45982

--- Comment #1 from Sagawa  ---
I can reproduce this issue. Now, I'm preparing a patch with test cases.

There is a bug inside required buffer size calculation. Unfortunately, it's
unconsidered that both LCMAP_KATAKANA and LCMAP_HALFWIDTH are used. Voiced
sound Hiragana characters (e.g. が) and semi-voiced sound Hiragana characters
(e.g. ぱ) are affected.

[Bug 45982] SofTalk 1.56: Exit abnormally when pressing "Play" button (" Run-time error '5': Invalid procedure call or argument")

https://bugs.winehq.org/show_bug.cgi?id=45982

--- Comment #2 from Sagawa  ---
I sent a patch to the list.
https://source.winehq.org/patches/data/152638

Thanks for reporting.

[Bug 45982] SofTalk 1.56: Exit abnormally when pressing "Play" button (" Run-time error '5': Invalid procedure call or argument")

https://bugs.winehq.org/show_bug.cgi?id=45982

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |b02cdd36150d7afc6cac52725e3
                   |                            |b659db0ec68f8

--- Comment #3 from [e-mail] ---
Fixed by
https://source.winehq.org/git/wine.git/commitdiff/b02cdd36150d7afc6cac52725e...

Thank you for fixing.

[Bug 45982] SofTalk 1.56: Exit abnormally when pressing "Play" button (" Run-time error '5': Invalid procedure call or argument")

https://bugs.winehq.org/show_bug.cgi?id=45982

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 3.19.