http://bugs.winehq.org/show_bug.cgi?id=32360
Bug #: 32360 Summary: Office 2010 installers report custom action page faults Product: Wine Version: 1.5.18 Platform: x86 OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: advapi32 AssignedTo: wine-bugs@winehq.org ReportedBy: bunglehead@gmail.com Classification: Unclassified
This a next problem after bug 32327 is fixed. During install I see this:
--- fixme:advapi:GetNamedSecurityInfoW Object type 4 is not currently supported. err:msi:ACTION_CallDllFunction Custom action (L"C:\users\nsivov\Temp\msi7b57.tmp":L"InstallActionPaneACEs") caused a page fault: c0000005 ---
and this
--- fixme:advapi:GetNamedSecurityInfoW Object type 2 is not currently supported. err:msi:ACTION_CallDllFunction Custom action (L"C:\users\nsivov\Temp\msib479.tmp":L"ExecSecureObjects") caused a page fault: c0000005 ---
So GetNamedSecurityInfoW() needs to support SE_SERVICE type (patches sent for that already) and SE_REGISTRY_KEY (could be done on top of RegGetKeySecurity() I think). Issue seems to be related to out parameters explicitly zeroed now, while before original patch from bug 32327 they were untouched.
http://bugs.winehq.org/show_bug.cgi?id=32360
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32327
http://bugs.winehq.org/show_bug.cgi?id=32360
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ehoover@mines.edu
http://bugs.winehq.org/show_bug.cgi?id=32360
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Platform|x86 |x86-64
http://bugs.winehq.org/show_bug.cgi?id=32360
--- Comment #1 from Erich Hoover ehoover@mines.edu 2012-12-04 10:51:02 CST --- (In reply to comment #0)
... So GetNamedSecurityInfoW() needs to support SE_SERVICE type (patches sent for that already) and SE_REGISTRY_KEY (could be done on top of RegGetKeySecurity() I think). Issue seems to be related to out parameters explicitly zeroed now, while before original patch from bug 32327 they were untouched.
Do you think we should not zero out the parameters to make the failure case better?
http://bugs.winehq.org/show_bug.cgi?id=32360
--- Comment #2 from Nikolay Sivov bunglehead@gmail.com 2012-12-04 11:19:53 CST --- (In reply to comment #1)
(In reply to comment #0)
... So GetNamedSecurityInfoW() needs to support SE_SERVICE type (patches sent for that already) and SE_REGISTRY_KEY (could be done on top of RegGetKeySecurity() I think). Issue seems to be related to out parameters explicitly zeroed now, while before original patch from bug 32327 they were untouched.
Do you think we should not zero out the parameters to make the failure case better?
No. I think we need tests for GetSecurityInfo() for SE_REGISTRY_KEY case to see if it differs from RegGetKeySecurity() and make it work properly. After that make GetNamedSecurityInfoW handle registry keys (create key from path and use GetSecurityInfo on it).
http://bugs.winehq.org/show_bug.cgi?id=32360
Erich Hoover ehoover@mines.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|wine-bugs@winehq.org |ehoover@mines.edu
--- Comment #3 from Erich Hoover ehoover@mines.edu 2012-12-04 12:38:56 CST --- Created attachment 42702 --> http://bugs.winehq.org/attachment.cgi?id=42702 Add support for service and registry objects in [Get|Set][Named]SecurrityInfo
I've attached a patch that implements support for both the service and the registry objects. I'm hoping that Alexandre will accept the service support today, so I'm going to hold off on submitting the registry support to see how that goes.
http://bugs.winehq.org/show_bug.cgi?id=32360
--- Comment #4 from Erich Hoover ehoover@mines.edu 2012-12-04 18:34:57 CST --- (In reply to comment #3)
Created attachment 42702 [details] Add support for service and registry objects in [Get|Set][Named]SecurrityInfo ...
Looks like Alexandre might not like something with the first part: http://source.winehq.org/patches/data/92478
Thoughts?
http://bugs.winehq.org/show_bug.cgi?id=32360
--- Comment #5 from Nikolay Sivov bunglehead@gmail.com 2012-12-05 00:03:40 CST --- Please use wine-devel to ask for feedback.
http://bugs.winehq.org/show_bug.cgi?id=32360
Michael McGuire spoon0042@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |spoon0042@hotmail.com
--- Comment #6 from Michael McGuire spoon0042@hotmail.com 2012-12-31 17:14:20 CST --- This seems to crash the Opera 12.12 installer as well. At least I get the "fixme:advapi:GetNamedSecurityInfoW Object type 4 is not currently supported." message and Opera's crash handler starts up, and regression testing flagged commit e3986462dfd807ff60265e79cd79017e1cee3800 which fixed the mentioned bug 32327. (It works in release 1.5.18 or so.)
http://bugs.winehq.org/show_bug.cgi?id=32360
--- Comment #7 from Erich Hoover ehoover@mines.edu 2013-01-03 16:26:22 CST --- (In reply to comment #6)
This seems to crash the Opera 12.12 installer as well. At least I get the "fixme:advapi:GetNamedSecurityInfoW Object type 4 is not currently supported." message and Opera's crash handler starts up, and regression testing flagged commit e3986462dfd807ff60265e79cd79017e1cee3800 which fixed the mentioned bug 32327. (It works in release 1.5.18 or so.)
I'm still working to get the patches for this accepted, could you please test the most recent version in wine-patches?: [1/7] http://source.winehq.org/patches/data/92912 [2/7] http://source.winehq.org/patches/data/92913 [3/7] http://source.winehq.org/patches/data/92914 [4/7] http://source.winehq.org/patches/data/92915 [5/7] http://source.winehq.org/patches/data/92916 [6/7] http://source.winehq.org/patches/data/92917 [7/7] http://source.winehq.org/patches/data/92918
http://bugs.winehq.org/show_bug.cgi?id=32360
--- Comment #8 from Michael McGuire spoon0042@hotmail.com 2013-01-05 17:54:46 CST --- Created attachment 43096 --> http://bugs.winehq.org/attachment.cgi?id=43096 wine (patched) console output for opera installer
(In reply to comment #7)
I'm still working to get the patches for this accepted, could you please test the most recent version in wine-patches?:
It doesn't crash now, at least. What does happen is the progress bar gets most of the way done and then pops up a bunch of registry error dialogs (giving the options "Ignore" and "Close", eventually one only allows "Close" then deletes everything), here's the text of the first:
Failed to modify registry Software\Classes\Opera{Product}.HTML\FriendlyTypeName. Error code: 39
Each comes with this corresponding error on the console:
fixme:advapi:GetExplicitEntriesFromAclW (nil) 0x33e2a8 0x33e2b0
I can't know if that's related to your changes or not but I've attached a log regardless, and can do further testing if you have any suggestions.
http://bugs.winehq.org/show_bug.cgi?id=32360
--- Comment #9 from Erich Hoover ehoover@mines.edu 2013-01-05 18:30:21 CST --- (In reply to comment #8)
... Each comes with this corresponding error on the console:
fixme:advapi:GetExplicitEntriesFromAclW (nil) 0x33e2a8 0x33e2b0
I can't know if that's related to your changes or not but I've attached a log regardless, and can do further testing if you have any suggestions.
I would guess that either: 1) How the function returns now requires GetExplicitEntriesFromAclW to be implemented for the app to succeed. 2) Some other function that stores the security settings is not properly implemented.
I would guess that it's #2. Before the routine just returned a blanket "world access" ACL, so now that the actual permissions are returned (once the patches are applied) the permissions need to be set properly in the first place for the correct permissions to be returned.
http://bugs.winehq.org/show_bug.cgi?id=32360
--- Comment #10 from Erich Hoover ehoover@mines.edu 2013-02-03 08:23:20 CST --- Michael,
I've done some more diagnostics and I can confirm that your issue is different from this one, though it still stems from the same change. What appears to be going on here is that the default ACL for registry keys is not accepted by the Opera installer. I've put together a patch to fix your issue, would you mind opening a new bug for the issue that depends on this one?
http://bugs.winehq.org/show_bug.cgi?id=32360
--- Comment #11 from Erich Hoover ehoover@mines.edu 2013-02-05 15:16:38 CST --- This issue should now be fixed as of commit 5915954ef1770cc0b377312bbea961c0bb629762. If you could please double check that that's the case then that would be greatly appreciated.
http://bugs.winehq.org/show_bug.cgi?id=32360
Michael McGuire spoon0042@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32904
http://bugs.winehq.org/show_bug.cgi?id=32360
--- Comment #12 from Bruno Jesus 00cpxxx@gmail.com 2013-04-11 18:45:29 CDT --- (In reply to comment #11)
This issue should now be fixed as of commit 5915954ef1770cc0b377312bbea961c0bb629762. If you could please double check that that's the case then that would be greatly appreciated.
Bug 32904 is now fixed and was depending on this bug so I really think this bug is fixed too.
http://bugs.winehq.org/show_bug.cgi?id=32360
--- Comment #13 from Nikolay Sivov bunglehead@gmail.com 2013-04-13 09:09:13 CDT --- With wine-1.5.28 I still get this one:
--- 00f3:trace:advapi:GetNamedSecurityInfoW L"MACHINE\Software\Microsoft\Schema Library\ActionsPane3" 4 4 (nil) (nil) 0xb65e67c (nil) 0xb65e678 00f3:err:msi:ACTION_CallDllFunction Custom action (L"C:\users\nsivov\Temp\msi3398.tmp":L"InstallActionPaneACEs") caused a page fault: c0000005 ---
http://bugs.winehq.org/show_bug.cgi?id=32360
Erich Hoover ehoover@mines.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #42702|0 |1 is obsolete| |
--- Comment #14 from Erich Hoover ehoover@mines.edu 2013-04-18 10:23:39 CDT --- Created attachment 44208 --> http://bugs.winehq.org/attachment.cgi?id=44208 Report a default DACL for registry keys
(In reply to comment #13)
With wine-1.5.28 I still get this one:
00f3:trace:advapi:GetNamedSecurityInfoW L"MACHINE\Software\Microsoft\Schema Library\ActionsPane3" 4 4 (nil) (nil) 0xb65e67c (nil) 0xb65e678 00f3:err:msi:ACTION_CallDllFunction Custom action (L"C:\users\nsivov\Temp\msi3398.tmp":L"InstallActionPaneACEs") caused a page fault: c0000005
Interesting, I thought I'd resolved that... Anyway, digging into the problem a little bit it appears that the installer is expecting a DACL. Please give the attached patch a try.
http://bugs.winehq.org/show_bug.cgi?id=32360
--- Comment #15 from Nikolay Sivov bunglehead@gmail.com 2013-04-18 11:24:17 CDT --- With this patch I don't get page fault message.
http://bugs.winehq.org/show_bug.cgi?id=32360
--- Comment #16 from Bruno Jesus 00cpxxx@gmail.com 2013-04-23 16:46:44 CDT --- Patch commited: http://source.winehq.org/git/wine.git/?a=commit;h=04cd764d7688c59f88c19b25d5...
http://bugs.winehq.org/show_bug.cgi?id=32360
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |04cd764d7688c59f88c19b25d5c | |6baea75a15ba1 Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #17 from Nikolay Sivov bunglehead@gmail.com 2013-04-29 01:31:04 CDT --- I just tried current wine and this seems to be fixed now. Thanks, Erich.
http://bugs.winehq.org/show_bug.cgi?id=32360
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #18 from Alexandre Julliard julliard@winehq.org 2013-05-10 13:42:12 CDT --- Closing bugs fixed in 1.5.30.
-
wine-bugs＠winehq.org