[Bug 23861] New: Regression: Adobe Acrobat 7.0 crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=23861

Summary: Regression: Adobe Acrobat 7.0 crashes on startup
           Product: Wine
           Version: 1.3.0
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

After upgrading from wine 1.2-rc7, Adobe Acrobat 7.0 will not work anymore
(both existing and new installation).

[Bug 23861] Adobe Acrobat 7.0 crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=23861

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Regression: Adobe Acrobat   |Adobe Acrobat 7.0 crashes
                   |7.0 crashes on startup      |on startup
           Severity|major                       |normal

--- Comment #1 from Nikolay Sivov   2010-08-01 05:18:31 ---
Perform regression test please http://wiki.winehq.org/RegressionTesting.

[Bug 23861] Adobe Acrobat 7.0 crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=23861

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 23861] Adobe Acrobat 7.0 crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=23861

Andrew Nguyen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #2 from Andrew Nguyen   2010-08-09 08:06:37 ---
Regression testing indicates:

6d1ef3a6a64f0fabf05ce1bba5f0ec4373684786 is first bad commit
commit 6d1ef3a6a64f0fabf05ce1bba5f0ec4373684786
Author: Huw Davies 
Date:   Thu Jul 22 13:37:19 2010 +0100

ole32: Implement cross-process drag and drop.

:040000 040000 ab88cc6bf0936bc4adc7bff0673415282613d919
065c727204a46d01708bc01f10484cad8527e1a2 M    dlls

[Bug 23861] Adobe Acrobat 7.0 crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=23861

--- Comment #3 from Andrew Nguyen   2010-08-09 08:07:47 ---
Created an attachment (id=30067)
 --> (http://bugs.winehq.org/attachment.cgi?id=30067)
Adobe Acrobat 7 backtrace with wine-1.3.0-166-g277040d

[Bug 23861] Adobe Acrobat 7.0 crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=23861

--- Comment #4 from Huw Davies   2010-08-09 08:22:33 ---
Could you attach a +ole,+tid,+seh log?

[Bug 23861] Adobe Acrobat 7.0 crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=23861

--- Comment #5 from Andrew Nguyen   2010-08-09 08:26:59 ---
Created an attachment (id=30068)
 --> (http://bugs.winehq.org/attachment.cgi?id=30068)
Adobe Acrobat 7 +ole,+seh,+tid trace

[Bug 23861] Adobe Acrobat 7.0 crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=23861

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |ftp://ftp.adobe.com/pub/ado
                   |                            |be/reader/win/6.x/6.0/enu/A
                   |                            |dbeRdr60_enu_full.exe
                 CC|                            |[e-mail]

--- Comment #6 from Ken Sharp  2010-11-29 19:52:08 CST ---
Also affects readers.

[Bug 23861] Adobe Acrobat 7.0 crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=23861

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |12451

[Bug 23861] Adobe Acrobat 7.0 crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=23861

--- Comment #7 from tom  2011-01-05 00:02:18 CST ---
Created an attachment (id=32730)
 --> (http://bugs.winehq.org/attachment.cgi?id=32730)
txt file: winedbg of acrobat launch

[Bug 23861] Adobe Acrobat 7.0 crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=23861

tom  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 23861] Adobe Acrobat 7.0 crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=23861

Igorko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 23861] Adobe Acrobat 7.0 crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=23861

Sylvain Petreolle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 23861] Adobe Acrobat 7.0 crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=23861

Trygve Vea  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Trygve Vea  2011-02-11 16:49:21 CST ---
Please feel free to correct me, because I'm fairly new at this.  I do however,
feel that this is valuable input - I would have supplied a patch if I was aware
of how I could fix this without breaking Drag'n'drop functionality.

I've done some testing, and I think I've figured out what triggers this bug.

In Adobe Reader, the crash occurs the second time RegisterDragDrop() is called.
 It crashes on the line which looks like this in dlls/ole32/ole2.c:

hr = IDropTarget_QueryInterface(pDropTarget, &IID_IUnknown, (void**)&unk);

This line in turn calls code implemented in Adobe Reader, followed by the
actual application crash.

The implementation of RegisterDragDrop differs from Windows in that respect,
because Windows' implementation does not do QueryInterface.  I've tested by
making some minor modifications to the test application (dragdrop.c) - and in
Windows, QueryInterface didn't run.

I hope this helps.

[Bug 23861] Adobe Acrobat 7.0 crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=23861

--- Comment #9 from Igorko  2011-03-18 05:03:23 CDT ---
Can someone make patch for fixing this bug?

[Bug 23861] Adobe Acrobat 7.0 crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=23861

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Anastasius Focht  2011-04-29 03:55:41 CDT ---
*** Bug 25749 has been marked as a duplicate of this bug. ***

[Bug 23861] Adobe Acrobat 7.0 crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=23861

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Anastasius Focht  2011-04-29 03:56:29 CDT ---
*** Bug 24660 has been marked as a duplicate of this bug. ***

[Bug 23861] Adobe Acrobat 7.0 crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=23861

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Anastasius Focht  2011-04-29 03:57:48 CDT ---
*** Bug 23894 has been marked as a duplicate of this bug. ***

[Bug 23861] Adobe Acrobat 7.0 crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=23861

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from Anastasius Focht  2011-04-29 03:58:36 CDT ---
*** Bug 23827 has been marked as a duplicate of this bug. ***

[Bug 23861] Multiple apps crash on startup/exit due to cross-process OLE drag and drop bug (Adobe Acrobat 7.0, HTML-Kit, Albumplayer, TortoiseSVN)

http://bugs.winehq.org/show_bug.cgi?id=23861

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|-unknown                    |ole32
            Summary|Adobe Acrobat 7.0 crashes   |Multiple apps crash on
                   |on startup                  |startup/exit due to
                   |                            |cross-process OLE drag and
                   |                            |drop bug (Adobe Acrobat
                   |                            |7.0, HTML-Kit, Albumplayer,
                   |                            |TortoiseSVN)

--- Comment #14 from Anastasius Focht  2011-04-29 04:03:43 CDT ---
Hello,

adjusting some fields and state this bug affects multiple apps.

Regards

[Bug 23861] Multiple apps crash on startup/exit due to cross-process OLE drag and drop bug (Adobe Acrobat 7.0, HTML-Kit, Albumplayer, TortoiseSVN)

http://bugs.winehq.org/show_bug.cgi?id=23861

--- Comment #15 from Toralf Förster  2011-04-29 04:22:49 CDT ---
(In reply to comment #8)
> It crashes on the line which looks like this in dlls/ole32/ole2.c:
>
> hr = IDropTarget_QueryInterface(pDropTarget, &IID_IUnknown, (void**)&unk);

Well, the issue was bisected last year already to a commit which was introduced
much earlier than the line you mentioned, look here please :
http://bugs.winehq.org/show_bug.cgi?id=23894#c6

[Bug 23861] Multiple apps crash on startup/exit due to cross-process OLE drag and drop bug (Adobe Acrobat 7.0, HTML-Kit, Albumplayer, TortoiseSVN)

http://bugs.winehq.org/show_bug.cgi?id=23861

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

--- Comment #16 from Ken Sharp  2011-04-29 07:43:17 CDT ---
Major     Major loss of functionality for a wide range of applications

Something like this no doubt affects more apps than we are currently aware of.

[Bug 23861] Multiple apps crash on startup/exit due to cross-process OLE drag and drop bug (Adobe Acrobat 7.0, HTML-Kit, Albumplayer, TortoiseSVN)

http://bugs.winehq.org/show_bug.cgi?id=23861

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from Anastasius Focht  2011-05-07 06:27:43 CDT ---
*** Bug 27086 has been marked as a duplicate of this bug. ***

[Bug 23861] Multiple apps crash on startup/exit due to cross-process OLE drag and drop bug (Adobe Acrobat 7.0, HTML-Kit, Albumplayer, TortoiseSVN)

http://bugs.winehq.org/show_bug.cgi?id=23861

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #18 from Anastasius Focht  2011-05-07 16:25:23 CDT ---
*** Bug 25664 has been marked as a duplicate of this bug. ***

[Bug 23861] Multiple apps crash on startup/exit due to cross-process OLE drag and drop bug (Adobe Acrobat 7.0, HTML-Kit, Albumplayer, TortoiseSVN)

http://bugs.winehq.org/show_bug.cgi?id=23861

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #19 from Anastasius Focht  2011-05-15 14:24:09 CDT ---
*** Bug 26193 has been marked as a duplicate of this bug. ***

[Bug 23861] Multiple apps crash on startup/exit due to cross-process OLE drag and drop bug (Adobe Acrobat 7.0, HTML-Kit, Albumplayer, TortoiseSVN)

http://bugs.winehq.org/show_bug.cgi?id=23861

--- Comment #20 from Adam Martinson  2011-05-20 16:16:04 CDT ---
Created an attachment (id=34810)
 --> (http://bugs.winehq.org/attachment.cgi?id=34810)
Patch -- please test

Try this ;-)  It worked for me with Adobe Reader 7 dragging some text into the
google search box in firefox, but that was the extent of my testing.

[Bug 23861] Multiple apps crash on startup/exit due to cross-process OLE drag and drop bug (Adobe Acrobat 7.0, HTML-Kit, Albumplayer, TortoiseSVN)

http://bugs.winehq.org/show_bug.cgi?id=23861

--- Comment #21 from Toralf Förster  2011-05-21 10:07:58 CDT ---
I solved bug #23894 :-)

[Bug 23861] Multiple apps crash on startup/exit due to cross-process OLE drag and drop bug (Adobe Acrobat 7.0, HTML-Kit, Albumplayer, TortoiseSVN)

http://bugs.winehq.org/show_bug.cgi?id=23861

--- Comment #22 from Milan Bouchet-Valat  2011-05-21 10:46:10 CDT ---
Do you mean this one should be fixed too?

[Bug 23861] Multiple apps crash on startup/exit due to cross-process OLE drag and drop bug (Adobe Acrobat 7.0, HTML-Kit, Albumplayer, TortoiseSVN)

http://bugs.winehq.org/show_bug.cgi?id=23861

--- Comment #23 from Igorko  2011-05-21 10:49:14 CDT ---
No. He means it's closed as duplicate of this bug.

[Bug 23861] Multiple apps crash on startup/exit due to cross-process OLE drag and drop bug (Adobe Acrobat 7.0, HTML-Kit, Albumplayer, TortoiseSVN)

http://bugs.winehq.org/show_bug.cgi?id=23861

--- Comment #24 from Igorko  2011-05-22 02:35:20 CDT ---
Patch works. Tested with Adobe Reader 7.1.0, Foobar with using Upnp Controller
and Albumplayer.

[Bug 23861] Multiple apps crash on startup/exit due to cross-process OLE drag and drop bug (Adobe Acrobat 7.0, HTML-Kit, Albumplayer, TortoiseSVN)

http://bugs.winehq.org/show_bug.cgi?id=23861

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11847

[Bug 23861] Multiple apps crash on startup/exit due to cross-process OLE drag and drop bug (Adobe Acrobat 7.0, HTML-Kit, Albumplayer, TortoiseSVN)

http://bugs.winehq.org/show_bug.cgi?id=23861

--- Comment #25 from Austin English  2011-06-01 17:24:48 CDT ---
(In reply to comment #20)
> Created an attachment (id=34810)

--> (http://bugs.winehq.org/attachment.cgi?id=34810) [details]
> Patch -- please test
>
> Try this ;-)  It worked for me with Adobe Reader 7 dragging some text into the
> google search box in firefox, but that was the extent of my testing.

Works for Acrobat Reader 6.01 (which otherwise crashes on start).

[Bug 23861] Multiple apps crash on startup/exit due to cross-process OLE drag and drop bug (Adobe Acrobat 7.0, HTML-Kit, Albumplayer, TortoiseSVN)

http://bugs.winehq.org/show_bug.cgi?id=23861

Elton Chung  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 23861] Multiple apps crash on startup/exit due to cross-process OLE drag and drop bug (Adobe Acrobat 7.0, HTML-Kit, Albumplayer, TortoiseSVN)

http://bugs.winehq.org/show_bug.cgi?id=23861

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #26 from Ken Sharp  2011-06-06 17:40:06 CDT ---
Was a patch sent / accepted?

[Bug 23861] Multiple apps crash on startup/exit due to cross-process OLE drag and drop bug (Adobe Acrobat 7.0, HTML-Kit, Albumplayer, TortoiseSVN)

http://bugs.winehq.org/show_bug.cgi?id=23861

--- Comment #27 from Austin English  2011-06-06 22:36:36 CDT ---
(In reply to comment #26)
> Was a patch sent / accepted?

Search wine-patches...yes:
http://www.winehq.org/pipermail/wine-patches/2011-June/102826.html

not yet accepted (though that last one was sent a bit late for today's push).

[Bug 23861] Multiple apps crash on startup/exit due to cross-process OLE drag and drop bug (Adobe Acrobat 7.0, HTML-Kit, Albumplayer, TortoiseSVN)

http://bugs.winehq.org/show_bug.cgi?id=23861

--- Comment #28 from Elton Chung  2011-06-07 05:39:16 CDT ---
Testbot completed testing the patch and returned with 0 failure.
http://testbot.winehq.org/JobDetails.pl?Key=11522

[Bug 23861] Multiple apps crash on startup/exit due to cross-process OLE drag and drop bug (Adobe Acrobat 7.0, HTML-Kit, Albumplayer, TortoiseSVN)

http://bugs.winehq.org/show_bug.cgi?id=23861

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #29 from Austin English  2011-06-08 12:40:49 CDT ---
(In reply to comment #27)
> (In reply to comment #26)
> > Was a patch sent / accepted?
>
> Search wine-patches...yes:
> http://www.winehq.org/pipermail/wine-patches/2011-June/102826.html
>
> not yet accepted (though that last one was sent a bit late for today's push).

Committed as
http://source.winehq.org/git/wine.git/commitdiff/e85668b4630266845c44c23450f...

[Bug 23861] Multiple apps crash on startup/exit due to cross-process OLE drag and drop bug (Adobe Acrobat 7.0, HTML-Kit, Albumplayer, TortoiseSVN)

http://bugs.winehq.org/show_bug.cgi?id=23861

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #30 from Alexandre Julliard  2011-06-10 13:18:18 CDT ---
Closing bugs fixed in 1.3.22.

[Bug 23861] Multiple apps crash on startup/exit due to cross-process OLE drag and drop bug (Adobe Acrobat 7.0, HTML-Kit, Albumplayer, TortoiseSVN)

http://bugs.winehq.org/show_bug.cgi?id=23861

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |e85668b4630266845c44c23450f
                   |                            |8006505ee73fa

[Bug 23861] Multiple apps crash on startup/exit due to cross-process OLE drag and drop bug (Adobe Acrobat 7.0, HTML-Kit, Albumplayer, TortoiseSVN)

https://bugs.winehq.org/show_bug.cgi?id=23861

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |6d1ef3a6a64f0fabf05ce1bba5f
                   |                            |0ec4373684786

[Bug 23861] Multiple apps crash on startup/exit due to cross-process OLE drag and drop bug (Adobe Acrobat 7.0, HTML-Kit, Albumplayer, TortoiseSVN)

https://bugs.winehq.org/show_bug.cgi?id=23861

Sylvain Petreolle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]         |