[Bug 42010] New: ReactOS Calc does not show dots in radio buttons.

List overview All Threads

newer

older

[Bug 40706] New: FolderMerger cmd...

[Bug 46215] New: File Open Dialog...

wine-bugs＠winehq.org

17 Dec 2016 17 Dec '16

1:38 p.m.

https://bugs.winehq.org/show_bug.cgi?id=42010

Bug ID: 42010 Summary: ReactOS Calc does not show dots in radio buttons. Product: Wine Version: 1.9.24 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: user32 Assignee: wine-bugs@winehq.org Reporter: carlo.bramix@libero.it Distribution: ---

Created attachment 56449 --> https://bugs.winehq.org/attachment.cgi?id=56449 ReactOS Calc running in WINE.

I tried to run my ReactOS Calc on WINE. It works fine but it does not show the dots inside the radio buttons. It works fine from Windows 9x to Windows 7, but not in WINE. Tested in lubuntu with latest trunk.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Show replies by date

wine-bugs＠winehq.org

17 Dec 17 Dec

2:01 p.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

Fabian Maurer dark.shadow4@web.de changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4@web.de

--- Comment #1 from Fabian Maurer dark.shadow4@web.de --- Can confirm this issue. Also, if you select the "Hex" option, the Qword/Dword/Word/Byte buttons work.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

2:17 p.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

winetest@luukku.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest@luukku.com

--- Comment #2 from winetest@luukku.com --- Possible dupe of bug 16845 it contains a patch. Could you test that? Also possible dupe of bug 32542.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

2:21 p.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

--- Comment #3 from Fabian Maurer dark.shadow4@web.de --- The patch won't work since it's for a keyboard issue, but I'm using mouse to click the buttons.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

18 Dec 18 Dec

6:15 a.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

--- Comment #4 from Austin English austinenglish@gmail.com --- Could you attach/link to the ReactOS calc.exe binary?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

6:47 a.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

Dmitry Timoshkov dmitry@baikal.ru changed:

--- Comment #5 from Dmitry Timoshkov dmitry@baikal.ru --- 1. calc sources from ReactOS won't compile neither with PSDK nor Wine headers, you may want to fix that (calc.h should include winbase.h after windef.h). 2. the problem with radio buttons is caused by broken logic in dlls/user32/ button.c,BM_SETCHECK handler. In particular BUTTON_CheckAutoRadioButton() helper does weird things, simply disabling this call fixes the bug.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

7:29 a.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

--- Comment #6 from Dmitry Timoshkov dmitry@baikal.ru --- (In reply to Dmitry Timoshkov from comment #5)

...

the problem with radio buttons is caused by broken logic in dlls/user32/

button.c,BM_SETCHECK handler. In particular BUTTON_CheckAutoRadioButton() helper does weird things, simply disabling this call fixes the bug.

That happens because ros calc managed radio buttons state manually: and it happens that it first turns on some button with BM_SETCHECK/1, and later turns on another button in the same group with BM_SETCHECK/1, and the latter one causes the first button to be turned off.

In my (pretty limited) testing I could observe something that resembles what BUTTON_CheckAutoRadioButton() is doing only on user interaction, i.e. with keyboard and mouse clicks. Perhaps managing button state programmatically with BM_SETCHECK shouldn't lead to automatic button state handling in user32.

All of this needs quite a bit of test cases.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

7:41 a.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

--- Comment #7 from Dmitry Timoshkov dmitry@baikal.ru --- Created attachment 56468 --> https://bugs.winehq.org/attachment.cgi?id=56468 patch

Attached patch seems to fix the problem for me.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

9:42 a.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

--- Comment #8 from Carlo Bramini carlo.bramix@libero.it --- ReactOS Calc can be found here:

https://sourceforge.net/projects/reactos-calc/files/reactos-calc/ReactOS%20C...

The link includes sources, binaries ASCII and UNICODE, with IEEE or GMP support as math library.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

9:47 a.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

--- Comment #9 from Carlo Bramini carlo.bramix@libero.it ---

...

calc sources from ReactOS won't compile neither with PSDK nor Wine headers

Actually this is a change made by ReactOS team, my original sources included just windows.h to be "universal".

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

11:01 a.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

--- Comment #10 from Carlo Bramini carlo.bramix@libero.it --- Created attachment 56473 --> https://bugs.winehq.org/attachment.cgi?id=56473 Precompiled binary of ReactOS Calc.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

4:04 p.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

Dmitry Timoshkov dmitry@baikal.ru changed:

--- Comment #11 from Dmitry Timoshkov dmitry@baikal.ru --- Created attachment 56475 --> https://bugs.winehq.org/attachment.cgi?id=56475 patch

Updated patch with redundant check removed.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

4:58 p.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

WineBuG winebugs140@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |winebugs140@gmail.com

--- Comment #12 from WineBuG winebugs140@gmail.com --- Is this a DUPLICATE of Bug 32542?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

5:46 p.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

Austin English austinenglish@gmail.com changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

5:46 p.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

Austin English austinenglish@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

6 p.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

--- Comment #13 from Carlo Bramini carlo.bramix@libero.it --- The patch written by Dmitry Timoshkov has resolved this issue on my side.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

21 Dec 21 Dec

9:30 a.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

Sebastian Lackner sebastian@fds-team.de changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

3:09 p.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

--- Comment #14 from WineBuG winebugs140@gmail.com --- This patch also fixes the Bug 32542. Now it really looks like a DUPLICATE.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

23 Dec 23 Dec

5:34 p.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

Rosanne DiMesio dimesio@earthlink.net changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |bkbk9@yahoo.ca

--- Comment #15 from Rosanne DiMesio dimesio@earthlink.net --- *** Bug 32542 has been marked as a duplicate of this bug. ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

27 Dec 27 Dec

11:33 p.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

Jeff Zaroyko jeffz@jeffz.name changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |asko.havumaki@gmail.com

--- Comment #16 from Jeff Zaroyko jeffz@jeffz.name --- *** Bug 34370 has been marked as a duplicate of this bug. ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

1 Jun 1 Jun

4:51 p.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

André H. nerv@dawncrow.de changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

28 Nov 28 Nov

5:42 a.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

Dmitry Timoshkov dmitry@baikal.ru changed:

--- Comment #17 from Dmitry Timoshkov dmitry@baikal.ru --- Committed as 96d0af52eb0d14084397647b974c5efebb59d0f0.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

7 Dec 7 Dec

6:14 p.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

Alexandre Julliard julliard@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED

--- Comment #18 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 4.0-rc1.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

22 Jan 22 Jan

11 p.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

Michael Stefaniuc mstefani@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |3.0.x

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

3 Mar 3 Mar

7:33 p.m.

New subject: [Bug 42010] ReactOS Calc does not show dots in radio buttons.

https://bugs.winehq.org/show_bug.cgi?id=42010

Michael Stefaniuc mstefani@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|3.0.x |---

--- Comment #19 from Michael Stefaniuc mstefani@winehq.org --- Removing the 3.0.x milestone from bug fixes included in 3.0.5.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

2145

Age (days ago)

2951

Last active (days ago)

wine-bugs@winehq.org

24 comments

1 participants

tags (0)

participants (1)

wine-bugs＠winehq.org