[Bug 15366] New: Starcraft cant find CD

http://bugs.winehq.org/show_bug.cgi?id=15366

Summary: Starcraft cant find CD
           Product: Wine
           Version: 1.1.5
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

In the wine version 1.1.5 Starcraft (Brood War) is not able to find the CD for
playing this game. 1.1.4 worked well.

[Bug 15366] Starcraft cant find CD

http://bugs.winehq.org/show_bug.cgi?id=15366

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

--- Comment #1 from Austin English   2008-09-22 08:55:03 ---
Please run a regression test:
http://wiki.winehq.org/RegressionTesting

[Bug 15366] Starcraft cant find CD

http://bugs.winehq.org/show_bug.cgi?id=15366

--- Comment #2 from Pink Sloth   2008-09-23 14:41:40 ---
5c2fd1b192380fb741781db55b8fb93c2a336810 is first bad commit
commit 5c2fd1b192380fb741781db55b8fb93c2a336810
Author: Mikołaj Zalewski 
Date:   Mon Sep 15 21:22:25 2008 +0200

oleaut32: VT_USERDEFINED records are passed by value.

:040000 040000 ee63d5979334d01790a80a8e1bfed4fde5f62461
019e74c19f4f892ea37793601b3351321c9e2d87 M      dlls

[Bug 15366] Starcraft cant find CD

http://bugs.winehq.org/show_bug.cgi?id=15366

Pink Sloth  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 15366] Starcraft cant find CD

http://bugs.winehq.org/show_bug.cgi?id=15366

--- Comment #3 from Lei Zhang   2008-09-28 15:15:46 ---
Can you double check and make sure that's the bad commit?

[Bug 15366] Starcraft cant find CD

http://bugs.winehq.org/show_bug.cgi?id=15366

--- Comment #4 from Pink Sloth   2008-10-02 13:43:26 ---
Sry I must have done something wrong at the last good/bad procedure ;)
This is my second Test and that is now the right one.

-----------------

b0192cfed382c470e67aaac744de56011fe27bfb is first bad commit
commit b0192cfed382c470e67aaac744de56011fe27bfb
Author: Alexandre Julliard 
Date:   Tue Sep 16 11:32:38 2008 +0200

ntdll: Hardcode the filesystem cluster size to avoid trouble on NFS.

:040000 040000 019e74c19f4f892ea37793601b3351321c9e2d87
8c6f6f10528df6a6f7a94f5c17c2bc3edeb87c49 M      dlls

[Bug 15366] Starcraft cant find CD

http://bugs.winehq.org/show_bug.cgi?id=15366

--- Comment #5 from Austin English   2008-10-02 14:06:02 ---
Does reverting that patch fix it?

[Bug 15366] Starcraft cant find CD

http://bugs.winehq.org/show_bug.cgi?id=15366

--- Comment #6 from Pink Sloth   2008-10-02 14:19:06 ---
(In reply to comment #5)
> Does reverting that patch fix it?

How can I revert that patch?
But if this help, the last time, with "0 to test after this", was OK.

[Bug 15366] Starcraft cant find CD

http://bugs.winehq.org/show_bug.cgi?id=15366

--- Comment #7 from Austin English   2008-10-02 14:58:41 ---
(In reply to comment #6)
> (In reply to comment #5)
> > Does reverting that patch fix it?
>
> How can I revert that patch?
> But if this help, the last time, with "0 to test after this", was OK.

$ git show b0192cfed382c470e67aaac744de56011fe27bfb | patch -p1 -R

[Bug 15366] Starcraft cant find CD

http://bugs.winehq.org/show_bug.cgi?id=15366

--- Comment #8 from Pink Sloth   2008-10-02 16:19:49 ---
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > Does reverting that patch fix it?
> >
> > How can I revert that patch?
> > But if this help, the last time, with "0 to test after this", was OK.
>
> $ git show b0192cfed382c470e67aaac744de56011fe27bfb | patch -p1 -R

This fixed the problem.

The relevant source from 2245 - 2271:
            else
            {
                /* Linux's fstatvfs is buggy */
#if !defined(linux) || !defined(HAVE_FSTATFS)
                struct statvfs stfs;

if (fstatvfs( fd, &stfs ) < 0)
                {
                    io->u.Status = FILE_GetNtStatus();
                    break;
                }
                info->BytesPerSector = stfs.f_frsize;
#else
                struct statfs stfs;
                if (fstatfs( fd, &stfs ) < 0)
                {
                    io->u.Status = FILE_GetNtStatus();
                    break;
                }
                info->BytesPerSector = stfs.f_bsize;
#endif
                info->TotalAllocationUnits.QuadPart = stfs.f_blocks;
                info->AvailableAllocationUnits.QuadPart = stfs.f_bavail;
                info->SectorsPerAllocationUnit = 1;
                io->Information = sizeof(*info);
                io->u.Status = STATUS_SUCCESS;
            }

[Bug 15366] Starcraft cant find CD

http://bugs.winehq.org/show_bug.cgi?id=15366

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Austin English   2008-10-02 18:35:50 ---
CC'ing author

[Bug 15366] Starcraft cant find CD

http://bugs.winehq.org/show_bug.cgi?id=15366

--- Comment #10 from Alexandre Julliard   2008-10-06 06:57:44 ---
Created an attachment (id=16499)
 --> (http://bugs.winehq.org/attachment.cgi?id=16499)
Fix block size for CD ROMs.

Does this help?

[Bug 15366] Starcraft cant find CD

http://bugs.winehq.org/show_bug.cgi?id=15366

--- Comment #11 from Pink Sloth   2008-10-06 10:44:38 ---
(In reply to comment #10)
> Created an attachment (id=16499)

--> (http://bugs.winehq.org/attachment.cgi?id=16499) [details]
> Fix block size for CD ROMs.
>
> Does this help?

Yes this solved the problem.

[Bug 15366] Starcraft cant find CD

http://bugs.winehq.org/show_bug.cgi?id=15366

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 15366] Starcraft cant find CD

http://bugs.winehq.org/show_bug.cgi?id=15366

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #12 from Austin English   2008-10-07 12:45:38 ---
Patch was committed to git

[Bug 15366] Starcraft cant find CD

http://bugs.winehq.org/show_bug.cgi?id=15366

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Alexandre Julliard   2008-10-10 10:11:05 ---
Closing bugs fixed in 1.1.6.