[Bug 35025] New: Max Payne 2 Demo: checkboxes in options dialog have missing window styles

http://bugs.winehq.org/show_bug.cgi?id=35025

Bug #: 35025
           Summary: Max Payne 2 Demo: checkboxes in options dialog have
                    missing window styles
           Product: Wine
           Version: 1.7.7
          Platform: x86-64
               URL: http://www.rockstargames.com/maxpayne2/mp2_downloads.h
                    tml
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 46685
  --> http://bugs.winehq.org/attachment.cgi?id=46685
dialog wine

launch the game, and click the options button. the options dialog appears, and
all of its checkboxes are rendered incorrectly due to a missing BS_LEFTTEXT
window style (aka BS_RIGHTBUTTON). instead of the label being placed to the
left of the box as it is on windows, wine places it to the right.

the BS_RIGHT style is also missing from the checkboxes, however it has no
effect because extended window style WS_EX_RIGHT is already set.

all this can be verified by running WinSpy++ on wine and windows and comparing
the checkboxes' window styles on both platforms.

note: i haven't checked the window styles of the other controls in the dialog.
i leave that as an exercise.

[Bug 35025] Max Payne 2 Demo: checkboxes in options dialog have missing window styles

http://bugs.winehq.org/show_bug.cgi?id=35025

--- Comment #1 from zippy  2013-11-30 20:36:28 CST ---
Created attachment 46686
  --> http://bugs.winehq.org/attachment.cgi?id=46686
dialog windows xp

[Bug 35025] Max Payne 2 Demo: checkboxes in options dialog have missing window styles

http://bugs.winehq.org/show_bug.cgi?id=35025

--- Comment #2 from zippy  2013-11-30 20:38:01 CST ---
Created attachment 46687
  --> http://bugs.winehq.org/attachment.cgi?id=46687
log win,dialog

[Bug 35025] Max Payne 2 Demo: checkboxes in options dialog have missing window styles

http://bugs.winehq.org/show_bug.cgi?id=35025

zippy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 35025] Max Payne 2 Demo: checkboxes in options dialog have missing window styles

http://bugs.winehq.org/show_bug.cgi?id=35025

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 35025] Max Payne 2 Demo: checkboxes in options dialog have missing window styles

http://bugs.winehq.org/show_bug.cgi?id=35025

zippy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |user32

--- Comment #3 from zippy  2013-12-09 15:23:21 CST ---
according to MSDN
(http://msdn.microsoft.com/en-us/library/windows/desktop/ff700543%28v=vs.85%2...):

Using the WS_EX_RIGHT style for static or edit controls has the same effect as
using the SS_RIGHT or ES_RIGHT style, respectively. Using this style with
button controls has the same effect as using BS_RIGHT and BS_RIGHTBUTTON
styles.

---------

so all that needs to be done is for wine's dialog template parser to check if
WS_EX_RIGHT is set and then set the appropriate window style flags depending on
the type of control.

*** setting the bug's component to user32.

[Bug 35025] Max Payne 2 Demo: checkboxes in options dialog have missing window styles

https://bugs.winehq.org/show_bug.cgi?id=35025

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from [e-mail] ---
Zippy care to make a patch? You found the issue, you have already analysed it.

[Bug 35025] Max Payne 2 Demo: checkboxes in options dialog have missing window styles

https://bugs.winehq.org/show_bug.cgi?id=35025

--- Comment #5 from Andrey Gusev  ---
Still in 1.7.37

[Bug 35025] Max Payne 2 Demo: checkboxes in options dialog have missing window styles

https://bugs.winehq.org/show_bug.cgi?id=35025

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #6 from Andrey Gusev  ---
Still in 1.7.49

[Bug 35025] Max Payne 2 Demo: checkboxes in options dialog have missing window styles

https://bugs.winehq.org/show_bug.cgi?id=35025

--- Comment #7 from Andrey Gusev  ---
Created attachment 52320
  --> https://bugs.winehq.org/attachment.cgi?id=52320
patch

This should help.

[Bug 35025] Max Payne 2 Demo: checkboxes in options dialog have missing window styles

https://bugs.winehq.org/show_bug.cgi?id=35025

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 35025] Max Payne 2 Demo: checkboxes in options dialog have missing window styles

https://bugs.winehq.org/show_bug.cgi?id=35025

Huw Davies  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Huw Davies  ---
Andrey, this patch looks good to me. Please rebase it and sent it in.

[Bug 35025] Max Payne 2 Demo: checkboxes in options dialog have missing window styles

https://bugs.winehq.org/show_bug.cgi?id=35025

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |[e-mail]
      Fixed by SHA1|                            |535f1de80db22e5ba76af5cb69a
                   |                            |e61524224eb31

--- Comment #9 from Andrey Gusev  ---
Fixed by commit
http://source.winehq.org/git/wine.git/commit/535f1de80db22e5ba76af5cb69ae615...

[Bug 35025] Max Payne 2 Demo: checkboxes in options dialog have missing window styles

https://bugs.winehq.org/show_bug.cgi?id=35025

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.22.

[Bug 35025] Max Payne 2 Demo: checkboxes in options dialog have missing window styles

https://bugs.winehq.org/show_bug.cgi?id=35025

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.8.x

[Bug 35025] Max Payne 2 Demo: checkboxes in options dialog have missing window styles

https://bugs.winehq.org/show_bug.cgi?id=35025

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.8.x                       |---

--- Comment #11 from Michael Stefaniuc  ---
Removing 1.8.x milestone from bugs included in 1.8.6.