[Bug 40709] New: iexplore crashes when proxy enabled

https://bugs.winehq.org/show_bug.cgi?id=40709

Bug ID: 40709
           Summary: iexplore crashes when proxy enabled
           Product: Wine
           Version: 1.9.11
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: wininet
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Enable Proxy support in the registry.

Running the following crashes.
wine iexplore

This worked in 1.9.10.

[Bug 40709] iexplore crashes when proxy enabled

https://bugs.winehq.org/show_bug.cgi?id=40709

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 40709] iexplore crashes when proxy enabled

https://bugs.winehq.org/show_bug.cgi?id=40709

--- Comment #1 from Alistair Leslie-Hughes  ---
Must also the 
ProxyOverride entry as well.

[Bug 40709] iexplore crashes when proxy enabled

https://bugs.winehq.org/show_bug.cgi?id=40709

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |bd1f39ea276bf8d96e82bc59bc8
                   |                            |872dd563361a9
                 CC|                            |[e-mail]

--- Comment #2 from Alistair Leslie-Hughes  ---
Reverting the following commit fixes the issue.
CC: Author of patch.

commit bd1f39ea276bf8d96e82bc59bc8872dd563361a9.
"wininet: Don't assume maximal URL length in HTTP_ShouldBypassProxy."

[Bug 40709] iexplore crashes when proxy enabled

https://bugs.winehq.org/show_bug.cgi?id=40709

--- Comment #3 from Jacek Caban  ---
This patch should help:
http://source.winehq.org/patches/data/122802

[Bug 40709] iexplore crashes when proxy enabled

https://bugs.winehq.org/show_bug.cgi?id=40709

--- Comment #4 from Bruno Jesus  ---
This was also detected by Coverity.

*** CID 1362146:  Null pointer dereferences  (FORWARD_NULL)
/home/amine/wine/dlls/wininet/http.c: 1773 in HTTP_ShouldBypassProxy()
1767         while(1) {
1768             LPCWSTR tmp = ptr;
1769
1770             ptr = strchrW( ptr, ';' );
1771             if (!ptr)
1772                 ptr = strchrW( tmp, ' ' );
> > > CID 1362146:  Null pointer dereferences  (FORWARD_NULL)
> > > Comparing "ptr" to null implies that "ptr" might be null.

1773             if (!ptr)
1774                 ptr = tmp + strlenW(ptr);
1775             ret = HTTP_DomainMatches( server, substr(tmp, ptr-tmp) );
1776             if (ret || !*ptr)
1777                 break;
1778             ptr++;

[Bug 40709] iexplore crashes when proxy enabled

https://bugs.winehq.org/show_bug.cgi?id=40709

Jacek Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |fff5dca78786060e8c9741fa7d4
                   |                            |1b153b937be6e

--- Comment #5 from Jacek Caban  ---
Fixed in Git, thanks for the report.

[Bug 40709] iexplore crashes when proxy enabled

https://bugs.winehq.org/show_bug.cgi?id=40709

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.12.