[Bug 54799] New: wininet:internet - test_InternetGetConnectedStateExA() fails in the Japanese and Chinese locales in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54799

Bug ID: 54799
           Summary: wininet:internet - test_InternetGetConnectedStateExA()
                    fails in the Japanese and Chinese locales in Wine
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: wininet
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

wininet:internet - test_InternetGetConnectedStateExA() fails in DBCS locales in
Wine.

* Japanese
  internet.c:1693: Test failed: Expected 7 bytes, got 8

* Chinese
  internet.c:1693: Test failed: Expected 9 bytes, got 10
  internet.c:1700: Test failed: Expected 4 bytes, got 10
  internet.c:1714: Test failed: Expected 1 byte, got 10

See https://test.winehq.org/data/patterns.html#wininet:internet

The test expects the buffer to always be null-terminated but that's not always
the case in Wine.

[Bug 54799] wininet:internet - test_InternetGetConnectedStateExA() fails in the Japanese and Chinese locales in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54799

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source, testcase
           Assignee|[e-mail]        |[e-mail]

[Bug 54799] wininet:internet - test_InternetGetConnectedStateExA() fails in the Japanese and Chinese locales in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54799

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |6fa67bc8d70368e33510cce5128
                   |                            |e9e01b2fdce7c
         Resolution|---                         |FIXED

--- Comment #1 from François Gouget  ---
This is fixed:

commit 6fa67bc8d70368e33510cce5128e9e01b2fdce7c
Author:     François Gouget 
AuthorDate: Fri Apr 7 15:23:40 2023 +0200

wininet: InternetGetConnectedStateExA() must always null-terminate the
state string.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54799

[Bug 54799] wininet:internet - test_InternetGetConnectedStateExA() fails in the Japanese and Chinese locales in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54799

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Alexandre Julliard  ---
Closing bugs fixed in 8.7.

[Bug 54799] wininet:internet - test_InternetGetConnectedStateExA() fails in the Japanese and Chinese locales in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54799

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |8.0.x

[Bug 54799] wininet:internet - test_InternetGetConnectedStateExA() fails in the Japanese and Chinese locales in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54799

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|8.0.x                       |---

--- Comment #3 from Michael Stefaniuc  ---
Removing the 8.0.x milestone from bug fixes included in 8.0.2.