[Bug 31031] New: Need For Speed Hot Pursuit (2010) crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=31031

Bug #: 31031
           Summary: Need For Speed Hot Pursuit (2010) crashes on startup
           Product: Wine
           Version: unspecified
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Need For Speed Hot Pursuit (2010) still crashes after implementing
Win32_NetworkAdapter WMI class. See the bug
http://bugs.winehq.org/show_bug.cgi?id=25252

fixmes before crash:

fixme:wbemprox:client_security_SetBlanket 0x7cdd9850, 0x17d090, 10, 0, (null),
3, 3, (nil), 0x00000000
fixme:wbemprox:client_security_Release 0x7cdd9850
fixme:win:EnumDisplayDevicesW ((null),0,0x32e664,0x00000000), stub!

The full crash message attached.

[Bug 31031] Need For Speed Hot Pursuit (2010) crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=31031

--- Comment #1 from John Yani  2012-06-26 14:58:26 CDT ---
Created attachment 40736
  --> http://bugs.winehq.org/attachment.cgi?id=40736
NFS11 trace +wbemprox

Full +wbemprox trace attached.

Executed queries before crash:

trace:wbemprox:wbem_services_ExecQuery 0x17d020, L"WQL", L"SELECT * FROM
Win32_NetworkAdapter WHERE NetConnectionStatus=2", 0x00000030, (nil), 0x32f768
trace:wbemprox:fill_networkadapter created 3 rows

trace:wbemprox:wbem_services_ExecQuery 0x17d020, L"WQL", L"SELECT * FROM
Win32_OperatingSystem", 0x00000030, (nil), 0x32f770
trace:wbemprox:fill_os created 1 row

trace:wbemprox:wbem_services_ExecQuery 0x17d020, L"WQL", L"SELECT * FROM
Win32_ComputerSystem", 0x00000030, (nil), 0x32f770

trace:wbemprox:wbem_services_ExecQuery 0x17d020, L"WQL", L"SELECT * FROM
Win32_VideoController", 0x00000030, (nil), 0x32f770
fixme:win:EnumDisplayDevicesW ((null),0,0x32e664,0x00000000), stub!
trace:wbemprox:fill_videocontroller created 1 row

trace:wbemprox:wbem_services_ExecQuery 0x17d020, L"WQL", L"SELECT * FROM
Win32_LogicalDisk", 0x00000030, (nil), 0x32f764

[Bug 31031] Unimplemented Win32_LogicalDisk WMI class causes Need For Speed Hot Pursuit (2010) to crash

http://bugs.winehq.org/show_bug.cgi?id=31031

John Yani  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |wmi&wbemprox
             Blocks|                            |20651
            Summary|Need For Speed Hot Pursuit  |Unimplemented
                   |(2010) crashes on startup   |Win32_LogicalDisk WMI class
                   |                            |causes Need For Speed Hot
                   |                            |Pursuit (2010) to crash

[Bug 31031] Unimplemented Win32_LogicalDisk WMI class causes Need For Speed Hot Pursuit (2010) to crash

http://bugs.winehq.org/show_bug.cgi?id=31031

John Yani  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.winehq.org/show
                   |                            |_bug.cgi?id=25252

[Bug 31031] Need For Speed Hot Pursuit (2010) crashes (needs Win32_LogicalDisk WMI class)

http://bugs.winehq.org/show_bug.cgi?id=31031

John Yani  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Unimplemented               |Need For Speed Hot Pursuit
                   |Win32_LogicalDisk WMI class |(2010) crashes (needs
                   |causes Need For Speed Hot   |Win32_LogicalDisk WMI
                   |Pursuit (2010) to crash     |class)

[Bug 31031] Need For Speed Hot Pursuit (2010) crashes (needs Win32_LogicalDisk WMI class)

http://bugs.winehq.org/show_bug.cgi?id=31031

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|20651                       |
         Depends on|                            |20651

[Bug 31031] Need For Speed Hot Pursuit (2010) crashes (needs Win32_LogicalDisk WMI class)

http://bugs.winehq.org/show_bug.cgi?id=31031

--- Comment #2 from John Yani  2012-06-26 17:31:19 CDT ---
Created attachment 40739
  --> http://bugs.winehq.org/attachment.cgi?id=40739
proposed patch

This is a stub implementation of Win32_LogicalDisk WMI class.

After applying this patch the game hangs.

[Bug 31031] Need For Speed Hot Pursuit (2010) crashes (needs Win32_LogicalDisk WMI class)

http://bugs.winehq.org/show_bug.cgi?id=31031

John Yani  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 31031] Need For Speed Hot Pursuit (2010) crashes (needs Win32_LogicalDisk WMI class)

http://bugs.winehq.org/show_bug.cgi?id=31031

--- Comment #3 from John Yani  2012-06-26 17:33:50 CDT ---
Can sb review the patch?

[Bug 31031] Need For Speed Hot Pursuit (2010) crashes (needs Win32_LogicalDisk WMI class)

http://bugs.winehq.org/show_bug.cgi?id=31031

--- Comment #4 from John Yani  2012-06-26 18:00:12 CDT ---
The last output before hang:

fixme:ddraw:DirectDrawEnumerateExA flags 0x00000001 not handled
fixme:win:EnumDisplayDevicesW ((null),0,0x32e9cc,0x00000000), stub!
fixme:ddraw:ddraw7_Initialize Ignoring guid
{00000000-0000-0000-0000-000000000000}.
fixme:ole:CoInitializeSecurity ((nil),-1,(nil),(nil),0,3,(nil),0,(nil)) - stub!
fixme:wbemprox:client_security_SetBlanket 0x7d4f9908, 0x17d1e8, 10, 0, (null),
3, 3, (nil), 0x00000000
fixme:wbemprox:client_security_Release 0x7d4f9908
fixme:win:EnumDisplayDevicesW ((null),0,0x32e664,0x00000000), stub!
fixme:wbemprox:fill_logicaldisk returns a fake logical disks table

Then the flood of the "fixme:d3d:resource_check_usage Unhandled usage flags
0x8."
Then:

fixme:wbemprox:client_security_SetBlanket 0x7d4f9908, 0x6e5f2778, 10, 0,
(null), 3, 3, (nil), 0x00000000
fixme:wbemprox:client_security_Release 0x7d4f9908
fixme:wbemprox:enum_class_object_Next timeout not supported

Then the flood of the "fixme:dinput:IDirectInputDevice2WImpl_GetProperty
Unknown property <guid-0x0012>"

Then hangs after "fixme:xinput:XInputGetState (0 0x6876e964)"

[Bug 31031] Need For Speed Hot Pursuit (2010) crashes (needs Win32_LogicalDisk WMI class)

http://bugs.winehq.org/show_bug.cgi?id=31031

thanoulas  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 31031] Need For Speed Hot Pursuit (2010) crashes (needs Win32_LogicalDisk WMI class)

http://bugs.winehq.org/show_bug.cgi?id=31031

--- Comment #5 from John Yani  2012-06-26 18:53:08 CDT ---
Tracing +wbemprox reveals the call to Win32_PNPEntity WMI class:

trace:wbemprox:wbem_services_CreateInstanceEnum 0x6e5f2cb8, L"Win32_PNPEntity",
000000000, (nil), 0x687ee3a0
trace:wbemprox:parse_query wql_parse returned 0
trace:wbemprox:EnumWbemClassObject_create (nil), 0x687ee3a0
trace:wbemprox:EnumWbemClassObject_create returning iface 0x6e5f2d80
trace:wbemprox:enum_class_object_Next 0x6e5f2d80, 10000, 20, 0x687ee3d0,
0x687ee3b0
fixme:wbemprox:enum_class_object_Next timeout not supported

[Bug 31031] Need For Speed Hot Pursuit (2010) crashes (needs Win32_LogicalDisk WMI class)

http://bugs.winehq.org/show_bug.cgi?id=31031

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Dan Kegel  2012-06-27 01:08:05 CDT ---
Your patch has

+ FIXME("returns a fake logical disks table\n");
+ UINT num_rows = 1;

That's a C++ism, please put declarations before statements.
Next step: send fixed patch to winetestbot; once it passes there, send it
to wine-patches.  See http://wiki.winehq.org/SubmittingPatches

[Bug 31031] Need For Speed Hot Pursuit (2010) crashes (needs Win32_LogicalDisk WMI class)

http://bugs.winehq.org/show_bug.cgi?id=31031

John Yani  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40739|0                           |1
        is obsolete|                            |

--- Comment #7 from John Yani  2012-06-27 03:32:15 CDT ---
Created attachment 40749
  --> http://bugs.winehq.org/attachment.cgi?id=40749
Win32_LogicalDisk stub

Winetestbot says "Patch doesn't affect tests".

[Bug 31031] Need For Speed Hot Pursuit (2010) crashes (needs Win32_LogicalDisk WMI class)

http://bugs.winehq.org/show_bug.cgi?id=31031

--- Comment #8 from John Yani  2012-06-27 03:54:06 CDT ---
This is probably how Win32_PNPEntity is used
http://code.google.com/p/gamekit/source/browse/trunk/Dependencies/Source/OIS...

[Bug 31031] Need For Speed Hot Pursuit (2010) crashes (needs Win32_LogicalDisk WMI class)

http://bugs.winehq.org/show_bug.cgi?id=31031

--- Comment #9 from Dan Kegel  2012-06-27 08:52:13 CDT ---
Yeah, see also
http://technet.microsoft.com/en-us/library/ee176998.aspx and
http://stackoverflow.com/questions/9325261/how-to-get-list-of-devices-with-y...

Please add a test to your patch.  It should pass regardless of whether there
are any such devices present.  See
http://www.winehq.org/docs/winedev-guide/testing

[Bug 31031] Need For Speed Hot Pursuit (2010) crashes (needs Win32_LogicalDisk WMI class)

http://bugs.winehq.org/show_bug.cgi?id=31031

--- Comment #10 from John Yani  2012-06-27 09:07:40 CDT ---
I'm not sure how to test it. Other patches to wbemprox don't have any tests.
Could you please point me to an example how to test wbemprox APIs?

[Bug 31031] Need For Speed Hot Pursuit (2010) crashes (needs Win32_LogicalDisk WMI class)

http://bugs.winehq.org/show_bug.cgi?id=31031

John Yani  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]         |

[Bug 31031] Need For Speed Hot Pursuit (2010) crashes (needs Win32_LogicalDisk WMI class)

http://bugs.winehq.org/show_bug.cgi?id=31031

--- Comment #11 from John Yani  2012-06-29 13:18:04 CDT ---
After applying this patch I am able to play the game when I run it via
Launcher.exe

[Bug 31031] Need For Speed Hot Pursuit (2010) crashes (needs Win32_LogicalDisk WMI class)

http://bugs.winehq.org/show_bug.cgi?id=31031

--- Comment #12 from Hans Leidekker  2012-06-29 16:22:44 CDT ---
(In reply to comment #11)
> After applying this patch I am able to play the game when I run it via
> Launcher.exe

Can you also play it with current git?

[Bug 31031] Need For Speed Hot Pursuit (2010) crashes (needs Win32_LogicalDisk WMI class)

http://bugs.winehq.org/show_bug.cgi?id=31031

John Yani  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |8dcc3b9d5664deefd2a7eecc763
                   |                            |b26097f2d27a2
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #13 from John Yani  2012-06-29 17:01:58 CDT ---
> Can you also play it with current git?

Yes, thanks! Marking as resolved.

[Bug 31031] Need For Speed Hot Pursuit (2010) crashes (needs Win32_LogicalDisk WMI class)

http://bugs.winehq.org/show_bug.cgi?id=31031

--- Comment #14 from John Yani  2012-06-30 18:15:05 CDT ---
Performance bug is here: http://bugs.winehq.org/show_bug.cgi?id=31078

[Bug 31031] Need For Speed Hot Pursuit (2010) crashes (needs Win32_LogicalDisk WMI class)

http://bugs.winehq.org/show_bug.cgi?id=31031

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #15 from Alexandre Julliard  2012-07-03 14:14:55 CDT ---
Closing bugs fixed in 1.5.8.

[Bug 31031] Need For Speed Hot Pursuit (2010) crashes (needs Win32_LogicalDisk WMI class)

http://bugs.winehq.org/show_bug.cgi?id=31031

Kagisho  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #16 from Kagisho  2012-08-13 11:01:14 CDT ---
Hi, I am quite new to Winebugs. Could someone please tell me how to implement
bug fixes like the two above, I am also having trouble starting NFS Hot Pursuit
2010. I tried pasting the code in Terminal but it did not seem to work.

[Bug 31031] Need For Speed Hot Pursuit (2010) crashes (needs Win32_LogicalDisk WMI class)

http://bugs.winehq.org/show_bug.cgi?id=31031

--- Comment #17 from Dan Kegel  2012-08-13 12:10:27 CDT ---
Bugzilla is not a support forum.

Please ask on http://forum.winehq.org