[Bug 19491] New: WSASend() fails when lpNumberOfBytesSent is NULL

http://bugs.winehq.org/show_bug.cgi?id=19491

Summary: WSASend() fails when lpNumberOfBytesSent is NULL
           Product: Wine
           Version: 1.1.26
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: winsock
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

WSASend() returns an error when lpNumberOfBytesSent (which is an output
parameter) is NULL. There is a condition in WSASendTo() in ws2_32/socket.c
which returns an EFAULT when lpNumberOfBytesSent is a NULL pointer.

While this makes sense, setting this argument to NULL is explicitly allowed by
the MSDN documentation, if the lpOverlapped parameter is present.

Not immediately clear how to fix this, since it involves checking how
overlapped i/o and i/o completion play out.

[Bug 19491] WSASend() fails when lpNumberOfBytesSent is NULL

http://bugs.winehq.org/show_bug.cgi?id=19491

--- Comment #1 from Austin English   2009-07-28 11:12:07 ---
Add a testcase dlls/ws2_32/tests/sock.c.

[Bug 19491] WSASend() fails when lpNumberOfBytesSent is NULL

http://bugs.winehq.org/show_bug.cgi?id=19491

--- Comment #2 from Austin English  2010-09-07 16:48:51 CDT ---
This is your friendly reminder  that there has been no bug activity for a year.
Is this still an issue in current (1.3.2 or newer) wine?

[Bug 19491] WSASend() fails when lpNumberOfBytesSent is NULL

http://bugs.winehq.org/show_bug.cgi?id=19491

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Jerome Leclanche  2011-02-05 00:19:58 CST ---
+patch
A patch was sent, but was not committed.
http://www.winehq.org/pipermail/wine-patches/2010-November/096046.html

[Bug 19491] WSASend() fails when lpNumberOfBytesSent is NULL

http://bugs.winehq.org/show_bug.cgi?id=19491

Ilya Konovalov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Ilya Konovalov  2011-06-03 15:24:02 CDT ---
It seems that current test build of Eve Online is affected by this bug.

http://www.eveonline.com/ingameboard.asp?a=topic&threadID=1521316

[Bug 19491] WSASend() fails when lpNumberOfBytesSent is NULL

http://bugs.winehq.org/show_bug.cgi?id=19491

--- Comment #5 from Ilya Konovalov  2011-06-03 17:12:35 CDT ---
Created an attachment (id=35010)
 --> (http://bugs.winehq.org/attachment.cgi?id=35010)
Updated patch

The patch applies to commit e398b93900c45cc5d1457ee4d33866c4e0116bfe
It does fix the described problem with Eve Online test server access.

[Bug 19491] WSASend() fails when lpNumberOfBytesSent is NULL

http://bugs.winehq.org/show_bug.cgi?id=19491

Tim Cumming  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #6 from Tim Cumming  2011-06-04 07:39:32 CDT ---
*** This bug has been confirmed by popular vote. ***

[Bug 19491] WSASend() fails when lpNumberOfBytesSent is NULL

http://bugs.winehq.org/show_bug.cgi?id=19491

N. Andrew Walsh  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from N. Andrew Walsh  2011-06-10 13:06:18 CDT ---
we have a bit under two weeks before the new EVE version goes to the main
branch. It would be awesome if this gets fixed before then.

[Bug 19491] WSASend() fails when lpNumberOfBytesSent is NULL

http://bugs.winehq.org/show_bug.cgi?id=19491

Tim Cumming  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                   |                            |m

--- Comment #8 from Tim Cumming  2011-06-10 15:33:55 CDT ---
Ilya Konovalov's patch applies cleanly to latest release (1.3.22) and allows
EVE Online 7.1.x to connect to Singularity server.

[Bug 19491] WSASend() fails when lpNumberOfBytesSent is NULL

http://bugs.winehq.org/show_bug.cgi?id=19491

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Hans Leidekker  2011-06-14 12:41:56 CDT ---
Fixed by 3581d2c6d176fe922ee4c8b05768f18c59c93008.

[Bug 19491] WSASend() fails when lpNumberOfBytesSent is NULL

http://bugs.winehq.org/show_bug.cgi?id=19491

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard  2011-06-24 17:44:47 CDT ---
Closing bugs fixed in 1.3.23.