http://bugs.winehq.org/show_bug.cgi?id=33122
Bug #: 33122 Summary: TESV: Skyrim graphics error in Wine 1.5.25 Product: Wine Version: 1.5.25 Platform: x86 OS/Version: Mac OS X Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-d3d AssignedTo: wine-bugs@winehq.org ReportedBy: zoroaster@inode.at Classification: Unclassified
Created attachment 43802 --> http://bugs.winehq.org/attachment.cgi?id=43802 Screenshot
Turning around ingame at some point of lighting you see dark rectangle zones on the screen. This problem was not visible in Wine 1.5.24, it happens since Wine 1.5.25.
http://bugs.winehq.org/show_bug.cgi?id=33122
--- Comment #1 from zoroaster zoroaster@inode.at 2013-03-04 13:33:25 CST --- Created attachment 43803 --> http://bugs.winehq.org/attachment.cgi?id=43803 err:d3d_surface:surface_modify_location Surface 0x1c5a30 does not have any up to date location.
http://bugs.winehq.org/show_bug.cgi?id=33122
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
--- Comment #2 from Austin English austinenglish@gmail.com 2013-03-04 14:54:57 CST --- Please run a regression test: http://wiki.winehq.org/RegressionTesting
http://bugs.winehq.org/show_bug.cgi?id=33122
Matteo Bruni matteo.mystral@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |matteo.mystral@gmail.com
--- Comment #3 from Matteo Bruni matteo.mystral@gmail.com 2013-03-06 11:27:52 CST --- I suppose this is a regression from 25d0d0876d290e1e803ce16ed9d96189ba5948e1.
Alas, I can't reproduce here. Can you attach a savegame where the issue happens? Also it might be related to graphic settings / GPU, can you give me some info in that regard too?
Otherwise you could attach a +d3d9,+d3d,+d3d_surface,+d3d_texture trace, but that's going to be very large (and I'd prefer to reproduce it myself if possible).
http://bugs.winehq.org/show_bug.cgi?id=33122
--- Comment #4 from zoroaster zoroaster@inode.at 2013-03-10 11:34:10 CDT --- Here are a few additional infos for regression:
Graphics is AMD Radeon HD 6750M 1024 MB which is recognised by Wine/Skyrim as AMD Radeon HD 6600M Series. Skyrim configuration is the default "High" with exception that I use FXAA instead of AA. With these hardware/settings the issue can be reproduced with any savegame at least in outdoor environment during the day. But it is not visible all the time you must turn around (it may have something to do with lighting/shadows).
http://bugs.winehq.org/show_bug.cgi?id=33122
--- Comment #5 from zoroaster zoroaster@inode.at 2013-03-24 19:22:30 CDT --- Created attachment 44011 --> http://bugs.winehq.org/attachment.cgi?id=44011 Wine 1.5.26
The graphical issues also exist in 1.5.26 with macdrv. I tried to run Wine 1.5.26 with WINEDEBUG=+d3d9,+d3d,+d3d_surface,+d3d_texture but the log was about 3GB after 2 min of running the game (I cannot help you further).
http://bugs.winehq.org/show_bug.cgi?id=33122
--- Comment #6 from zoroaster zoroaster@inode.at 2013-03-26 13:29:19 CDT --- (In reply to comment #3)
I suppose this is a regression from 25d0d0876d290e1e803ce16ed9d96189ba5948e1.
Alas, I can't reproduce here. Can you attach a savegame where the issue happens? Also it might be related to graphic settings / GPU, can you give me some info in that regard too?
Otherwise you could attach a +d3d9,+d3d,+d3d_surface,+d3d_texture trace, but that's going to be very large (and I'd prefer to reproduce it myself if possible).
Confirmed.
The issue happens since 25d0d0876d290e1e803ce16ed9d96189ba5948e1. I proved this by rejecting this patch and now there are no graphical errors anymore. I am not familiar with the code details but maybe the error can be found in changes of surface_load_location() function.
http://bugs.winehq.org/show_bug.cgi?id=33122
--- Comment #7 from zoroaster zoroaster@inode.at 2013-03-31 06:41:52 CDT --- (In reply to comment #2)
Please run a regression test: http://wiki.winehq.org/RegressionTesting
$ git bisect bad Bisecting: 0 revisions left to test after this (roughly 0 steps) [25d0d0876d290e1e803ce16ed9d96189ba5948e1] wined3d: Make (wined3d_)surface_depth_blt_fbo handle locations other than SFLAG_INTEXTURE.
Reverting the patch in wine master introduces a new bug: some surfaces are missing/not drawn i.e. water surfaces (GL_FRAMEBUFFER_INCOMPLETE_DRAW_BUFFER still appears, see attachments).
The latest working wine without these issues is 1.5.24.
http://bugs.winehq.org/show_bug.cgi?id=33122
Henri Verbeet hverbeet@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |25d0d0876d290e1e803ce16ed9d | |96189ba5948e1
http://bugs.winehq.org/show_bug.cgi?id=33122
--- Comment #8 from zoroaster zoroaster@inode.at 2013-04-10 17:56:49 CDT --- Made a regression test for the second issue: cause of missing surfaces is 5e28b0c9747369b752102e56b94e58a012b8cf6d.
(everything works fine without these two commits)
http://bugs.winehq.org/show_bug.cgi?id=33122
--- Comment #9 from Matteo Bruni matteo.mystral@gmail.com 2013-04-11 16:53:33 CDT --- Created attachment 44149 --> http://bugs.winehq.org/attachment.cgi?id=44149 patch
(In reply to comment #8)
Made a regression test for the second issue: cause of missing surfaces is 5e28b0c9747369b752102e56b94e58a012b8cf6d.
(everything works fine without these two commits)
It makes sense, 5e28b0c9747369b752102e56b94e58a012b8cf6d requires 25d0d0876d290e1e803ce16ed9d96189ba5948e1 to work correctly, if the related functionality is actually used by the game.
BTW I got an idea about what could be the problem. Does the attached patch help?
http://bugs.winehq.org/show_bug.cgi?id=33122
zoroaster zoroaster@inode.at changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #10 from zoroaster zoroaster@inode.at 2013-04-12 12:01:07 CDT --- (In reply to comment #9)
Created attachment 44149 [details] patch
(In reply to comment #8)
Made a regression test for the second issue: cause of missing surfaces is 5e28b0c9747369b752102e56b94e58a012b8cf6d.
(everything works fine without these two commits)
It makes sense, 5e28b0c9747369b752102e56b94e58a012b8cf6d requires 25d0d0876d290e1e803ce16ed9d96189ba5948e1 to work correctly, if the related functionality is actually used by the game.
BTW I got an idea about what could be the problem. Does the attached patch help?
I had only time to make a short test but it seems that the problems are fixed with the attached patch.
Additional features also seem to work i.e. underwater view without changing the default configuration of the game.
Thank you.
http://bugs.winehq.org/show_bug.cgi?id=33122
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|FIXED |
--- Comment #11 from Alexandre Julliard julliard@winehq.org 2013-04-12 12:22:24 CDT --- Not fixed until the patch is committed.
http://bugs.winehq.org/show_bug.cgi?id=33122
--- Comment #12 from zoroaster zoroaster@inode.at 2013-04-19 16:06:07 CDT --- (In reply to comment #11)
Not fixed until the patch is committed.
Sorry.
Additional info: I have run the game for some hours with the patch now and I did not find any of above mentioned issues anymore.
http://bugs.winehq.org/show_bug.cgi?id=33122
--- Comment #13 from zoroaster zoroaster@inode.at 2013-04-26 16:35:14 CDT --- Some of the latest commits seem to have fixed the issues.
The patch (see attachments) is not required anymore in Wine 1.5.29.
http://bugs.winehq.org/show_bug.cgi?id=33122
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |58dc0346d6a41663d0df8b94d29 | |8480d14419c9a Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #14 from Bruno Jesus 00cpxxx@gmail.com 2013-04-26 18:32:02 CDT --- (In reply to comment #13)
Some of the latest commits seem to have fixed the issues.
The patch (see attachments) is not required anymore in Wine 1.5.29.
Resolving fixed.
http://bugs.winehq.org/show_bug.cgi?id=33122
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #15 from Alexandre Julliard julliard@winehq.org 2013-05-10 13:41:01 CDT --- Closing bugs fixed in 1.5.30.