[Bug 24404] New: Wine git 15/09/2010 does not compile

http://bugs.winehq.org/show_bug.cgi?id=24404

Summary: Wine git 15/09/2010 does not compile
           Product: Wine
           Version: 1.3.2
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: blocker
          Priority: P2
         Component: msxml3
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

ccache gcc-4.4 -msse4 -march=native -mtune=native -O0 -Wall -m32 -c -I. -I.
-I../../include -I../../include  -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT
-fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement
-Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith
-Wno-unused-result  -g -O2  -o domdoc.o domdoc.c
domdoc.c:2524: error: conflicting types for ‘DOMDocument_create’
msxml_private.h:247: note: previous declaration of ‘DOMDocument_create’ was
here
make[1]: *** [domdoc.o] Error 1
make[1]: Leaving directory `/home/adys/src/wine/dlls/msxml3'
make: *** [install] Error 2

[Bug 24404] Wine git 15/09/2010 does not compile

http://bugs.winehq.org/show_bug.cgi?id=24404

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 24404] Wine git 15/09/2010 does not compile

http://bugs.winehq.org/show_bug.cgi?id=24404

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Jerome Leclanche  2010-09-14 18:57:09 CDT ---
CC Nikolay

[Bug 24404] Wine git 15/09/2010 does not compile

http://bugs.winehq.org/show_bug.cgi?id=24404

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source

--- Comment #2 from Austin English  2010-09-14 20:55:12 CDT ---
Works fine for me on gcc 4.6.

[Bug 24404] Wine git 15/09/2010 does not compile

http://bugs.winehq.org/show_bug.cgi?id=24404

--- Comment #3 from Andrew Nguyen  2010-09-14 21:56:40 CDT ---
(In reply to comment #2)
> Works fine for me on gcc 4.6.

Are you building without optimization (-O0), as Jerome is? The build failure
might be related to that.

[Bug 24404] msxml3 with -O0 flag does not compile

http://bugs.winehq.org/show_bug.cgi?id=24404

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Wine git 15/09/2010 does    |msxml3 with -O0 flag does
                   |not compile                 |not compile
           Severity|blocker                     |minor

[Bug 24404] msxml3 with -O0 flag does not compile

http://bugs.winehq.org/show_bug.cgi?id=24404

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|download, source            |

--- Comment #4 from Dmitry Timoshkov  2010-09-15 03:08:14 CDT ---
If this is a regression please post the results of your regression testing.

The keywords 'source' and 'download' are redundant for parts of Wine.

[Bug 24404] msxml3 with -O0 flag does not compile

http://bugs.winehq.org/show_bug.cgi?id=24404

--- Comment #5 from Jerome Leclanche  2010-09-15 09:10:08 CDT ---
Compiling with -O1, -O2 or -O3 didn't solve the issue.

Please note I'm compiling --without-xml and haven't tried compiling with.

[Bug 24404] msxml3 with -O0 flag does not compile

http://bugs.winehq.org/show_bug.cgi?id=24404

--- Comment #6 from Jerome Leclanche  2010-09-15 09:11:22 CDT ---
git revert 9c951e752060e2a79cb8b8357721b4f0a43f73dd fixes the issue.

[Bug 24404] msxml3 does not compile

http://bugs.winehq.org/show_bug.cgi?id=24404

Andrew Nguyen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|msxml3 with -O0 flag does   |msxml3 does not compile
                   |not compile                 |

--- Comment #7 from Andrew Nguyen  2010-09-15 11:22:21 CDT ---
I sent a patch:

http://source.winehq.org/patches/data/66071

I've also revised the summary to account for the true cause of the problem.

[Bug 24404] msxml3 does not compile

http://bugs.winehq.org/show_bug.cgi?id=24404

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #8 from Austin English  2010-09-15 11:45:08 CDT ---
(In reply to comment #3)
> (In reply to comment #2)
> > Works fine for me on gcc 4.6.
>
> Are you building without optimization (-O0), as Jerome is? The build failure
> might be related to that.

-g -02 (I know this is solved, but just for the record).

(In reply to comment #4)
> The keywords 'source' and 'download' are redundant for parts of Wine.

A bit, yes, but in the future, please leave the download keyword. I use that
often to know if a bug can be tested by anyone, or only people that have the
specific software in question. Wine's source can be downloaded by anyone, so
this bug should be testable by anyone.

[Bug 24404] msxml3 does not compile --without-xml

http://bugs.winehq.org/show_bug.cgi?id=24404

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|msxml3 does not compile     |msxml3 does not compile
                   |                            |--without-xml

[Bug 24404] msxml3 does not compile --without-xml

http://bugs.winehq.org/show_bug.cgi?id=24404

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #9 from Nikolay Sivov  2010-09-15 15:31:38 CDT ---
Sorry, guys, I'm kind of busy now, Andrew's patch is fine of course.

[Bug 24404] msxml3 does not compile --without-xml

http://bugs.winehq.org/show_bug.cgi?id=24404

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Austin English  2010-09-15 18:23:05 CDT ---
Fixed by
http://source.winehq.org/git/wine.git/?a=commitdiff;h=c858e583cdb4c4cecd77d9...

[Bug 24404] msxml3 does not compile --without-xml

http://bugs.winehq.org/show_bug.cgi?id=24404

--- Comment #11 from Dmitry Timoshkov  2010-09-15 22:49:41 CDT ---
(In reply to comment #8)
> > The keywords 'source' and 'download' are redundant for parts of Wine.
>
> A bit, yes, but in the future, please leave the download keyword. I use that
> often to know if a bug can be tested by anyone, or only people that have the
> specific software in question. Wine's source can be downloaded by anyone, so
> this bug should be testable by anyone.

I don't think it's good idea. Otherwise every bug in Wine bugzilla would have
the source and download keywords set. Those keywords are for applications, not
for Wine itself.

[Bug 24404] msxml3 does not compile --without-xml

http://bugs.winehq.org/show_bug.cgi?id=24404

--- Comment #12 from Austin English  2010-09-15 23:14:33 CDT ---
(In reply to comment #11)
> (In reply to comment #8)
> > > The keywords 'source' and 'download' are redundant for parts of Wine.
> >
> > A bit, yes, but in the future, please leave the download keyword. I use that
> > often to know if a bug can be tested by anyone, or only people that have the
> > specific software in question. Wine's source can be downloaded by anyone, so
> > this bug should be testable by anyone.
>
> I don't think it's good idea. Otherwise every bug in Wine bugzilla would have
> the source and download keywords set. Those keywords are for applications, not
> for Wine itself.

The problem was exposed by wine itself, not an application.

[Bug 24404] msxml3 does not compile --without-xml

http://bugs.winehq.org/show_bug.cgi?id=24404

--- Comment #13 from Dmitry Timoshkov  2010-09-15 23:21:20 CDT ---
(In reply to comment #12)
> The problem was exposed by wine itself, not an application.

Right, like every bug in the Wine bugzilla.

[Bug 24404] msxml3 does not compile --without-xml

http://bugs.winehq.org/show_bug.cgi?id=24404

--- Comment #14 from Austin English  2010-09-15 23:38:46 CDT ---
(In reply to comment #13)
> (In reply to comment #12)
> > The problem was exposed by wine itself, not an application.
>
> Right, like every bug in the Wine bugzilla.

Not quite. Most are exposed by testing a specific application, e.g., Firefox
(which can be downloaded) or Microsoft Office (cannot be downloaded). Bugs in
firefox can be tested by anyone, bugs in Microsoft Office cannot. This bug
could be tested by anyone with the ability to compile wine using --without-xml.

I depend heavily on the download keyword, for old bugs that either I can test
myself rather than ask the reporter, or to see if a bug must be closed
abandoned because the reporter isn't responding and I/no one else can test.

Perhaps we should take this to wine-devel or discuss it at wineconf...

[Bug 24404] msxml3 does not compile --without-xml

http://bugs.winehq.org/show_bug.cgi?id=24404

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #15 from Alexandre Julliard  2010-09-18 13:04:44 CDT ---
Closing bugs fixed in 1.3.3.

[Bug 24404] msxml3 does not compile --without-xml

http://bugs.winehq.org/show_bug.cgi?id=24404

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |c858e583cdb4c4cecd77d938958
                   |                            |91a4028a2b48d
    Regression SHA1|                            |9c951e752060e2a79cb8b835772
                   |                            |1b4f0a43f73dd
           Severity|minor                       |blocker