[Bug 40277] New: Half-Life - Team Fortress Classic: Intro video renders with artifacts (RLE decompressed using gdi32 differs from msrle32)

https://bugs.winehq.org/show_bug.cgi?id=40277

Bug ID: 40277
           Summary: Half-Life - Team Fortress Classic: Intro video renders
                    with artifacts (RLE decompressed using gdi32 differs
                    from msrle32)
           Product: Wine
           Version: 1.9.5
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
      Distribution: ---

This bug describes a third problem from bug 22533. The game has an intro video
compressed in RLE but the biCompression is not set to "mrle", it is "RLE " so
comctl32 skips trying to find a codec and uses built-in capabilities of gdi32
to decompress the frames.

Unfortunately the gdi32 decompressed frames have artifacts in the shape of
lines as if the RLE is not being decompressed correctly. A workaround is to
force comctl32 to use msrle32, but I think there could be a problem in gdi32.

This bug is a mental note to myself and I'll try to handcraft a frame that
displays the issue and add to tests when I have more time.

[Bug 40277] Half-Life - Team Fortress Classic: Logo video renders with artifacts (RLE decompressed using gdi32 differs from msrle32)

https://bugs.winehq.org/show_bug.cgi?id=40277

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Half-Life - Team Fortress   |Half-Life - Team Fortress
                   |Classic: Intro video        |Classic: Logo video renders
                   |renders with artifacts (RLE |with artifacts (RLE
                   |decompressed using gdi32    |decompressed using gdi32
                   |differs from msrle32)       |differs from msrle32)

[Bug 40277] Half-Life - Team Fortress Classic: Logo video renders with artifacts (RLE decompressed using gdi32 differs from msrle32)

https://bugs.winehq.org/show_bug.cgi?id=40277

Johan Gardhage  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 40277] Half-Life - Team Fortress Classic: Logo video renders with artifacts (RLE decompressed using gdi32 differs from msrle32)

https://bugs.winehq.org/show_bug.cgi?id=40277

Jouni Järvinen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Jouni Järvinen  ---
(In reply to Bruno Jesus from comment #0)
> [...] the biCompression is not set to "mrle", it is
> "RLE " [...]

"RLE " or "RLE" ?

[Bug 40277] Half-Life - Team Fortress Classic: Logo video renders with artifacts (RLE decompressed using gdi32 differs from msrle32)

https://bugs.winehq.org/show_bug.cgi?id=40277

--- Comment #2 from Bruno Jesus  ---
(In reply to Jouni Järvinen from comment #1)
> "RLE " or "RLE" ?

The fourcc is always 4 bytes, so it is really "RLE " (blank space).

[Bug 40277] Half-Life - Team Fortress Classic: Logo video renders with artifacts (RLE decompressed using gdi32 differs from msrle32)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=40277

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from joaopa  ---
Does the bug still occur with wine-6.4?

[Bug 40277] Half-Life - Team Fortress Classic: Logo video renders with artifacts (RLE decompressed using gdi32 differs from msrle32)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=40277

--- Comment #4 from Xylemon  ---
Created attachment 71831
  --> https://bugs.winehq.org/attachment.cgi?id=71831
Screenshot of the bug

This bug is still occurring on my WINE 7.0 and 7.1 machines. I've attached how
Team Fortress 1.5 looks with WINE 7.0 (notice all the odd lines), it also looks
the same on 7.1

Also since it wasn't mentioned on here, I wanted to reiterate some of my other
comments to help avoid potential confusion:

This bug is about the CD Version of Half-Life/TFC that has a Windows MFC based
menu that loads the game engine, which is different from the Steam version as
the entire menu is always rendered in-game. The CD menu loads an animated AVI
for the "logo" of the game (which is what's corrupting here), where as Steam HL
does not.

[Bug 40277] Half-Life - Team Fortress Classic: Logo video renders with artifacts (RLE decompressed using gdi32 differs from msrle32)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=40277

--- Comment #5 from Xylemon  ---
Created attachment 71832
  --> https://bugs.winehq.org/attachment.cgi?id=71832
How the menu should look

Here is a mockup to show how the menu should look, which is just a (poorly
dithered) screencap of the AVI superimposed over my screenshot.