http://bugs.winehq.org/show_bug.cgi?id=10716
Summary: Spurious hyperlink rendering in Blitzin 2.34 Product: Wine Version: CVS/GIT Platform: Other OS/Version: other Status: UNCONFIRMED Severity: normal Priority: P2 Component: wine-richedit AssignedTo: wine-bugs@winehq.org ReportedBy: Andrew.Talbot@talbotville.com
Patch git-commit f945f16de201dbd834da10701025665bfa8f05ee "riched20: WM_GETTEXTLENGTH should include CRLF conversions in returned count." causes a regression whereby some text is wrongly rendered to look like hypertext links. This will typically occur at the start or the end of a line, but not exclusively.
http://bugs.winehq.org/show_bug.cgi?id=10716
Alex Villacís Lasso a_villacis@palosanto.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |a_villacis@palosanto.com
http://bugs.winehq.org/show_bug.cgi?id=10716
Lei Zhang thestig@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://www.chessclub.com/hel | |pcenter/interface/blitzin_do | |wnload.php Keywords| |download
http://bugs.winehq.org/show_bug.cgi?id=10716
Lei Zhang thestig@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
http://bugs.winehq.org/show_bug.cgi?id=10716
--- Comment #1 from Alex Villacís Lasso a_villacis@palosanto.com 2007-12-10 13:58:54 --- Where in the game does the problem appear? Is a valid login really required in order to exercise the bug? A screenshot would be nice.
Are you really sure the game was working OK before the patch? Bug #8132 which seems related, predates the patch, and in fact this bug might be a duplicate of it.
http://bugs.winehq.org/show_bug.cgi?id=10716
--- Comment #2 from Andrew Talbot Andrew.Talbot@talbotville.com 2007-12-10 16:32:31 --- Created an attachment (id=9591) --> (http://bugs.winehq.org/attachment.cgi?id=9591) Spurious hyperlink rendering in Main Console
http://bugs.winehq.org/show_bug.cgi?id=10716
--- Comment #3 from Andrew Talbot Andrew.Talbot@talbotville.com 2007-12-10 16:49:54 --- Blitzin is an interface to an online chess club (www.chessclub.com). To log in as a non-member, choose "New Connection" from the "File" menu and click on the "Connect as guest" button. You will be given a guest login id, such as "Guest1234".
The main console window displays, amongst other things, information from the server and broadcasted "shouts" from the members and administrators. The peculiar rendering in this window should soon become apparent; a screenshot is attached.
The program was not displaying this intermittent hypertext-style rendering prior to this patch.
I drew attention to bug #8132, in this context, because both bugs involve hypertext styling being applied at the wrong time, so I wondered if they might share some common code. I shall attach details and a screenshot to the report for that bug, too.
http://bugs.winehq.org/show_bug.cgi?id=10716
--- Comment #4 from Alex Villacís Lasso a_villacis@palosanto.com 2007-12-10 17:08:25 --- Created an attachment (id=9593) --> (http://bugs.winehq.org/attachment.cgi?id=9593) ...unable to reproduce, need more info.
I am running current git and I am unable to reproduce the screen corruption. Screenshot attached.
What operations did you do to put riched20 into this state? Does the program enter this state immediately, or do you have to do something more (resize, wait for many messages, minimize then maximize, etc)?
Even if I manage to reproduce the error, it is unlikely that my patch caused this particular bug. The patch concerns the length reporting on WM_GETTEXTLENGTH, and therefore fixes a message behavior problem. Your screenshot shows the URL formatting shifted several characters past the actual hyperlink text, and is therefore a rendering problem.
BTW, I am running Fedora 7 with latest updates under GNOME. Screen resolution is 1400x1050.
http://bugs.winehq.org/show_bug.cgi?id=10716
--- Comment #5 from Alex Villacís Lasso a_villacis@palosanto.com 2007-12-10 17:13:41 --- Now that I see the screenshots more closely, it seems that we do not share the same version of BlitzIn. Could you please post the version that experiences problems? Could you please check whether you can reproduce the bug with the latest version? (2.52)
http://bugs.winehq.org/show_bug.cgi?id=10716
--- Comment #6 from Alex Villacís Lasso a_villacis@palosanto.com 2007-12-10 17:22:23 --- On current git, BlitzIn 2.34 cannot even be installed:
err:ole:CoGetClassObject no class object {91814ec0-b5f0-11d2-80b9-00104b1f6cea} could be created for context 0x4
On dialog box: [The InstallShield Engine (iKernel.exe) could not be launched. (0x80004002)]
http://bugs.winehq.org/show_bug.cgi?id=10716
--- Comment #7 from Lei Zhang thestig@google.com 2007-12-10 21:03:13 --- Perhaps you need to set Wine to win9x? From the website:
BlitzIn 2.6 does not support Windows95. For Windows95 users we recommend that you download BlitzIn 2.3x instead.
http://bugs.winehq.org/show_bug.cgi?id=10716
Alex Villacís Lasso a_villacis@palosanto.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #8 from Alex Villacís Lasso a_villacis@palosanto.com 2007-12-11 11:26:34 --- Confirmed. Installer worked with OS version set to Windows 95 (BTW, this should be a separate bug report), but program itself exhibits flaw even with default Win2k.
http://bugs.winehq.org/show_bug.cgi?id=10716
Alex Villacís Lasso a_villacis@palosanto.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|wine-bugs@winehq.org |a_villacis@palosanto.com Status|NEW |ASSIGNED
--- Comment #9 from Alex Villacís Lasso a_villacis@palosanto.com 2007-12-11 15:04:16 --- Created an attachment (id=9603) --> (http://bugs.winehq.org/attachment.cgi?id=9603) FIX for regression in 1.0 emulation on WM_GETTEXTLENGTH
Commit f945f16de201dbd834da10701025665bfa8f05ee introduced a regression in richedit 1.0 emulation, in which WM_GETTEXTLENGTH reports a length that is too long. Due to the way the text is represented in memory, the previous behavior (not counting CR->CRLF conversions) was actually correct for a richedit 1.0 control, because the offset markers at the start of each paragraph already include previous CRLF lengths. The attached patch fixes it by using the GTL_USECRLF only for richedit 2.0. Also included is a test for the behavior in riched32 so this does not happen again.
Patch already sent to wine-patches.
http://bugs.winehq.org/show_bug.cgi?id=10716
--- Comment #10 from Alex Villacís Lasso a_villacis@palosanto.com 2007-12-12 10:08:55 --- Patch has now been committed to current git. Please pull and test to verify bug has indeed been solved.
http://bugs.winehq.org/show_bug.cgi?id=10716
Andrew Talbot Andrew.Talbot@talbotville.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED
--- Comment #11 from Andrew Talbot Andrew.Talbot@talbotville.com 2007-12-12 15:34:25 --- The supplied fix has eliminated this bug. Thanks, Alex. Well done!
http://bugs.winehq.org/show_bug.cgi?id=10716
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #12 from Dan Kegel dank@kegel.com 2008-01-28 05:43:02 --- Closing all RESOLVED FIXED bugs older than four weeks.
http://bugs.winehq.org/show_bug.cgi?id=10716
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|CVS/GIT |unspecified
https://bugs.winehq.org/show_bug.cgi?id=10716
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- OS|other |Linux Fixed by SHA1| |ae7b2c914b813ad818c6a90b65d | |c6ce81cda3832 Version|unspecified |0.9.51. CC| |focht@gmx.net Regression SHA1| |f945f16de201dbd834da1070102 | |5665bfa8f05ee Hardware|Other |x86 URL|http://www.chessclub.com/he |https://web.archive.org/web |lpcenter/interface/blitzin_ |/20051210060012/http://www. |download.php |chessclub.com/bits/interfac | |e/blitzin234.exe
--- Comment #13 from Anastasius Focht focht@gmx.net --- Hello folks,
adding stable download link via Internet Archive for documentation. Also fixing some fields as needed.
https://web.archive.org/web/20051210060012/http://www.chessclub.com/bits/int...
https://www.virustotal.com/gui/file/fd8b7e02138b8634f7e43be20eb390c3f0ac8824...
$ sha1sum blitzin234.exe 99d324f38272a1c59ceec0d4e858256925f03835 blitzin234.exe
$ du -sh blitzin234.exe 1.9M blitzin234.exe
Regards