https://bugs.winehq.org/show_bug.cgi?id=55236
Bug ID: 55236 Summary: scrrun:dictionary - test_hash_value() gets bad hashes on Windows Product: Wine Version: unspecified Hardware: x86-64 OS: Windows Status: NEW Severity: normal Priority: P2 Component: scrrun Assignee: wine-bugs@winehq.org Reporter: fgouget@codeweavers.com
scrrun:dictionary - test_hash_value() gets bad hashes on Windows:
dictionary.c:676: Test failed: got hash 0x2eb, expected 0x2ea dictionary.c:686: Test failed: got hash 0x2eb, expected 0x2ea dictionary.c:695: Test failed: got hash 0x2db, expected 0x2da dictionary.c:721: Test failed: got hash 0x2eb, expected 0x2ea dictionary.c:732: Test failed: got hash 0x2eb, expected 0x2ea dictionary.c:742: Test failed: got hash 0x2db, expected 0x2da
See https://test.winehq.org/data/patterns.html#scrrun:dictionary
Note that the hash values change with every run causing false positives.
https://bugs.winehq.org/show_bug.cgi?id=55236
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |source, testcase
https://bugs.winehq.org/show_bug.cgi?id=55236
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|scrrun:dictionary - |scrrun:dictionary - The |test_hash_value() gets bad |64-bit test_hash_value() |hashes on Windows |gets bad hashes on Windows
--- Comment #1 from François Gouget fgouget@codeweavers.com --- The failures are specific to the 64-bit tests and have been systematic since 2023-07-10. 2023-07-10 is when the GitLab CI switched to Debian 12 to build the official WineTest binaries used by the TestBot to run the tests on Windows.
Note that the TestBot still uses Debian 11 to build the test binaries so these failures will not happen when submitting patches to the TestBot.
https://bugs.winehq.org/show_bug.cgi?id=55236
--- Comment #2 from François Gouget fgouget@codeweavers.com --- w10pro64_hi_u8 can get an additional slightly different hash error that only happens there:
dictionary.c:676: Test failed: got hash 0x4a1, expected 0x31c dictionary.c:686: Test failed: got hash 0x4a1, expected 0x31c dictionary.c:695: Test failed: got hash 0, expected 0x30c dictionary.c:721: Test failed: got hash 0x4a1, expected 0x31c dictionary.c:732: Test failed: got hash 0x4a1, expected 0x31c dictionary.c:742: Test failed: got hash 0, expected 0x30c
https://bugs.winehq.org/show_bug.cgi?id=55236
--- Comment #3 from Nikolay Sivov bunglehead@gmail.com --- These are hashes on pointer types, so could fluctuate from run to run. I'm curious, how switching mingw-w64 version (I'm assuming that's what happened), could possibly affect this.
https://bugs.winehq.org/show_bug.cgi?id=55236
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Fixed by SHA1| |f69bb9d6c5e731d69b61bb715f3 | |de5c3cd47f68c Resolution|--- |FIXED
--- Comment #4 from François Gouget fgouget@codeweavers.com --- This last happened on 2023-08-31 and was fixed by the commit below:
commit f69bb9d6c5e731d69b61bb715f3de5c3cd47f68c Author: Alexandre Julliard julliard@winehq.org AuthorDate: Fri Sep 1 17:24:06 2023 +0200
scrrun: Fix pointer hashing on 64-bit.
https://bugs.winehq.org/show_bug.cgi?id=55236
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #5 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 8.18.
-
WineHQ Bugzilla