[Bug 33593] New: joystick.c change causes lotro to crash

http://bugs.winehq.org/show_bug.cgi?id=33593

Bug #: 33593
           Summary: joystick.c change causes lotro to crash
           Product: Wine
           Version: 1.5.29
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P3
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

dinput problem (not available as a component).

Before the first screen is displayed, lotro (Lord of the Rings Online) crashes
(process becomes <defunct>). This is due to the joystick code thinking that
a Wacom Cintiq 12WX is a joystick.

Git bisect shows the change that causes the crash is in:
37169522f62f85048900cf3329fb54800cbb8f3e
dinput: Update existing joystick values after setting the range property.

Last entries from a dinput trace:
trace:dinput:JoystickWGenericImpl_SetProperty (0x15fd00,<guid-0x0004>,0x32f794)
trace:dinput:_dump_DIPROPHEADER   - dwObj = 0x00000000
trace:dinput:_dump_DIPROPHEADER   - dwHow = DIPH_DEVICE
trace:dinput:JoystickWGenericImpl_SetProperty proprange(-64,64) all

A workaround is to create the key: HKCU/Software/Wine/DirectInput/Joysticks
and enter a new string value for "Wacom Cintiq 12WX (event)" of "disabled".

In any event, the program shouldn't crash.

[Bug 33593] joystick.c change causes lotro to crash

http://bugs.winehq.org/show_bug.cgi?id=33593

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
          Component|-unknown                    |directx-dinput
    Regression SHA1|                            |37169522f62f85048900cf3329f
                   |                            |b54800cbb8f3e

[Bug 33593] joystick.c change causes lotro to crash if Wacom Cintiq attached

http://bugs.winehq.org/show_bug.cgi?id=33593

Don Koch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|joystick.c change causes    |joystick.c change causes
                   |lotro to crash              |lotro to crash if Wacom
                   |                            |Cintiq attached

[Bug 33593] joystick.c change causes lotro to crash if Wacom Cintiq attached

http://bugs.winehq.org/show_bug.cgi?id=33593

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from [e-mail] 2013-05-31 17:56:05 CDT ---
A new patch has been issued (96601) which removes the offending code generated
by the previous patch (95617) - hopefully this will be committed to the next
version of Wine, and the issue resolved

[Bug 33593] joystick.c change causes lotro to crash if Wacom Cintiq attached

http://bugs.winehq.org/show_bug.cgi?id=33593

Gurmail Bassi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Gurmail Bassi  2013-06-04 15:56:36 CDT ---
In an update to the above - the original (bad) code from patch 95617 has not
been removed as yet, but a new working patch (96675) has just been submitted
which should hopefully be committed soon and resolve the issue for all users.

The cause of the error was that Wine was referencing a variable in (dinput:
joystick.c) SetProperty which doesn't get allocated until SetDataFormat is
called (and as LOTRO does this afterwards, the call would fail).

[Bug 33593] joystick.c change causes lotro to crash if Wacom Cintiq attached

http://bugs.winehq.org/show_bug.cgi?id=33593

--- Comment #3 from Bruno Jesus  2013-06-05 14:36:08 CDT ---
Patch commited:
http://source.winehq.org/git/wine.git/?a=commit;h=c34b7b13134e2479d3e25e8f89...

If this patch fixes this bug and also bug 33496 this bug will be marked as
duplicate since both have the same regression results.

[Bug 33593] joystick.c change causes lotro to crash if Wacom Cintiq attached

http://bugs.winehq.org/show_bug.cgi?id=33593

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Frédéric Delanoy  2013-06-30 12:38:25 CDT ---
Is this still an issue in recent wine (1.6-rc4 or later)?

[Bug 33593] joystick.c change causes lotro to crash if Wacom Cintiq attached

http://bugs.winehq.org/show_bug.cgi?id=33593

Don Koch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Don Koch  2013-07-02 20:45:06 CDT ---
The problem appears to be fixed by 1.6-rc4.

You may close this.

Thanks!

[Bug 33593] joystick.c change causes lotro to crash if Wacom Cintiq attached

http://bugs.winehq.org/show_bug.cgi?id=33593

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  2013-07-12 13:47:15 CDT ---
Closing bugs fixed in 1.6-rc5.

[Bug 33593] joystick.c change causes lotro to crash if Wacom Cintiq attached

https://bugs.winehq.org/show_bug.cgi?id=33593

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |c34b7b13134e2479d3e25e8f899
                   |                            |5ff5a8abd2983
                 CC|                            |[e-mail]