http://bugs.winehq.org/show_bug.cgi?id=34472
Bug #: 34472 Summary: window titlebar names Product: Wine Version: 1.7.1 Platform: x86-64 OS/Version: Mac OS X Status: UNCONFIRMED Severity: trivial Priority: P2 Component: winemac.drv AssignedTo: wine-bugs@winehq.org ReportedBy: f.platte@platte-web.de Classification: Unclassified
Created attachment 45899 --> http://bugs.winehq.org/attachment.cgi?id=45899 Example image of the issue.
When ever I use the MacDriver while entering fullscreen the windows titlebar does not show the application/executable/file name anymore once I exit fullscreen. This happened to me for any fullscreen application I'm currently using. (AudioSurf, TrackMania United/Nations forever, Colin McRae Rally 2005, Beyond Good & Evil [GOG], etc…) This happened to me ever since the introduction of the MacDriver. (1.5.?)
http://bugs.winehq.org/show_bug.cgi?id=34472
Ken Thomases ken@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |ken@codeweavers.com Ever Confirmed|0 |1
--- Comment #1 from Ken Thomases ken@codeweavers.com 2013-09-08 14:10:14 CDT --- Yeah, confirming. Cocoa seems to forget the window title when the window style is changed to no longer show a title bar. Then, when the style is changed back, it no longer has a title. The Mac driver will have to save the title separately and restore it.
http://bugs.winehq.org/show_bug.cgi?id=34472
--- Comment #2 from sevae sevae@roadrunner.com 2013-10-13 03:46:39 CDT --- Created attachment 46282 --> http://bugs.winehq.org/attachment.cgi?id=46282 Restore the window title.
http://bugs.winehq.org/show_bug.cgi?id=34472
--- Comment #3 from Ken Thomases ken@codeweavers.com 2013-10-14 19:12:05 CDT --- Curious. I didn't expect it to be solvable so "locally". I assumed that a window without a title bar simply couldn't have a title, so we would have to save it in an instance variable until the style changed back to titled. Seems to work fine, though.
A few suggestions:
* The patch doesn't apply to current git. The indenting is different. (Perhaps you've re-indented your working copy because you hate the extra indenting that's in Wine?)
* I think it's best to copy the original title. Your approach seems to be working but, given that Cocoa is losing the window's title, it may release the string it gave us. Of course, if we copy it, we need to release it. I suggest just [[... copy] autorelease] around what you've got.
* Submit it to wine-patches, since patches won't be picked up from the bug tracker.
If you're not interested in pursuing it, let me know and I can tweak and submit it. Thanks.
http://bugs.winehq.org/show_bug.cgi?id=34472
Ken Thomases ken@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |771fcd894a62f53cb3862a9d97f | |28d2ce7c46a30 Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #4 from Ken Thomases ken@codeweavers.com 2013-10-17 14:17:54 CDT --- Fixed by http://source.winehq.org/git/wine.git/?a=commit;h=771fcd894a62f53cb3862a9d97...
http://bugs.winehq.org/show_bug.cgi?id=34472
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #5 from Alexandre Julliard julliard@winehq.org 2013-10-25 12:54:12 CDT --- Closing bugs fixed in 1.7.5.
https://bugs.winehq.org/show_bug.cgi?id=34472
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.6.x
https://bugs.winehq.org/show_bug.cgi?id=34472
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.6.x |---
--- Comment #6 from Alexandre Julliard julliard@winehq.org --- Removing 1.6.x milestone from bugs included in 1.6.2.