[Bug 30294] New: Crash in notepad when loading big text file

http://bugs.winehq.org/show_bug.cgi?id=30294

Bug #: 30294
           Summary: Crash in notepad when loading big text file
           Product: Wine
           Version: 1.5.0
          Platform: x86-64
        OS/Version: Linux
            Status: NEW
          Keywords: download, source
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 39590
  --> http://bugs.winehq.org/attachment.cgi?id=39590
crash backtrace in wine-1.5.0-204-ga179b50

Download attachment 28858 [details] from bug 23193 and uncompress it. Open it
in 'wine notepad'.

Full log:
wine: Unhandled page fault on write access to 0x00000018 at address 0x7e6fc4f8
(thread 0024), starting debugger...
wine client error:24: read: Bad address

[Bug 30294] Crash in notepad when loading big text file

http://bugs.winehq.org/show_bug.cgi?id=30294

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |23193

[Bug 30294] Crash in notepad when loading big text file

http://bugs.winehq.org/show_bug.cgi?id=30294

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |23195

[Bug 30294] Crash in notepad when loading big text file

http://bugs.winehq.org/show_bug.cgi?id=30294

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
                 CC|                            |[e-mail]
          Component|-unknown                    |user32
    Regression SHA1|                            |3b5e14a9b0a925052e2b1b71f76
                   |                            |a7f1eff6d84bf

--- Comment #1 from Austin English  2012-03-29 13:50:37 CDT ---
austin@aw25 ~/wine-rt $ git bisect bad
3b5e14a9b0a925052e2b1b71f76a7f1eff6d84bf is the first bad commit
commit 3b5e14a9b0a925052e2b1b71f76a7f1eff6d84bf
Author: Aric Stewart 
Date:   Fri Oct 21 11:29:05 2011 -0500

user32: Use Uniscribe in the multiline edit control.

:040000 040000 3cade3e51f7827bcb33e2ffb29d813b1b281eee3
36d7773ef67ae9d2a462fc856024bebed3a15aaa M    dlls

[Bug 30294] Crash in notepad when loading big text file

http://bugs.winehq.org/show_bug.cgi?id=30294

--- Comment #2 from Aric Stewart  2012-03-30 09:57:13 CDT ---
(In reply to comment #1)
> austin@aw25 ~/wine-rt $ git bisect bad
> 3b5e14a9b0a925052e2b1b71f76a7f1eff6d84bf is the first bad commit
> commit 3b5e14a9b0a925052e2b1b71f76a7f1eff6d84bf
> Author: Aric Stewart 
> Date:   Fri Oct 21 11:29:05 2011 -0500
> user32: Use Uniscribe in the multiline edit control.
>
> :040000 040000 3cade3e51f7827bcb33e2ffb29d813b1b281eee3
> 36d7773ef67ae9d2a462fc856024bebed3a15aaa M    dlls

Not too surprisingly.  The failure involves E_OUTOFMEMORY.

The edit control is presently loading every line in the control and we are
running out of memory (not to mention being slow) on really huge files.

It will take a bit of work to redesign it to properly only work with lines that
are visible on the screen.

I am presuming that this is not a new problem with the above commit it is just
that using uniscribe results in more memory allocated per line so we are
running out of memory sooner than we would before. Thus this bug manifests on
shorter files.

[Bug 30294] Crash in notepad when loading big text file

http://bugs.winehq.org/show_bug.cgi?id=30294

--- Comment #3 from Alexandre Julliard  2012-03-30 10:11:28 CDT ---
This file has 30,000 lines, it shouldn't be a problem to store it all in
memory. There's definitely something wrong here.

[Bug 30294] Crash in notepad when loading big text file

http://bugs.winehq.org/show_bug.cgi?id=30294

--- Comment #4 from Aric Stewart  2012-03-30 10:14:27 CDT ---
(In reply to comment #3)
> This file has 30,000 lines, it shouldn't be a problem to store it all in
> memory. There's definitely something wrong here.

Yup, noticing that myself. We are definitely running out of memory. Uniscribe
can be a memory hog especially with all the caching it does.  I am working on
how to improve things.

[Bug 30294] Crash in notepad when loading big text file

http://bugs.winehq.org/show_bug.cgi?id=30294

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Frédéric Delanoy  2012-05-04 13:05:52 CDT ---
Works in wine-1.5.3-143-g081b06c

[Bug 30294] Crash in notepad when loading big text file

http://bugs.winehq.org/show_bug.cgi?id=30294

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  2012-05-11 13:21:57 CDT ---
Closing bugs fixed in 1.5.4.