[Bug 16511] New: Google Sketchup rejects some ruby scripts containing CRLF

http://bugs.winehq.org/show_bug.cgi?id=16511

Summary: Google Sketchup rejects some ruby scripts containing
                    CRLF
           Product: Wine
           Version: 1.1.10
          Platform: Other
               URL: http://sketchup.google.com
        OS/Version: other
            Status: NEW
          Keywords: download
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Oddly, under Wine, the example ruby scripts from 
http://sketchup.google.com/download/rubyscripts.html
are rejected by Sketchup unless you remove the CRs,
i.e. run them through dos2unix.

The one-liner "puts 'hello'" program is ok, though.  The smallest
script I've created that exibits the problem is a hello, world
app that starts with a ten line comment.  This script does not cause
the error when run in Sketchup on MS Windows.

I'll attach the script.

[Bug 16511] Google Sketchup rejects some ruby scripts containing CRLF

http://bugs.winehq.org/show_bug.cgi?id=16511

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |msvcrt

--- Comment #1 from Dan Kegel   2008-12-15 08:34:44 ---
Native msvcrt works around this
(winetricks vcrun6, then add override for msvcrt in winecfg)
so changing category.

[Bug 16511] Google Sketchup rejects some ruby scripts containing CRLF

http://bugs.winehq.org/show_bug.cgi?id=16511

--- Comment #2 from Dan Kegel   2008-12-15 11:13:01 ---
Created an attachment (id=17965)
 --> (http://bugs.winehq.org/attachment.cgi?id=17965)
Patch that seems to fix the problem

In ascii mode, if we decide we need one more byte, 
it looks like sometimes we grab it from the
file instead of the buffer!  The attached patch
fixes this by continuing to use buffered data longer.

[Bug 16511] Google Sketchup rejects some ruby scripts containing CRLF

http://bugs.winehq.org/show_bug.cgi?id=16511

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #3 from Dan Kegel   2008-12-15 11:13:27 ---
I'll submit the patch once I have a conformance test.

[Bug 16511] Google Sketchup rejects some ruby scripts containing CRLF

http://bugs.winehq.org/show_bug.cgi?id=16511

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Austin English   2008-12-16 09:08:46 ---
Patch was committed.

[Bug 16511] Google Sketchup rejects some ruby scripts containing CRLF

http://bugs.winehq.org/show_bug.cgi?id=16511

--- Comment #5 from Dan Kegel   2008-12-16 09:59:29 ---
And it even works, too.  Bonus :-)

[Bug 16511] Google Sketchup rejects some ruby scripts containing CRLF

http://bugs.winehq.org/show_bug.cgi?id=16511

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard   2008-12-20 09:06:46 ---
Closing bugs fixed in 1.1.11.

[Bug 16511] Google Sketchup 7 rejects some ruby scripts containing CRLF

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=16511

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|Google Sketchup rejects     |Google Sketchup 7 rejects
                   |some ruby scripts           |some ruby scripts
                   |containing CRLF             |containing CRLF
                 OS|other                       |Linux
                URL|http://sketchup.google.com  |https://web.archive.org/web
                   |                            |/20120726023942/http://dl.g
                   |                            |oogle.com/sketchup/gsu7/PW-
                   |                            |2-1-6860-EN.exe
      Fixed by SHA1|                            |72ffe1da676b673f6caa84f1859
                   |                            |a601f6935dd99
           Hardware|Other                       |x86