[Bug 43515] New: World of Warships 0.6.9 crashes with Critical Error Occurred

https://bugs.winehq.org/show_bug.cgi?id=43515

Bug ID: 43515
           Summary: World of Warships 0.6.9 crashes with Critical Error
                    Occurred
           Product: Wine
           Version: 2.14
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: critical
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 58905
  --> https://bugs.winehq.org/attachment.cgi?id=58905
Error dialog

World of Warships (WoWs) 0.6.9 crashes with Critical Error Occurred.
This seems to be same error as #4314 but the workaround (changing Windows
version on winecfg) doesn't effect.

Wargaming releases update of MacWrapper (wine Wargaming's custom for MacOS) to
fix this problem:
https://na.wargaming.net/support/kb/articles/813

Steps to reproduce:
1) Choose Application menu > wine > Programs > World of Warships > World of
Warships (Launched WoWSLauncher.exe)
2) Click "Play" (Launched worldofwarships)
3) Click "Connect!"

Repeatability:
Always

Version:
wine 2.14
wine-mono 4.7.1
wine-gecko 2.47

on ArchLinux(x86_64)

WINEARCH=win32
Windows version on winecfg: Windows10, 7 and XP I confirmed

Thx

[Bug 43515] World of Warships 0.6.9 crashes with Critical Error Occurred

https://bugs.winehq.org/show_bug.cgi?id=43515

--- Comment #1 from Mario Motohashi  ---
Created attachment 58906
  --> https://bugs.winehq.org/attachment.cgi?id=58906
Console messages

Console messages until crash.

[Bug 43515] World of Warships 0.6.9 crashes with Critical Error Occurred

https://bugs.winehq.org/show_bug.cgi?id=43515

--- Comment #2 from Mario Motohashi  ---
> his seems to be same error as #4314

Sorry, not #4314, #43164
https://bugs.winehq.org/show_bug.cgi?id=43164

[Bug 43515] World of Warships 0.6.9 crashes on startup ('ProgramData' environment variable not set)

https://bugs.winehq.org/show_bug.cgi?id=43515

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|World of Warships 0.6.9     |World of Warships 0.6.9
                   |crashes with Critical Error |crashes on startup
                   |Occurred                    |('ProgramData' environment
                   |                            |variable not set)
           Keywords|                            |download
         Resolution|---                         |DUPLICATE
                URL|                            |http://dl-wows-gc.wargaming
                   |                            |.net/eu/files/ilcClx1YzB/Wo
                   |                            |WS_internet_install_eu.exe
                 CC|                            |[e-mail]
           Severity|critical                    |normal
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #3 from Anastasius Focht  ---
Hello folks,

confirming. Since I'm addicted to this game, highest priority for investigation
;-)

The problem has nothing to do with bug 43164 (which is not reproducible at all,
seems to be user-specific, broken host drivers).

Also the bug is not 'critical', see https://wiki.winehq.org/Bugs
An app/game crashing is considered 'normal', only when *all* apps are crashing
this severity can be applied.

Anyway, doing a full relay trace to the crash was kinda tedious, even skipping
the launcher process and filtering out specific API classes.
It produces well over 30 GiB logs up to the crash point, hence I quickly
debugged the game itself.

Relevant part of game code:

--- snip ---
...
00D81DD0   PUSH EBP
00D81DD1   MOV EBP,ESP
00D81DD3   PUSH -1
00D81DD5   PUSH WorldOfW.010A6785
00D81DDA   MOV EAX,DWORD PTR FS:[0]
00D81DE0   PUSH EAX
00D81DE1   SUB ESP,80
00D81DE7   MOV EAX,DWORD PTR DS:[173A350]
00D81DEC   XOR EAX,EBP
00D81DEE   MOV DWORD PTR SS:[EBP-10],EAX
00D81DF1   PUSH EBX
00D81DF2   PUSH ESI
00D81DF3   PUSH EDI
00D81DF4   PUSH EAX
00D81DF5   LEA EAX,DWORD PTR SS:[EBP-C]
00D81DF8   MOV DWORD PTR FS:[0],EAX
00D81DFE   MOV EDI,ECX
00D81E00   MOV DWORD PTR SS:[EBP-88],EDI
00D81E06   PUSH 29
00D81E08   PUSH WorldOfW.01483D64  ; ASCII
"\Wargaming.net\GameCenter\data\wgc_id.dat"
00D81E0D   LEA ECX,DWORD PTR SS:[EBP-84]
00D81E13   MOV DWORD PTR SS:[EBP-8C],0
00D81E1D   MOV DWORD PTR SS:[EBP-70],0F
00D81E24   MOV DWORD PTR SS:[EBP-74],0
00D81E2B   MOV BYTE PTR SS:[EBP-84],0
00D81E32   CALL WorldOfW.004F5400
00D81E37   PUSH WorldOfW.01483D90  ; ASCII "ProgramData"
00D81E3C   MOV DWORD PTR SS:[EBP-4],0
00D81E43   CALL DWORD PTR DS:[<&api-ms-win-crt-environment-l1-1-0.getenv>]
00D81E49   MOV EDX,EAX
00D81E4B   MOV DWORD PTR SS:[EBP-58],0F
00D81E52   ADD ESP,4
00D81E55   MOV DWORD PTR SS:[EBP-5C],0
00D81E5C   MOV BYTE PTR SS:[EBP-6C],0
00D81E60   CMP BYTE PTR DS:[EDX],0  ; *boom*
...
---- snip ---

That's bug 43423 -> 'ProgramData' environment variable not set.

https://msdn.microsoft.com/de-de/library/ff716245.aspx

Can be easily worked around by exporting it by default/in the WINEPREFIX.

Resolving as dupe of 43423 here.

Regards

*** This bug has been marked as a duplicate of bug 43423 ***

[Bug 43515] World of Warships 0.6.9 crashes on startup ('ProgramData' environment variable not set)

https://bugs.winehq.org/show_bug.cgi?id=43515

--- Comment #4 from Mario Motohashi  ---
Hi Anastasius,

Thank you verrrry match for investigation and sorry for miss-specifying the
importance.

It works now X)

[Bug 43515] World of Warships 0.6.9 crashes on startup ('ProgramData' environment variable not set)

https://bugs.winehq.org/show_bug.cgi?id=43515

--- Comment #5 from Anastasius Focht  ---
Hi Mario,

--- quote ---
It works now X)
--- quote ---

Good to hear ;-)

It seems there is currently a lot of confusion/misinformation about WoWs 0.6.9
DX9 vs. DX11 in support and gaming forums,

https://forum.worldofwarships.eu/topic/7787-world-of-warships-linux-guide/?p...

https://forum.worldofwarships.com/topic/133613-the-game-does-not-run/

Since I provided the disassembly with crash location, all bug reports in their
forums/tickets showing crash address 0x00D81E60 (NULL ptr dereference) are
exactly this issue which can be easily worked around.

Alternatively WG could fix this sloppy programming on their side, adding
check(s) for NULL pointer on getenv() return and provide this as minor WoWS
update 0.6.9.1 something.

Regards

[Bug 43515] World of Warships 0.6.9 crashes on startup ('ProgramData' environment variable not set)

https://bugs.winehq.org/show_bug.cgi?id=43515

Andreas Schallenberg  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Andreas.Schallenberg@Eurobi
                   |                            |ld.com

[Bug 43515] World of Warships 0.6.9 crashes on startup ('ProgramData' environment variable not set)

https://bugs.winehq.org/show_bug.cgi?id=43515

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Nikolay Sivov  ---
Closing duplicates.

[Bug 43515] World of Warships 0.6.9 crashes on startup ('ProgramData' environment variable not set)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=43515

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |kernel32
                URL|http://dl-wows-gc.wargaming |https://web.archive.org/web
                   |.net/eu/files/ilcClx1YzB/Wo |/20201112043601/http://dl-w
                   |WS_internet_install_eu.exe  |ows-gc.wargaming.net/eu/fil
                   |                            |es/ilcClx1YzB/WoWS_internet
                   |                            |_install_eu.exe