[Bug 12299] New: Commandos 3 crashes when selecting soldier

http://bugs.winehq.org/show_bug.cgi?id=12299

Summary: Commandos 3 crashes when selecting soldier
           Product: Wine
           Version: CVS/GIT
          Platform: PC
               URL: http://www.eidosinteractive.com/downloads/search.html?gm
                    id=143
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

When selecting soldier in Commandos 3: Behind Enemy Lines, application crashes.

This is a regression caused by patch:
commit 165970992ae0ce2cd7ee352b48e793b0e93d03fc
Author: Alexander Dorofeyev 
Date:   Thu Mar 27 00:23:04 2008 +0200

wined3d: Make device palettes dynamically allocated.

[Bug 12299] Commandos 3 crashes when selecting soldier

http://bugs.winehq.org/show_bug.cgi?id=12299

Pawel Nadolski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression

[Bug 12299] Commandos 3 crashes when selecting soldier

http://bugs.winehq.org/show_bug.cgi?id=12299

--- Comment #1 from Alexander Dorofeyev   2008-03-30 14:32:56 ---
Please give me some more details. Can it be reproduced in demo and if yes how,
give exact steps? By soldier you mean player's character? In tutorial mission I
seem to be able to select him without problems.

Also please attach +d3d,+d3d_surface log (it may be large so you can cut last
10000 lines by tail -n 10000).

[Bug 12299] Commandos 3 crashes when selecting soldier

http://bugs.winehq.org/show_bug.cgi?id=12299

--- Comment #2 from Alexander Dorofeyev   2008-03-30 15:17:04 ---
Wait, Behind Enemy Lines - you mean commandos *2*, right? Commandos 3 is called
"Destination Berlin".

[Bug 12299] Commandos 3 crashes when selecting soldier

http://bugs.winehq.org/show_bug.cgi?id=12299

--- Comment #3 from Pawel Nadolski   2008-03-30 17:35:43 ---
Created an attachment (id=11751)
 --> (http://bugs.winehq.org/attachment.cgi?id=11751)
last 10k lines of crash log with +d3d,+d3d_surface trace

I meant "Destination Berlin" of course, sorry for the confusion.

I get this crash on full version of the game, on any campaign when I select
commandos (character that you give orders to), game immediately crashes.
I will try to reproduce this with the demo as soon as I finish downloading it.

I was able to reproduce this also for revision 113f2c9 (one before 1659709),
but the crash was not immediate (in the training campaign I could play with
Green Beret for a while and it crashed when switching to Sniper). I think I got
similar crashes also for wine-0.9.58 or 57 when exiting the game just after
lunching it. By similar I mean the backtrace log always contains this:
/home/pawel/src/wine-git/dlls/wined3d/stateblock.c:752
/home/pawel/src/wine-git/dlls/d3d8/device.c:1126
It seems to be some older problem which has been exposed with your patch.

[Bug 12299] Commandos 3 crashes when selecting soldier

http://bugs.winehq.org/show_bug.cgi?id=12299

--- Comment #4 from Alexander Dorofeyev   2008-03-30 18:32:10 ---
Created an attachment (id=11753)
 --> (http://bugs.winehq.org/attachment.cgi?id=11753)
debug output patch

You may be right about another problem being explosed. As far as I can tell the
crash is because of insane values being passed to some vertex shader constant
function. Can you apply this patch with debugging output added, run with +d3d,
+d3d_surface and re-upload the log, please (if you do, obsolete  the old one).

[Bug 12299] Commandos 3 crashes when selecting soldier

http://bugs.winehq.org/show_bug.cgi?id=12299

Pawel Nadolski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11751|0                           |1
        is obsolete|                            |

--- Comment #5 from Pawel Nadolski   2008-03-30 19:17:15 ---
Created an attachment (id=11754)
 --> (http://bugs.winehq.org/attachment.cgi?id=11754)
last 10k lines of crash log with +d3d,+d3d_surface trace and debug output patch
applied

[Bug 12299] Commandos 3 crashes when selecting soldier

http://bugs.winehq.org/show_bug.cgi?id=12299

--- Comment #6 from Alexander Dorofeyev   2008-04-01 12:53:55 ---
Created an attachment (id=11788)
 --> (http://bugs.winehq.org/attachment.cgi?id=11788)
debug patch 2

It's visible in the log that stateblock private data got corrupted somehow,
probably a memory corruption problem of some kind, but it isn't clear where and
how it's corrupted. So far I wasn't successful in reproducing it. I got myself
a retail version, but I've same bug there as in demo - game is unplayable
everywhere except few tutorial rooms, screen goes black and white color with
only few silhuettes of objects visible. So I can't test much. I guess I'll have
to ask you to run one or few more tests :). Try this next patch please, I added
some debug checks there that hopefully may sound the alarm closer to the spot
where corruption happens. If you do, maybe this time it would make sense to
look for ways to get me a full log. Try to bzip2 it, if it won't be more than
10-15mb you can mail it to me.

BTW what's your hardware and drivers? And do you use some direct3d registry key
tweaks? I wonder why you can play the game and for me it's broken in most
locations.

[Bug 12299] Commandos 3 crashes when selecting soldier

http://bugs.winehq.org/show_bug.cgi?id=12299

--- Comment #7 from Pawel Nadolski   2008-04-01 17:22:22 ---
I've updated wine from git and your patch doesn't apply cleanly (in device.c)
and I don't know to which version should I reset source. (Three lines that were
not applied contained stateblock_dbg_check() call.)
Nevertheless I tried to get the trace with this patch applied to the latest
source (2d1cf6c) but game crashed earlier, just after loading the level at
line:
TRACE("%u stateblocks tracked\n", num_stateblocks); 
in stateblock_dbg_check() function. So it would probably not be useful.

My hardware is ThinkPad T60 with Intel 945GM, running Ubuntu 7.10 with
xserver-xorg-video-intel version 2.1.1-0ubuntu9. I think this was clean
installation with rm -rf ~/.wine but on some older version of wine maybe .57 or
.58

The demo (smaller one) doesn't crash for me (in 1659709, in latest 2d1cf6c it
crashes at startup) in the training campaign (in the other one available it
crashes silently with core dump before loading level) and the only graphics
problems I have are on loading level screen and inside sniper scope. I didn't
try to play any further but it looks playable.

[Bug 12299] Commandos 3 crashes when selecting soldier

http://bugs.winehq.org/show_bug.cgi?id=12299

--- Comment #8 from Alexander Dorofeyev   2008-04-01 18:11:45 ---
> My hardware is ThinkPad T60 with Intel 945GM, running Ubuntu 7.10 with
> xserver-xorg-video-intel version 2.1.1-0ubuntu9. I think this was clean
> installation with rm -rf ~/.wine but on some older version of wine maybe .57 or
> .58

I asked Stefan Dosinger in irc, he says this hardware has known random memory
corruption issues (driver bugs). If that's the case here, there isn't much that
can be done.  I'll try to update patch though.

[Bug 12299] Commandos 3 crashes when selecting soldier

http://bugs.winehq.org/show_bug.cgi?id=12299

Alexander Dorofeyev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11753|0                           |1
        is obsolete|                            |
  Attachment #11788|0                           |1
        is obsolete|                            |

--- Comment #9 from Alexander Dorofeyev   2008-04-01 18:20:30 ---
Created an attachment (id=11793)
 --> (http://bugs.winehq.org/attachment.cgi?id=11793)
debug patch for current git

patch fixed to apply.

[Bug 12299] Commandos 3 crashes when selecting soldier

http://bugs.winehq.org/show_bug.cgi?id=12299

--- Comment #10 from Alexander Dorofeyev   2008-04-01 18:21:42 ---
BTW is there any chance to test on some other hardware?

[Bug 12299] Commandos 3 crashes when selecting soldier

http://bugs.winehq.org/show_bug.cgi?id=12299

--- Comment #11 from Alexander Dorofeyev   2008-04-02 03:40:47 ---
I was able to run the game relatively fine after disabling PBO in wine (it
turns out i've some driver bugs of my own on my machine that break pbo). With
PBO disabled, commandos seemed to run ok, rendering problems are gone, i was
able to run around a bit in stalingrad mission. So on my end it works.

[Bug 12299] Commandos 3 crashes when selecting soldier

http://bugs.winehq.org/show_bug.cgi?id=12299

Pawel Nadolski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11754|0                           |1
        is obsolete|                            |

--- Comment #12 from Pawel Nadolski   2008-04-06 13:34:59 ---
Created an attachment (id=11892)
 --> (http://bugs.winehq.org/attachment.cgi?id=11892)
crash log for +d3d,+d3d_surface trace and debug output 2 patch applied

With your patch game crashed at startup.

I couldn't reproduce this bug on another hardware - some HP notebook with intel
graphics, which appears to have same graphics chipset, for both notebooks lspci
returns:
00:02.0 VGA compatible controller: Intel Corporation Mobile 945GM/GMS,
943/940GML Express Integrated Graphics Controller (rev 03)
00:02.1 Display controller: Intel Corporation Mobile 945GM/GMS/GME, 943/940GML
Express Integrated Graphics Controller (rev 03)
This notebook also runs Ubuntu and graphics driver with the same version.

[Bug 12299] Commandos 3 crashes when selecting soldier

http://bugs.winehq.org/show_bug.cgi?id=12299

--- Comment #13 from Alexander Dorofeyev   2008-04-12 07:24:07 ---
(In reply to comment #12)
> With your patch game crashed at startup.

This time the watchdog function caught corruption and aborted. But it appears
to be not related to anything palette, as I've put these tripwires in routines
affected by making palettes dynamic. Let's see if I can put tripwires in more
routines. I'm afraid though that eventually it will turn out to be some gl/glx
call that triggers a driver bug.

[Bug 12299] Commandos 3 crashes when selecting soldier

http://bugs.winehq.org/show_bug.cgi?id=12299

Alexander Dorofeyev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11793|0                           |1
        is obsolete|                            |

--- Comment #14 from Alexander Dorofeyev   2008-04-12 07:50:20 ---
Created an attachment (id=12091)
 --> (http://bugs.winehq.org/attachment.cgi?id=12091)
debug patch 3

Here, I added more checks everywhere and regenerated patch for current git.

[Bug 12299] Commandos 3 crashes when selecting soldier

http://bugs.winehq.org/show_bug.cgi?id=12299

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|download                    |

--- Comment #15 from Austin English   2008-12-18 13:05:29 ---
Download's busted, please retest in 1.1.10 and update the url.

[Bug 12299] Commandos 3 crashes when selecting soldier

http://bugs.winehq.org/show_bug.cgi?id=12299

Pawel Nadolski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #16 from Pawel Nadolski   2008-12-27 05:41:36 ---
Unable to reproduce on wine 1.1.10 and Ubuntu 8.10. Fixed.

[Bug 12299] Commandos 3 crashes when selecting soldier

http://bugs.winehq.org/show_bug.cgi?id=12299

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified

[Bug 12299] Commandos 3 crashes when selecting soldier

http://bugs.winehq.org/show_bug.cgi?id=12299

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #17 from Alexandre Julliard   2009-01-02 10:33:25 ---
Closing bugs fixed in 1.1.12.