[Bug 12150] New: Photoshop7 -> open file -> select more than 36 files, Wine dies

http://bugs.winehq.org/show_bug.cgi?id=12150

Summary: Photoshop7 -> open file -> select more than 36 files,
                    Wine dies
           Product: Wine
           Version: 0.9.56.
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

it is very simple and exists till i'm using wine with Photoshop (~2years). The
first 1.5 years i've had a 64bit Fedora-Linux and now an 32bit Fedora.

I am currently using wine 0.9.56 in Fedora8 and have tested it today multiple
times and report this, because i have read, that Photoshop-compatibility should
be the goal for Wine 1.0.

The steps are real simple:
1. start Photoshop7
2. Menu -> File -> open
3. an open-file dialog appears
4. select 36 files, all is OK
5. select the 37th file, wine disappears, all gone

I'm running Fedora8 with KDE 3.5.0, Photoshop7 as windows98 application and my
Desktop file contains:
[Desktop Entry]
Comment=Windows-Programm
Comment[de]=Windows-Programm
Encoding=UTF-8
Exec='/usr/bin/wine' photoshop.exe
GenericName=Photoshop 7.0
GenericName[de]=Photoshop 7.0
Icon=kpaint
MimeType=
Name=Photoshop 7.0
Name[de]=Photoshop 7.0
Path=$HOME/.wine/drive_c/Program Files/Adobe/Photoshop 7.0
StartupNotify=true
Terminal=false
TerminalOptions=
Type=Application
Version=1.0
X-DCOP-ServiceType=
X-KDE-SubstituteUID=false
X-KDE-Username=

feel free, to contact me for more infos!
   Hardy

[Bug 12150] Photoshop7 -> open file -> select more than 36 files, Wine dies

http://bugs.winehq.org/show_bug.cgi?id=12150

--- Comment #1 from Hardy   2008-03-22 16:29:42 ---
Sorry, it's KDE 3.5.9 that i'm running ...

[Bug 12150] Photoshop7 -> open file -> select more than 36 files, Wine dies

http://bugs.winehq.org/show_bug.cgi?id=12150

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://wiki.winehq.org/Adobe
                   |                            |Photoshop
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |download

--- Comment #2 from Lei Zhang   2008-03-24 15:04:14 ---
Happens here as well. Though I think this may be a problem that affects any
application where you can select multiple files in a file dialog box. There may
already be a bug filed for that.

[Bug 12150] Photoshop7 -> open file -> select more than 36 files, Wine dies

http://bugs.winehq.org/show_bug.cgi?id=12150

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Dan Kegel   2008-04-15 20:22:08 ---
Immediately reproducible with Photoshop 7 trial.
Hmm, I wonder if this also happens on Windows.

Does not happen with Photoshop CS2, nor with Notepad++.
Here's how I tested:
 mkdir pix
 cd pix
 for a in `seq 1 100 `; do cp ../Pictures/foo.jpg $a.jpg; done
I then started photoshop, did File/Open, clicked on 1.jpg, shift-clicked on
100.jpg, and watched it merrily load 100 pictures.
No crashes.  With PS CS2, I did see messages like
err:local:LOCAL_GetBlock not enough space in USER heap 10d7 for 80 bytes
err:menu:MENU_CopySysPopup Unable to load default system menu
err:menu:MENU_GetSysMenu failed to load system menu!
quite frequently, but the app remained stable.  Some images towards
the back of the stack only drew their backgrounds, but that was
always fixed when they came to the fore.

[Bug 12150] Photoshop7 -> open file -> select more than 36 files, Wine dies

http://bugs.winehq.org/show_bug.cgi?id=12150

--- Comment #4 from Dan Kegel   2008-04-15 22:47:44 ---
Also reproducible with Photoshop 6 Trial.
Does not happen on Windows XP.

I tried comparing selecting 3 files and selecting 100.  With 3, one sees

0009:Call KERNEL32.OpenFile(0033c4cc "Z:\home\dank\pix\1.jpg 10.jpg
100.jpg",0033c1c8,00000000) ret=00a6ea99
0009:Ret  KERNEL32.OpenFile() retval=ffffffff ret=00a6ea99
0009:Call KERNEL32.SetErrorMode(00000000) ret=00a6eac6
0009:Ret  KERNEL32.SetErrorMode() retval=00000001 ret=00a6eac6
0009:Call KERNEL32.lstrcpyA(0033c3c8,0108f418 "") ret=00a97ff9
0009:Ret  KERNEL32.lstrcpyA() retval=0033c3c8 ret=00a97ff9
0009:Call user32.GetDlgItem(000102f0,00000441) ret=00a9800c
0009:Ret  user32.GetDlgItem() retval=000102fa ret=00a9800c
0009:Call user32.SetDlgItemTextA(000102f0,00000441,0033c3c8 "") ret=00a98021

With 100, one sees

0009:Call KERNEL32.OpenFile(0033c4cc "Z:\home\dank\pix\1.jpg 10.jpg 100.jpg
11.jpg 12.jpg 13.jpg 14.jpg 15.jpg 16.jpg 17.jpg 18.jpg 19.jpg 2.jpg 20.jpg
21.jpg 22.jpg 23.jpg 24.jpg 25.jpg 26.jpg 27.jpg 28.jpg 29.jpg 3.jpg 30.jpg
31.jpg 32.jpg 33.jpg 34.jpg 35.jpg 36.jpg 37.jpg 38.jpg 39.jpg 4.jpg 40.jpg
41.jpg 42.",0033c1c8,00000000) ret=00a6ea99
0009:Ret  KERNEL32.OpenFile() retval=ffffffff ret=00a6ea99
0009:Call KERNEL32.SetErrorMode(00000000) ret=00a6eac6
0009:Ret  KERNEL32.SetErrorMode() retval=00000001 ret=00a6eac6
0009:Call KERNEL32.lstrcpyA(0033c3c8,0108f418 "") ret=00a97ff9
0009:Ret  KERNEL32.lstrcpyA() retval=0033c3c8 ret=00a97ff9
0009:Call user32.GetDlgItem(00010200,00000441) ret=00a9800c
0009:Ret  user32.GetDlgItem() retval=00000000 ret=00a9800c
trace:seh:raise_exception code=c0000005 flags=0 addr=0x2e323420
trace:seh:raise_exception  info[0]=00000000
trace:seh:raise_exception  info[1]=2e323420
trace:seh:raise_exception  eax=00000000 ebx=0033cc28 ecx=706a2e30 edx=0011004c
esi=000102f0 edi=00030040
trace:seh:raise_exception  ebp=0033c8f8 esp=0033c5e0 cs=0073 ds=007b es=007b
fs=0033 gs=003b flags=00010202
err:seh:raise_exception Exception frame is not in stack limits => unable to
dispatch exception.

[Bug 12150] Photoshop7 -> open file -> select more than 36 files, Wine dies

http://bugs.winehq.org/show_bug.cgi?id=12150

--- Comment #5 from Alexandre Julliard   2008-04-16 09:19:46 ---
That's a photoshop bug, it does an lstrcatA of two MAX_PATH-sized strings into
a MAX_PATH-sized destination so it overflows. Presumably Windows has an
exception handler somewhere that hides the bug.

[Bug 12150] Photoshop7 -> open file -> select more than 36 files, Wine dies

http://bugs.winehq.org/show_bug.cgi?id=12150

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX

--- Comment #6 from Dan Kegel   2008-04-16 09:28:34 ---
OK, marking WONTFIX (unless enough users complain, I suppose).

[Bug 12150] Photoshop7 -> open file -> select more than 36 files, Wine dies

http://bugs.winehq.org/show_bug.cgi?id=12150

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WONTFIX                     |FIXED

--- Comment #7 from Alexandre Julliard   2008-04-17 07:41:30 ---
Actually the broken code path can be avoided by making sure we preserve quotes
on multiple file selections. Now it should only crash if a single file name
overflows the buffer, that should be good enough.

[Bug 12150] Photoshop7 -> open file -> select more than 36 files, Wine dies

http://bugs.winehq.org/show_bug.cgi?id=12150

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard   2008-04-18 11:04:18 ---
Closing bugs reported fixed in 0.9.60.