http://bugs.winehq.org/show_bug.cgi?id=29235
Bug #: 29235 Summary: Worms Armageddon: frontend flickers (regression in 1.3.34 from 1.3.33) Product: Wine Version: 1.3.34 Platform: x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: minor Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: bladud@gmail.com Classification: Unclassified
The frontend to Worms armageddon (which works perfectly) in 1.3.33 flickers badly in 1.3.34. The game itself is fine, and the menu renders correctly and is useable, but somewhat headache-inducing.
It looks as if every other frame is being rendered as a black screen; I have verified that this is the case both with and without double buffering enabled.
In addition, the console in 1.3.34 prints this line:
err:d3d_surface:surface_load_location Surface 0x15ac48 does not have any up to date location.
which it did not in 1.3.33 (also some unchanged fixme messages which don't seem to be causing a problem).
A git bisect produced this output:
94c0da184e18252ca2df7f9f462e9a4df9c5f2df is the first bad commit commit 94c0da184e18252ca2df7f9f462e9a4df9c5f2df Author: Henri Verbeet hverbeet@codeweavers.com Date: Thu Dec 1 07:31:41 2011 +0100
wined3d: Create a PBO in surface_load_location() even if SFLAG_INSYSMEM is already set.
In the longer term, sysmem and pbo should be separate resource locations.
:040000 040000 0ea129726096c1508557eacfc8272cf884f0c61b 4e1bfdfeccfc95e0b700f75d6841dbb7cc1889da M dlls
http://bugs.winehq.org/show_bug.cgi?id=29235
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Worms Armageddon: frontend |Worms Armageddon: frontend |flickers (regression in |flickers |1.3.34 from 1.3.33) |
http://bugs.winehq.org/show_bug.cgi?id=29235
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Regression SHA1| |94c0da184e18252ca2df7f9f462 | |e9a4df9c5f2df
http://bugs.winehq.org/show_bug.cgi?id=29235
--- Comment #1 from Murray Colpman muzerakascooby@gmail.com 2011-12-05 11:08:42 CST --- Created attachment 37810 --> http://bugs.winehq.org/attachment.cgi?id=37810 ERRORLOG.TXT from wine GDI renderer.
I can confirm this does indeed happen.
In addition, the GDI renderer has stopped working, presenting the attached errorlog.txt. I don't know whether or not this happened in the same change; but I'll find out now. Bear in mind that GDI renderer was the only way to run it in vanilla 1.3.33 (I believe), though a patch was available in another (now-closed) bug report to fix the OpenGL renderer - if this patch was applied, the issue also did not occur.
http://bugs.winehq.org/show_bug.cgi?id=29235
--- Comment #2 from Henri Verbeet hverbeet@gmail.com 2011-12-05 11:12:45 CST --- (In reply to comment #1)
In addition, the GDI renderer has stopped working, presenting the attached errorlog.txt. I don't know whether or not this happened in the same change; but
Yeah, that's probably bug 29213.
http://bugs.winehq.org/show_bug.cgi?id=29235
Vladimir Panteleev thecybershadow@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |thecybershadow@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=29235
Murray Colpman muzerakascooby@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |muzerakascooby@gmail.com
--- Comment #3 from Murray Colpman muzerakascooby@gmail.com 2011-12-05 13:03:29 CST --- One other thing that may be of interest is that when SlowFrontendWorkaround is set to "On" (rather than "Off" or "Alternative"), the frontend runs at a much lower framerate (as expected, and as happens on plenty of Windows systems, and has happened for as long as I can remember in wine; hence the presence of that option), and one can clearly see that bladud's guess is right, that every other frame is rendered as a black screen.
Anyway, performed the regression test - ERRORLOG on GDI startup happened here:
0f10ac93580d5a055f0b3f6e7c3d77738135f031 is the first bad commit commit 0f10ac93580d5a055f0b3f6e7c3d77738135f031 Author: Henri Verbeet hverbeet@codeweavers.com Date: Mon Nov 28 21:30:57 2011 +0100
ddraw: Create the wined3d swapchain when setting the cooperative level.
:040000 040000 f8a8ea10d91985680fe1e29e2fb64aaf8bc59e2d ab3f595c09537f3f18bd03bbe708c584f62e3952 M dlls
...So not the same commit; should I start another bug report?
http://bugs.winehq.org/show_bug.cgi?id=29235
--- Comment #4 from bladud@gmail.com 2011-12-05 18:31:38 CST --- FTR, the bug that broke the opengl renderer was 29097, actually patched and fixed in wine 1.3.33, but not confirmed and marked as such until 1.3.34.
So if you have wine 1.3.33, you can use opengl and worms works fine (this I found out when doing the bisect).
http://bugs.winehq.org/show_bug.cgi?id=29235
--- Comment #5 from Henri Verbeet hverbeet@gmail.com 2011-12-06 06:29:24 CST --- Created attachment 37821 --> http://bugs.winehq.org/attachment.cgi?id=37821 patch
This patch should help.
http://bugs.winehq.org/show_bug.cgi?id=29235
PommeGolden lapommegolden@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lapommegolden@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=29235
--- Comment #6 from bladud@gmail.com 2011-12-06 22:18:09 CST --- Applying the attached patch to git master 1fa1ab54376bace57f78d27ac13b7229caa56a2e fixes the issue for me. Thanks!
PS I still get the surface_load_location error message, but it has no adverse effect that I can see.
http://bugs.winehq.org/show_bug.cgi?id=29235
--- Comment #7 from Henri Verbeet hverbeet@gmail.com 2011-12-08 13:50:24 CST --- Should be fixed by 56e3e05e573f8952f2da1d3db3325ec5b29d22fb.
http://bugs.winehq.org/show_bug.cgi?id=29235
bladud@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #8 from bladud@gmail.com 2011-12-08 20:02:03 CST --- Confirm fixed by that patch.
http://bugs.winehq.org/show_bug.cgi?id=29235
Henri Verbeet hverbeet@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |56e3e05e573f8952f2da1d3db33 | |25ec5b29d22fb
http://bugs.winehq.org/show_bug.cgi?id=29235
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #9 from Alexandre Julliard julliard@winehq.org 2011-12-16 13:30:14 CST --- Closing bugs fixed in 1.3.35.
https://bugs.winehq.org/show_bug.cgi?id=29235
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |focht@gmx.net Component|-unknown |directx-d3d
-
wine-bugs＠winehq.org