[Bug 33328] New: Copy-Paste bug in TAB_SetupScrolling

http://bugs.winehq.org/show_bug.cgi?id=33328

Bug #: 33328
           Summary: Copy-Paste bug in TAB_SetupScrolling
           Product: Wine
           Version: unspecified
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: comctl32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

TAB_SetupScrolling function has a copy-paste bug:

http://source.winehq.org/source/dlls/comctl32/tab.c#L1006

The If and Else blocks in..
1026     if(infoPtr->dwStyle & TCS_VERTICAL)
...seems identical.

[Bug 33328] Copy-Paste bug in TAB_SetupScrolling

http://bugs.winehq.org/show_bug.cgi?id=33328

--- Comment #1 from Nikolay Sivov  2013-04-04 12:20:44 CDT ---
This looks wrong, yes. After some brief testing I can see that it's quite
broken on windows - setting TCS_VERTICAL for single line control messes it up
to unusable state. So I think it's okay to completely remove style check here.

[Bug 33328] Copy-Paste bug in TAB_SetupScrolling

http://bugs.winehq.org/show_bug.cgi?id=33328

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |4f99560ef006d729b9a79284124
                   |                            |d045788ba83fd
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Nikolay Sivov  2013-05-20 20:38:28 CDT ---
Fixed with 4f99560ef006d729b9a79284124d045788ba83fd.

[Bug 33328] Copy-Paste bug in TAB_SetupScrolling

http://bugs.winehq.org/show_bug.cgi?id=33328

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  2013-05-24 13:32:45 CDT ---
Closing bugs fixed in 1.5.31.