[Bug 14705] New: Patch for Wordpad that fixes some glaring issues on Windows and Reactos
http://bugs.winehq.org/show_bug.cgi?id=14705
Summary: Patch for Wordpad that fixes some glaring issues on Windows and Reactos Product: Wine Version: unspecified Platform: Other OS/Version: Windows Vista Status: UNCONFIRMED Severity: normal Priority: P2 Component: programs AssignedTo: wine-bugs@winehq.org ReportedBy: roelmessiant@gmail.com CC: roelmessiant@gmail.com
Created an attachment (id=15191) --> (http://bugs.winehq.org/attachment.cgi?id=15191) Patch for Wordpad
The following issues are resolved:
- Junk in the statusbar when text has been entered - Message boxes with junk - Message boxes without their messages being loaded - Incorrect behaviour when setting a new text size - Minor system color brush abuse
TODO
- Trying to make sense of this 50% ANSI and 50% Unicode code - Finding out why a refresh of the rebars takes upto 10 sec
The symptoms occur on Windows and Reactos, some only occur when UNICODE is defined. This patch is a slight modification of Reactos bug 3612, which was not accepted there because "it is Wine code, and we don't accept patches for Wine code" Reference http://www.reactos.org/bugzilla/show_bug.cgi?id=3612
Enjoy
http://bugs.winehq.org/show_bug.cgi?id=14705
--- Comment #1 from Juan Lang juan_lang@yahoo.com 2008-07-31 15:10:15 --- 1. One fix per patch, please. 2. One patch per email. 3. Send patches to wine-patches, they're not picked up here.
All this is explained here, linked from the front page: http://www.winehq.org/site/sending_patches
http://bugs.winehq.org/show_bug.cgi?id=14705
--- Comment #2 from Roel Messiant roelmessiant@gmail.com 2008-07-31 17:25:07 --- (In reply to comment #1)
- One fix per patch, please.
- One patch per email.
- Send patches to wine-patches, they're not picked up here.
All this is explained here, linked from the front page: http://www.winehq.org/site/sending_patches
I understand this is not the proper way to send a patch to Wine, my apologies for this.
The correct way implies I should first: 1) get a GIT client 2) get it to download (part of) the source tree 3) get it to make several patches 4) mail them all
I'm not really very keen to go through that hassle, as you may understand
http://bugs.winehq.org/show_bug.cgi?id=14705
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch, source OS/Version|Windows Vista |other
http://bugs.winehq.org/show_bug.cgi?id=14705
Andrey Turkin andrey.turkin@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |andrey.turkin@gmail.com
--- Comment #3 from Andrey Turkin andrey.turkin@gmail.com 2008-10-10 14:09:51 --- Several patches including unicode fixes just went in to GIT. Please retest and let me know if you think something should be fixed.
http://bugs.winehq.org/show_bug.cgi?id=14705
--- Comment #4 from Roel Messiant roelmessiant@gmail.com 2008-10-10 21:06:34 --- Created an attachment (id=16574) --> (http://bugs.winehq.org/attachment.cgi?id=16574) Guideline to fix the registry functions
(In reply to comment #3)
Several patches including unicode fixes just went in to GIT. Please retest and let me know if you think something should be fixed.
I see some of the fixes in the original patch have been commited, which I'm happy about.
Of course I would also like to see the MessageBox calls fixed, as the behaviour on Windows and Reactos does not support its arguments to be resource strings.
On a more constructive note, the original patch was just the tip of the iceberg of the fixes I made on Wordpad, but due to the history of this bug report I don't feel like just giving away the code (yes, I'm a bastard, I know).
I will however give some guidelines on a few of the flaws I found and fixed on my side:
- In the file registry.c, pretty much all functions potentially attempt to close a random registry handle, it doesn't really take all that much bad luck for it to happen either. A guideline to clean up this file is given in the attachment. - DoSaveFile leaks a handle if a WriteFile isn't satisfactory - Why (not quite so accurate) conversions between twips and centimeters when you can use more natural conversions between twips and inches, and inches and micrometers. Micrometers seem quite small but you can still represent values up to 4.2 kilometers if you're using a 32 bit ULONG that stores a micrometer measurement.
Enjoy
http://bugs.winehq.org/show_bug.cgi?id=14705
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |testcase
http://bugs.winehq.org/show_bug.cgi?id=14705
--- Comment #5 from Andrey Turkin andrey.turkin@gmail.com 2008-10-15 11:26:23 --- Thanks for suggestions, they were implemented except for MessageBox one (hopefully this last one will be submitted shortly)
http://bugs.winehq.org/show_bug.cgi?id=14705
--- Comment #6 from Andrey Turkin andrey.turkin@gmail.com 2008-10-23 09:06:32 --- MessageBox fix just went in so this bug can be closed unless you have more ideas :)
http://bugs.winehq.org/show_bug.cgi?id=14705
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #7 from Austin English austinenglish@gmail.com 2009-04-26 20:52:11 --- Reported fixed.
http://bugs.winehq.org/show_bug.cgi?id=14705
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #8 from Alexandre Julliard julliard@winehq.org 2009-05-08 12:46:37 --- Closing bugs fixed in 1.1.21.
-
wine-bugs＠winehq.org