http://bugs.winehq.org/show_bug.cgi?id=22197
Summary: PlayOnline viewer shows black screen Product: Wine Version: 1.1.41 Platform: x86 URL: http://dl.square-enix.co.jp/polus/setup.exe OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: wylda@volny.cz
When trying to confirm bug 22145, i found recent regression...
1. When switching into windowed mode (not need for reproduction, but shows another flaws) and running "wine pol.exe", it will display black window and only music plays.
2. I did a regression test between 1.1.40 and 1.1.41:
78166b0b23a1c0ce81f19c7c85dc18a0d672425d is first bad commit commit 78166b0b23a1c0ce81f19c7c85dc18a0d672425d Author: Henri Verbeet hverbeet@codeweavers.com Date: Mon Mar 15 21:07:31 2010 +0100
wined3d: Implement SetDestWindowOverride() by simply making the context current on a different window.
:040000 040000 e0ba03c96fefb6d42b18b98db092da5e81854192 419d4ced841d332931a5973aa167c4f21e1b4bad M dlls
3. No other bug report suffers from this commit.
4. Revert of this patch on top of wine-1.1.41-211-g719d904 makes that problem go away.
5. Adding author of this patch to CC.
--private keyword: bisected
Bonus flaws in windowed mode with reverted patch. When resizing apps (not wine) window:
* content gets shifted and part of it is missing now. * Wine mouse pointer (windows) does not follows POL pointer (custom hand) * moving POL window (not wine's) asynchronously moves content of the window (shift metricks changes, different speed of movement, incorectly repainted...)
I intentionally do not open new bugs for these, because it may get fixed when failing commit is fixed. So i rather mention this as another testcases when validating if new commit is OK.
http://bugs.winehq.org/show_bug.cgi?id=22197
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, NoAppDBEntry, | |regression CC| |hverbeet@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=22197
--- Comment #1 from Henri Verbeet hverbeet@gmail.com 2010-03-30 04:30:11 --- Any console output?
http://bugs.winehq.org/show_bug.cgi?id=22197
--- Comment #2 from Wylda wylda@volny.cz 2010-03-30 17:04:44 --- Created an attachment (id=27107) --> (http://bugs.winehq.org/attachment.cgi?id=27107) Console log from wine-1.1.41-339-gc38d565 (Bad)
(In reply to comment #1)
Any console output?
If i compare good and bad console outputs, good has two following lines compared to only one line in case of bad 1.1.41:
fixme:d3d:WineD3D_ChoosePixelFormat Add OpenGL context recreation support to SetDepthStencilSurface
fixme:d3d:WineD3D_ChoosePixelFormat Add OpenGL context recreation support to SetDepthStencilSurface
Bad trace attached.
http://bugs.winehq.org/show_bug.cgi?id=22197
--- Comment #3 from Wylda wylda@volny.cz 2010-03-30 17:05:49 --- Created an attachment (id=27108) --> (http://bugs.winehq.org/attachment.cgi?id=27108) Console log from wine-1.1.40 (Good)
http://bugs.winehq.org/show_bug.cgi?id=22197
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|NoAppDBEntry |
--- Comment #4 from Dmitry Timoshkov dmitry@codeweavers.com 2010-03-31 00:37:39 --- NoAppDBEntry is useless, please don't add it.
http://bugs.winehq.org/show_bug.cgi?id=22197
--- Comment #5 from Henri Verbeet hverbeet@gmail.com 2010-04-06 06:31:49 --- Created an attachment (id=27235) --> (http://bugs.winehq.org/attachment.cgi?id=27235) patch
This patch should help. Looks like we had some code depending on the old, broken, behaviour of SetDestWindowOverride().
http://bugs.winehq.org/show_bug.cgi?id=22197
--- Comment #6 from Henri Verbeet hverbeet@gmail.com 2010-04-06 06:37:10 --- For what it's worth, I think resizing is still broken with this patch. If that's a regression you'll probably have to do another regression test (while applying this patch for commits after 78166b0b23a1c0ce81f19c7c85dc18a0d672425d).
http://bugs.winehq.org/show_bug.cgi?id=22197
--- Comment #7 from Wylda wylda@volny.cz 2010-04-06 08:01:22 ---
Hi Henri, i tested your patch, but i think it needs one another look inside.
I applied it to wine-1.1.42-30-ga7d000e and it began to work in full screen. So i switch to windowed mode by winecfg. Then run again a tried to resize the app's window in windowed mode. This worked before.
Since i did this resize in windowed mode, i see only black screen with music. Stopping, killing, winserver -k, nothing helps to see app's window again when i run it - it remains black :(
And it keeps vomiting following two lines:
fixme:d3d:context_apply_state Activating for CTXUSAGE_BLIT for an offscreen target with ORM_FBO. This should be avoided.
err:d3d:context_apply_draw_buffer >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glDrawBuffers() @ context.c / 1890
http://bugs.winehq.org/show_bug.cgi?id=22197
--- Comment #8 from Wylda wylda@volny.cz 2010-04-06 08:06:00 ---
Hmmm... When i commit my last replay, bugzilla sent it to: * Danix0@gmail.com * wine-bugs@winehq.org
I wonder, where 'Danix0' comes from?? No such email in CC and history also does not show this email.
http://bugs.winehq.org/show_bug.cgi?id=22197
--- Comment #9 from Wylda wylda@volny.cz 2010-04-06 08:28:58 --- (In reply to comment #7)
Also noticed, that after some time when app's windows is closed a lot of binary char is sent to console instead of text output. When i redirected wine's console output into a file, in quite short time there was cca 1,5Mbytes of random binary chars.
http://bugs.winehq.org/show_bug.cgi?id=22197
--- Comment #10 from Henri Verbeet hverbeet@gmail.com 2010-04-06 08:36:12 --- (In reply to comment #8)
Hmmm... When i commit my last replay, bugzilla sent it to:
- Danix0@gmail.com
- wine-bugs@winehq.org
I wonder, where 'Danix0' comes from?? No such email in CC and history also does not show this email.
Perhaps because he voted on the bug.
http://bugs.winehq.org/show_bug.cgi?id=22197
--- Comment #11 from Henri Verbeet hverbeet@gmail.com 2010-04-06 08:52:22 --- (In reply to comment #7)
Hi Henri, i tested your patch, but i think it needs one another look inside.
I applied it to wine-1.1.42-30-ga7d000e and it began to work in full screen. So i switch to windowed mode by winecfg. Then run again a tried to resize the app's window in windowed mode. This worked before.
Since i did this resize in windowed mode, i see only black screen with music. Stopping, killing, winserver -k, nothing helps to see app's window again when i run it - it remains black :(
And it keeps vomiting following two lines:
fixme:d3d:context_apply_state Activating for CTXUSAGE_BLIT for an offscreen target with ORM_FBO. This should be avoided.
err:d3d:context_apply_draw_buffer >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glDrawBuffers() @ context.c / 1890
Yeah, I noticed that as well, but I don't think it's directly related to this regression. Applying this patch on top of 78166b0b23a1c0ce81f19c7c85dc18a0d672425d gives essentially the same behaviour as reverting that patch (for this application), including the shifted window contents, etc. If that worked in 1.1.40 or before then that's an earlier, separate regression.
Applying this patch on top of current git makes the initial contents visible, but resizing is broken in a different way. I.e., you get the black screen and error messages in the terminal. That's a later regression, and you'll have to apply the patch for this bug while bisecting that one to track it down.
http://bugs.winehq.org/show_bug.cgi?id=22197
--- Comment #12 from Henri Verbeet hverbeet@gmail.com 2010-04-06 08:57:26 --- Created an attachment (id=27238) --> (http://bugs.winehq.org/attachment.cgi?id=27238) stack corruption patch
(In reply to comment #9)
Also noticed, that after some time when app's windows is closed a lot of binary char is sent to console instead of text output. When i redirected wine's console output into a file, in quite short time there was cca 1,5Mbytes of random binary chars.
I did see that, but only once. While investigating this bug I also came across some stack corruption (patch attached here), maybe that was related, but I can't say for sure.
http://bugs.winehq.org/show_bug.cgi?id=22197
--- Comment #13 from Wylda wylda@volny.cz 2010-04-06 09:25:21 --- (In reply to comment #12)
I did see that, but only once. While investigating this bug I also came across some stack corruption (patch attached here), maybe that was related, but I can't say for sure.
After applying this patch, that binary mess gone from my console and i was not able to reproduce it any further :-) So stack corruption patch looks good...
I'm going to give it some more gitting to find out, why with your first patch is not the behavior the same. During that i will also see if that binary mess gone for sure.
BTW: I'll i see something in "winetricks heapchecking" or valgrind - i mean... can i find out such stack corruption by these two tools?
http://bugs.winehq.org/show_bug.cgi?id=22197
--- Comment #14 from Henri Verbeet hverbeet@gmail.com 2010-04-06 09:31:17 --- (In reply to comment #13)
BTW: I'll i see something in "winetricks heapchecking" or valgrind - i mean... can i find out such stack corruption by these two tools?
In principle yes, but interpreting the results isn't necessarily trivial.
http://bugs.winehq.org/show_bug.cgi?id=22197
--- Comment #15 from Wylda wylda@volny.cz 2010-04-06 11:22:16 --- (In reply to comment #14)
... "winetricks heapcheck" or valgrind - i mean... can i find out such stack corruption by these two tools?
In principle yes, but interpreting the results isn't necessarily trivial.
Hmmm... i was wondering, if there is not a cheap way how to add additional checking of other things, during my regular testing of different bug reports. Simply said - add more checking without additional time cost or excessive programming knowledge. That's a pitty, that these two tools can't help regular a user :-/
OK, i think we can close this bug report, when both patches get merged. Because the remaining problem is Stefan's business and it will be more clear for him, if i open a new bug report.
http://bugs.winehq.org/show_bug.cgi?id=22197
--- Comment #16 from Wylda wylda@volny.cz 2010-04-06 12:14:32 --- (In reply to comment #15)
...if i open a new bug report.
Continues at bug 22290.
http://bugs.winehq.org/show_bug.cgi?id=22197
--- Comment #17 from Henri Verbeet hverbeet@gmail.com 2010-04-07 13:40:33 --- Should be fixed by 3b7774b37bd0fcced3b8310571d8583d6250b1dc. Stack corruption should be fixed by 56659c3a7035365f83289caa137b3073c4b252b9.
http://bugs.winehq.org/show_bug.cgi?id=22197
--- Comment #18 from Wylda wylda@volny.cz 2010-04-08 07:33:23 --- (In reply to comment #17)
Should be fixed by 3b7774b37bd0fcced3b8310571d8583d6250b1dc. Stack corruption should be fixed by 56659c3a7035365f83289caa137b3073c4b252b9.
Half-way confirmation. Commit:
http://source.winehq.org/git/wine.git/?a=commit;h=3b7774b37bd0fcced3b8310571...
fixes the black screen, but that binary mess instead of text output still floods my console in wine-1.1.42-113-g2c5eee2. So closing this one as fixed and when i find a reproducible way, i will open a new bug report.
Thank you Henri!
http://bugs.winehq.org/show_bug.cgi?id=22197
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #19 from Wylda wylda@volny.cz 2010-04-08 07:34:18 ---
FIXED.
http://bugs.winehq.org/show_bug.cgi?id=22197
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #20 from Alexandre Julliard julliard@winehq.org 2010-04-16 13:03:13 --- Closing bugs fixed in 1.1.43.
http://bugs.winehq.org/show_bug.cgi?id=22197
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |3b7774b37bd0fcced3b8310571d | |8583d6250b1dc Regression SHA1| |78166b0b23a1c0ce81f19c7c85d | |c18a0d672425d
https://bugs.winehq.org/show_bug.cgi?id=22197
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |focht@gmx.net Component|-unknown |directx-d3d
-
wine-bugs＠winehq.org