[Bug 28340] New: UFO: Extraterrestrials Gold - regression - crash at start now can't be workarounded by using native dsound/directplay

http://bugs.winehq.org/show_bug.cgi?id=28340

Summary: UFO: Extraterrestrials Gold - regression - crash at
                    start now can't be workarounded by using native
                    dsound/directplay
           Product: Wine
           Version: 1.3.25
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: winmm&mci
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
   Regression SHA1: 901af51ea32f2d192a598808abab2d1b6a940773

It was possible to workaround UFO:ET crash at startup by using native (i.e. MS
versions from DirectX runtime) versions of dsound and directmusic. After 1.3.25
it is no longer possible - game crashes at start no matter were the
dsound/directmusic overridden to native or not.

Regression testing comes with the following results:

901af51ea32f2d192a598808abab2d1b6a940773 is the first bad commit
commit 901af51ea32f2d192a598808abab2d1b6a940773
Author: Andrew Eikum 
Date:   Mon Jul 11 08:28:24 2011 -0500

winmm: Remove driver implementation of waveOut*.

:040000 040000 cccb55d925c166ba3838b0179cbdd655a44ba26a
428f760df6efda7a37b4a84f97721523ab72863f M      dlls

Reverting that patch isn't possible with the 1.3.28 - a lot of other cleanup
work followed completing the "Rewrite of the audio support, using the Win7
architecture." task noted in the release notes for 1.3.25.

I suspect that the Right Way (tm) to fix this regression would be to fix bug
#25728 I had reported long ago. In any case, this is a regression in wine
obviously, as the app that was working pretty well before (with one workaround)
stopped to work with a new release.

[Bug 28340] UFO: Extraterrestrials Gold crashes at start (can't be workarounded by using native dsound/directplay)

http://bugs.winehq.org/show_bug.cgi?id=28340

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
            Summary|UFO: Extraterrestrials Gold |UFO: Extraterrestrials Gold
                   |- regression - crash at     |crashes at start (can't be
                   |start now can't be          |workarounded by using
                   |workarounded by using       |native dsound/directplay)
                   |native dsound/directplay    |

[Bug 28340] UFO: Extraterrestrials Gold crashes at start (can't be workarounded by using native dsound/directplay)

http://bugs.winehq.org/show_bug.cgi?id=28340

--- Comment #1 from Andrew Eikum  2011-09-12 08:23:35 CDT ---
Can you attach a debug log as requested at http://wiki.winehq.org/Sound?

[Bug 28340] UFO: Extraterrestrials Gold crashes at start (can't be workarounded by using native dsound/directplay)

http://bugs.winehq.org/show_bug.cgi?id=28340

--- Comment #2 from Alexey Loukianov  2011-09-12 19:40:54 CDT ---
Created an attachment (id=36348)
 --> (http://bugs.winehq.org/attachment.cgi?id=36348)
Attaching dsound trace debug logs as requested.

Here is tarball with the requested logs. File names are pretty
self-explanatory.

UFO_ET.exe crash at 0x004969bd in
wine-git-a9504e2-errors-winxp-native-dsound-native-dmusic is not related to
this bug and is a subject of a separate bug #28343 (d3dx9-related).

Sorry for a lot of buzz at beginnings of logs - I've got Steam version of the
game so it starts up Steam client on UFO_ET.exe launch and only after it had
settled re-executes UFO_ET.exe with subsequent crash.

Additionally I had tried to change dsound from HW mode to Emulated in winecfg,
but it hadn't had any noticeable effect. Crash at 0x0050403c happened no matter
the dsound mode was set.

[Bug 28340] UFO: Extraterrestrials Gold crashes at start (can't be workarounded by using native dsound/directplay)

http://bugs.winehq.org/show_bug.cgi?id=28340

--- Comment #3 from Alexey Loukianov  2011-09-27 17:44:17 CDT ---
Still problem as of wine-1.3.29-99-g3960ea8 (today's git master HEAD). Game
crashes both when using native and when using built-in dsound/dmusic.

[Bug 28340] UFO: Extraterrestrials Gold crashes at start (can't be workarounded by using native dsound/directplay)

http://bugs.winehq.org/show_bug.cgi?id=28340

--- Comment #4 from Andrew Eikum  2012-03-06 10:06:58 CST ---
Thanks, Alexey. Is this still a problem? It probably is. If so, can you throw
up another log with latest Wine, builtin dsound, native dmusic, and the usual
channels?

I'm thinking about working on builtin dmusic (to eventually fix bug 25728, and
many others), but I'd like to get native dmusic working again first.

[Bug 28340] UFO: Extraterrestrials Gold crashes at start (can't be workarounded by using native dsound/directplay)

http://bugs.winehq.org/show_bug.cgi?id=28340

--- Comment #5 from Alexey Loukianov  2012-03-06 15:12:14 CST ---
Hello, Andrew. I'm afraid I won't be able to capture new logs with the latest
wine version right now due to I'm still recovering from the medical issues I've
been having during last few months :-(.

As the recovery process had been progressing pretty well for the last few weeks
(hopefully) chances are high that I'll be in a good enough shape to get back
into toying with Wine in about week or two. Expect to receive the follow up
from by then with the logs you had asked for.

[Bug 28340] UFO: Extraterrestrials Gold crashes at start (can't be workarounded by using native dsound/directplay)

http://bugs.winehq.org/show_bug.cgi?id=28340

--- Comment #6 from Alexey Loukianov  2012-04-17 04:37:39 CDT ---
Andrew, I had attached the logs you had requested to the bug #25728, as they
are more relevant there rather than to this bug.

[Bug 28340] UFO: Extraterrestrials Gold crashes at start (can't be workarounded by using native dsound/directplay)

http://bugs.winehq.org/show_bug.cgi?id=28340

--- Comment #7 from Andrew Eikum  2012-04-18 09:38:55 CDT ---
Okay, I have a better understanding of what's going on here.

In most cases, native directmusic requires native dsound, since it queries for
the undocumented interface {2a8af120-e9de-4132-aaa5-4bdda5f325b8}. I'll send a
note to the winetricks guys to let them know.

I installed directmusic and dsound with winetricks and tested a number of
dmusic games (Team Fortress Arcade, Mr Smoozles, and LA-MULANA), all of which
worked great. So UFO must be hitting some more rare use-case.

You attached a native directmusic log to Bug 25728 Comment 11, but
unfortunately I asked for the wrong thing. Could you get another log with those
same channels and +seh, but with both native directmusic and dsound?

[Bug 28340] UFO: Extraterrestrials Gold crashes at start (can't be workarounded by using native dsound/directplay)

http://bugs.winehq.org/show_bug.cgi?id=28340

--- Comment #8 from Alexey Loukianov  2012-04-18 10:45:47 CDT ---
(In reply to comment #7)
> You attached a native directmusic log to Bug 25728 Comment 11, but
> unfortunately I asked for the wrong thing. Could you get another log with those
> same channels and +seh, but with both native directmusic and dsound?

Sure, would do it right now, it shouldn't took long.

[Bug 28340] UFO: Extraterrestrials Gold crashes at start (can't be workarounded by using native dsound/directplay)

http://bugs.winehq.org/show_bug.cgi?id=28340

--- Comment #9 from Alexey Loukianov  2012-04-18 11:23:03 CDT ---
Guess what, I can't reproduce the crash with latest wine + native dm/ds. Don't
know what had changed, most probably I had only installed native dmusic when 
been testing 1.5.2 + native, at least I can guess that it is the case from the
log contents. So, now it might be safe to close this bug resolved, and I'll do
it in the near future. What I want to do actually is to bisect for the exact
commit which had fixed the thing.

[Bug 28340] UFO: Extraterrestrials Gold crashes at start (can't be workarounded by using native dsound/directplay)

http://bugs.winehq.org/show_bug.cgi?id=28340

Alexey Loukianov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |e19be58e90a5707acbb317af0ff
                   |                            |a6e7464d51ab6
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Alexey Loukianov  2012-04-18 13:05:58 CDT ---
This one (non-working native dsound+dmusic workaround) was fixed by:

e19be58e90a5707acbb317af0ffa6e7464d51ab6 is the first bad commit
commit e19be58e90a5707acbb317af0ffa6e7464d51ab6
Author: Andrew Eikum 
Date:   Tue Oct 4 08:24:27 2011 -0500

winmm: Handle DRV_QUERYMAPPABLE in waveXxxMessage.

:040000 040000 6ce78bf993b46fffdc6d4cef55bf4c061cd6194f
7f8bd8ff459e1169c3e153c968d5220b3f4b44e6 M      dlls

First version without this bug is 1.3.30.

Marking as RESOLVED.

[Bug 28340] UFO: Extraterrestrials Gold crashes at start (can't be workarounded by using native dsound/directplay)

http://bugs.winehq.org/show_bug.cgi?id=28340

--- Comment #11 from Andrew Eikum  2012-04-18 13:09:30 CDT ---
Nice work, Alexey. Thanks again for helping.

[Bug 28340] UFO: Extraterrestrials Gold crashes at start (can't be workarounded by using native dsound/directplay)

http://bugs.winehq.org/show_bug.cgi?id=28340

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard  2012-04-27 12:59:15 CDT ---
Closing bugs fixed in 1.5.3.