[Bug 54815] New: wininet:internet - test_InternetErrorDlg() fails on Windows 10 1607

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54815

Bug ID: 54815
           Summary: wininet:internet - test_InternetErrorDlg() fails on
                    Windows 10 1607
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: wininet
          Assignee: [e-mail]
          Reporter: [e-mail]

wininet:internet - test_InternetErrorDlg() fails on Windows 10 1607:

internet.c:1593: Test failed: Got 0, expected 1223 (12062)
internet.c:1606: Test failed: Got 0, expected 1223 (12062)

See https://test.winehq.org/data/patterns.html#wininet:internet

Where:
  0 == ERROR_SUCCESS
  1223 == ERROR_CANCELLED
  12062 == ERROR_INTERNET_SEC_CERT_WEAK_SIGNATURE

These failures are systematic and only happen on the w1064v1607 VM.

The gist of it is that InternetErrorDlg() does not handle
ERROR_INTERNET_SEC_CERT_WEAK_SIGNATURE as expected on Windows 10 1607.

All is fine on 1709+. But if this was a case where old Windows 10 versions were
broken, then this test should be failing on Windows 10 1507 too. But that's not
the case.

Maybe this should still be a broken() but it would be nice to know what's
different with this VM.

[Bug 54815] wininet:internet - test_InternetErrorDlg() fails on Windows 10 1607

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54815

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source, testcase

[Bug 54815] wininet:internet - test_InternetErrorDlg() fails on Windows 10 1607

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54815

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]

--- Comment #1 from François Gouget  ---
InternetErrorDlg() is actually broken on Windows 10 1507: in the standard hwnd
+ FLAGS_ERROR_UI_FLAGS_NO_UI case it returns ERROR_NOT_SUPPORTED so we set
expected=50 and expected2=0, thus the test succeeds.

But on Windows 10 1607 the standard case returns the expected 1223 but the
FLAGS_ERROR_UI_FLAGS_NO_UI on returns 0 which is broken behavior.

Then on Windows 10 1709+ all works as expected. So this is a broken() that will
require special casing.

[Bug 54815] wininet:internet - test_InternetErrorDlg() fails on Windows 10 1607

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54815

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |341da46629e02fda4b8ab219936
                   |                            |543238d8dadf0
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from François Gouget  ---
This is fixed:

commit 341da46629e02fda4b8ab219936543238d8dadf0
Author:     François Gouget 
AuthorDate: Wed Apr 12 01:04:52 2023 +0200

wininet/tests: Fix the InternetErrorDlg() tests on Windows 10 1607.

ERROR_INTERNET_SEC_CERT_WEAK_SIGNATURE is not supported on 1507, broken
    on 1607 and works as expected on 1709+.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54815

[Bug 54815] wininet:internet - test_InternetErrorDlg() fails on Windows 10 1607

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54815

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 8.7.