[Bug 29127] New: Typing of the Dead demo crashes on launch

http://bugs.winehq.org/show_bug.cgi?id=29127

Bug #: 29127
           Summary: Typing of the Dead demo crashes on launch
           Product: Wine
           Version: 1.3.31
          Platform: x86
               URL: http://www.fileplanet.com/54947/50000/fileinfo/The-Typ
                    ing-of-the-Dead-Demo
        OS/Version: Linux
            Status: NEW
          Keywords: download, regression
          Severity: normal
          Priority: P2
         Component: directx-dsound
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
    Classification: Unclassified
   Regression SHA1: 9d29d9f7665c0e75ed143052408c5fb02fd2afad

Created attachment 37526
  --> http://bugs.winehq.org/attachment.cgi?id=37526
terminal output

Steps to reproduce the problem:

Install and launch the demo. A warning dialog will appear but most of the text
is gibberish (saying something about DirectDraw Hal and RGB). Click on
<Yes>...a crash happens here.

The problem is still present in Wine-1.3.33.

The demo starts correctly in 1.3.30 (apart from the error dialog on startup),
and the result of the regression test:

9d29d9f7665c0e75ed143052408c5fb02fd2afad is the first bad commit
commit 9d29d9f7665c0e75ed143052408c5fb02fd2afad
Author: Andrew Eikum 
Date:   Wed Oct 12 15:10:04 2011 -0500

dsound: Request a more exact buffer size from MMDevAPI.

:040000 040000 4b1f8f62633a9ce65a201591e90d4b457d805fbc
be433f589cc71ac634cf89865e632b8c54bb7c1b M    dlls

git checkout 9d29d9f7665c0e75ed143052408c5fb02fd2afad  >> the demo crashes
git reset --hard HEAD^   >> the demo starts normally

Fedora 16 x86
Alsa 1.0.24
Audio device: nVidia Corporation MCP61 High Definition Audio (rev a2)
PulseAudio is not running

[Bug 29127] Typing of the Dead demo crashes on launch

http://bugs.winehq.org/show_bug.cgi?id=29127

--- Comment #1 from GyB  2011-11-19 00:13:13 CST ---
Created attachment 37527
  --> http://bugs.winehq.org/attachment.cgi?id=37527
winedbg backtrace

This is the backtrace I get when running the demo in winedbg.

[Bug 29127] Typing of the Dead demo crashes on launch

http://bugs.winehq.org/show_bug.cgi?id=29127

Alex Bradbury  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 29127] Typing of the Dead demo crashes on launch

http://bugs.winehq.org/show_bug.cgi?id=29127

Erich Hoover  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Erich Hoover  2011-12-02 13:57:27 CST ---
Try running a trace on dsound and grep-ing it for "blockalign", that looks like
an invalid value might be being passed and it later results in a divide by
zero.

[Bug 29127] Typing of the Dead demo crashes on launch

http://bugs.winehq.org/show_bug.cgi?id=29127

--- Comment #3 from GyB  2011-12-02 14:14:41 CST ---
Created attachment 37748
  --> http://bugs.winehq.org/attachment.cgi?id=37748
+dsound log

Only 2 instances for "blockalign":

...
dsound:primarybuffer_create
(formattag=0x0001,chans=2,samplerate=44100,bytespersec=176400,blockalign=4,bitspersamp=16,cbSize=0)
...
dsound:primarybuffer_SetFormat
(formattag=0x0001,chans=2,samplerate=44100,bytespersec=22050,blockalign=0,bitspersamp=2,cbSize=0)
warn:dsound:DSOUND_CopyFormat Fixing bad nAvgBytesPerSec (22050)
...

[Bug 29127] Typing of the Dead demo crashes on launch

http://bugs.winehq.org/show_bug.cgi?id=29127

--- Comment #4 from Andrew Eikum  2011-12-02 14:14:44 CST ---
Created attachment 37749
  --> http://bugs.winehq.org/attachment.cgi?id=37749
dsound: Validate format in primary buffer's SetFormat()

It is a divide by zero, but it's due to invalid input from the user. TOD asks
the primary buffer to set its format to have 2 bits per sample. Not so
surprisingly, that causes problems, eventually culminating in the divide by
zero.

We should validate the input to SetFormat. This patch fixes it, and it's away
to wine-patches now.

[Bug 29127] Typing of the Dead demo crashes on launch

http://bugs.winehq.org/show_bug.cgi?id=29127

--- Comment #5 from Andrew Eikum  2011-12-05 14:55:48 CST ---
Patch is in Wine as 287a6e8473cb40396b00556ced4f9b275f54ff8e.

[Bug 29127] Typing of the Dead demo crashes on launch

http://bugs.winehq.org/show_bug.cgi?id=29127

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |287a6e8473cb40396b00556ced4
                   |                            |f9b275f54ff8e
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from GyB  2011-12-05 21:38:39 CST ---
Fixed in wine-1.3.34-39-g95f81d1.

[Bug 29127] Typing of the Dead demo crashes on launch

http://bugs.winehq.org/show_bug.cgi?id=29127

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  2011-12-16 13:30:50 CST ---
Closing bugs fixed in 1.3.35.