[Bug 20109] New: Wininet crash in HTTP_GetResponseHeaders when no http statuscode or headers are returned

http://bugs.winehq.org/show_bug.cgi?id=20109

Summary: Wininet crash in HTTP_GetResponseHeaders when no http
                    statuscode or headers are returned
           Product: Wine
           Version: 1.1.29
          Platform: PC
               URL: http://www.computec.ch/projekte/httprecon/download/bin
                    /httprecon-7.3.zip
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: wininet
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=23676)
 --> (http://bugs.winehq.org/attachment.cgi?id=23676)
plain log until crash, with backtrace

Doing some fingerprinting with httprecon 7.3 (install vb6 runtime, unzip, run),
I launched it against a local Boa 0.94.13 http server, which happens to in some
cases return raw HTML on error, instead of a proper HTTP response with status
codes and headers and such.

Wine wininet didn't like that.

Native wininet works around it. (Native wininet isn't very sane in that case
either, but does not crash)

[Bug 20109] Wininet crash in HTTP_GetResponseHeaders when no http statuscode or headers are returned

http://bugs.winehq.org/show_bug.cgi?id=20109

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 20109] Wininet crash in HTTP_GetResponseHeaders when no http statuscode or headers are returned

http://bugs.winehq.org/show_bug.cgi?id=20109

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Hans Leidekker   2009-09-20 13:57:11 ---
> Native wininet works around it. (Native wininet isn't very sane in that case
> either, but does not crash)

What does native wininet do exactly?

[Bug 20109] httprecon 7.3 crashes on invalid http response

http://bugs.winehq.org/show_bug.cgi?id=20109

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Wininet crash in            |httprecon 7.3 crashes on
                   |HTTP_GetResponseHeaders     |invalid http response
                   |when no http statuscode or  |
                   |headers are returned        |

[Bug 20109] httprecon 7.3 crashes on invalid http response

http://bugs.winehq.org/show_bug.cgi?id=20109

--- Comment #2 from [e-mail]  2009-09-21 12:14:16 ---
Synthesizes a fictive "HTTP/1.0 200 OK\r\n\r\n" minimal response header, looks
like.

(wininet.dll from IE5)

No idea what it does to the response body, the app only looks at the headers.

[Bug 20109] httprecon 7.3 crashes on invalid http response

http://bugs.winehq.org/show_bug.cgi?id=20109

--- Comment #3 from [e-mail]  2009-09-29 14:52:36 ---
Testcase submitted:
http://www.winehq.org/pipermail/wine-patches/2009-September/079117.html

[Bug 20109] httprecon 7.3 crashes on invalid http response

http://bugs.winehq.org/show_bug.cgi?id=20109

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |testcase

--- Comment #4 from [e-mail]  2009-09-30 17:24:38 ---
Testcase in git now. The accompanying one-liner fixed the crash, the
application now merely gets no data in return. Which is still wrong, since
that's test data the app depends on, but better.

[Bug 20109] httprecon 7.3 gets wrong data in case of a invalid http response

http://bugs.winehq.org/show_bug.cgi?id=20109

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|httprecon 7.3 crashes on    |httprecon 7.3 gets wrong
                   |invalid http response       |data in case of a invalid
                   |                            |http response

[Bug 20109] httprecon 7.3 gets wrong data in case of a invalid http response

http://bugs.winehq.org/show_bug.cgi?id=20109

Jon Dufresne  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 20109] httprecon 7.3 gets wrong data in case of a invalid http response

http://bugs.winehq.org/show_bug.cgi?id=20109

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Austin English   2010-02-22 10:44:03 ---
Should be fixed by
http://source.winehq.org/git/wine.git/?a=commitdiff;h=2ed570ecc6eef5f5a9e70d....

[Bug 20109] httprecon 7.3 gets wrong data in case of a invalid http response

http://bugs.winehq.org/show_bug.cgi?id=20109

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Hans Leidekker   2010-02-22 11:39:30 ---
*** Bug 21818 has been marked as a duplicate of this bug. ***

[Bug 20109] httprecon 7.3 gets wrong data in case of a invalid http response

http://bugs.winehq.org/show_bug.cgi?id=20109

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard   2010-03-05 12:43:09 ---
Closing bugs fixed in 1.1.40.