[Bug 15382] New: Tray icons won't appear

http://bugs.winehq.org/show_bug.cgi?id=15382

Summary: Tray icons won't appear
           Product: Wine
           Version: 1.0.0
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: user32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Shell_NotifyIcon(NIM_ADD, &rec) is supposed to add icon onto the tray (on the
taskbar).

I have to confirm that in some previous version it worked just fine.
With FedoraCore 8, wine 1.0, it shows icons _ONLY_ if application is run under
root account. With regular user, Shell_NotifyIcon() will return FALSE but
GetLastError() indicates no problems and return zero.

In other words, there are two problems:
1) if Shell_NotifyIcon() enconters a problem, it should return FALSE and
appropriate error code should be available through GetLastError.

2) Shell_NotifyIcon() should let applicatoins running under regular user
account to add icons onto the task bar

[Bug 15382] Tray icons won't appear

http://bugs.winehq.org/show_bug.cgi?id=15382

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

--- Comment #1 from Austin English   2008-09-23 06:07:59 ---
Please run a regression test:
http://wiki.winehq.org/RegressionTesting

[Bug 15382] Tray icons won't appear

http://bugs.winehq.org/show_bug.cgi?id=15382

--- Comment #2 from jvlad   2008-09-23 07:30:06 ---
unfortunately, I have very little control over the linux box. It runs Fedora
Core 8 with official wine 1.0-1 updates available from this site:

http://download.fedora.redhat.com/pub/fedora/linux/updates/8/i386.newkey/

[Bug 15382] Tray icons won't appear

http://bugs.winehq.org/show_bug.cgi?id=15382

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID

--- Comment #3 from Vitaliy Margolen   2008-09-23 19:57:46 ---
Don't run as root. You probably have broken permissions. Also if you can run
Wine as root you surely can compile Wine.

Closing invalid. Permission problems/invalid environment.

[Bug 15382] Tray icons won't appear

http://bugs.winehq.org/show_bug.cgi?id=15382

James Hawkins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from James Hawkins   2008-09-23 20:04:49 ---
Closing.

[Bug 15382] Tray icons won't appear

http://bugs.winehq.org/show_bug.cgi?id=15382

jvlad  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |UNCONFIRMED
         Resolution|INVALID                     |

--- Comment #5 from jvlad   2008-09-24 03:22:37 ---
> Don't run as root.

ok
> You probably have broken permissions.

Could you please suggest what to check to make sure that the problem is caused
by permissions?
> Also if you can run Wine as root you surely can compile Wine.

I surely can compile Wine, but the host for sure has no access to the internet
and git won't get any further with those git:// urls. Please suggest how to
proceed without direct access to the internet.
> Closing invalid. Permission problems/invalid environment.

Thanks but please let's check what's up. I have some strong reason to believe
that there are no problem with permissions. It's a new host with freshly
installed OS and Wine updates. Almost nothing is/was/could be done there to
create problems with permissions.

[Bug 15382] Tray icons won't appear

http://bugs.winehq.org/show_bug.cgi?id=15382

--- Comment #6 from Austin English   2008-09-24 09:42:23 ---
(In reply to comment #5)
> I surely can compile Wine, but the host for sure has no access to the internet
> and git won't get any further with those git:// urls. Please suggest how to
> proceed without direct access to the internet.

replace git:// with http://

[Bug 15382] Tray icons won't appear

http://bugs.winehq.org/show_bug.cgi?id=15382

--- Comment #7 from jvlad   2008-09-24 16:45:04 ---
> replace git:// with http://

I have some doubts that this change will connect the host to the internet...

As of the icons, I did not reboot for a while (a few hours) and now they do not
work again.

[Bug 15382] Tray icons won't appear

http://bugs.winehq.org/show_bug.cgi?id=15382

--- Comment #8 from jvlad   2008-09-24 16:47:48 ---
and once again: running WIN32 application from the root terminal will get the
icons shown.

[Bug 15382] Tray icons won't appear

http://bugs.winehq.org/show_bug.cgi?id=15382

Kirill K. Smirnov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Kirill K. Smirnov   2008-09-29 07:43:35 ---
Add a new unpriviledged user and try to run WIN32 apps under it (instead of
root) and see, whether icons are shown.

If they are shown, then check whether there is another Xserver.

If it exists, then please, see the bug #15467. It demonstrates the similar
behavior.

[Bug 15382] Tray icons won't appear

http://bugs.winehq.org/show_bug.cgi?id=15382

--- Comment #10 from jvlad   2008-09-29 09:35:25 ---
I'm sure, there is just one X on my machine. It's also clear that in my case
trayicons mostly work. When they don't, I see only one possible reason - OS has
been idling for quite big amount of time before the problem happened.

As I noted earlier, in my case Shell_NotifyIcon() knew that the icon hasn't
been added and returned FALSE. But the error status wasn't properly updated so
GetLastError() returned zero.

Does Shell_NotifyIcon() use some kind of RPC to add the icons? It would explain
the problem with timeout.

[Bug 15382] Tray icons won't appear

http://bugs.winehq.org/show_bug.cgi?id=15382

--- Comment #11 from Kirill K. Smirnov   2008-09-29 10:21:03 ---
> As I noted earlier, in my case Shell_NotifyIcon() knew that the icon hasn't
> been added and returned FALSE. But the error status wasn't properly updated so
> GetLastError() returned zero.

Yes, right now wine does not bother to set LastError nor clear it. This is
FIXME.
> Does Shell_NotifyIcon() use some kind of RPC to add the icons? It would explain
> the problem with timeout.

It just does a cross-process SendMessage to explorer process.

To localize the bug try run application in desktop mode:

$ wine explorer /desktop=q,1024x768 taskmgr

There should be two windows in wine virtual desktop: taskmgr itself and
mini-systray with one icon. If so, then problem is somewhere in communication
with Xserver via XEMBED.

And please, clarify what bug you try to report:
1) Shell_NotifyIcon() does not set last error.
2) Tray icons do not appear at all.
3) Tray icons work, but stop after some amount of time.
I'm sorry, but I cannot extract this information from your posts. I assume this
is #2.

[Bug 15382] Tray icons won't appear

http://bugs.winehq.org/show_bug.cgi?id=15382

--- Comment #12 from jvlad   2008-09-29 12:42:27 ---
> And please, clarify what bug you try to report:
> - Shell_NotifyIcon() does not set last error.
> - Tray icons do not appear at all.
> - Tray icons work, but stop after some amount of time.
>
> I'm sorry, but I cannot extract this information from your posts. I assume this
> is #2.

I'm trying to report #1 and #3, although I'm not 100% sure that the problem #3
happens after some amount of time. Right now the icons work. They did not work
yesterday. Will see tomorrow. As soon as I get them non-appearing again, I'll
check with wine explorer /desktop=q,1024x768 taskmgr.

[Bug 15382] Tray icons won't appear

http://bugs.winehq.org/show_bug.cgi?id=15382

Pauli Nieminen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from Pauli Nieminen   2008-12-08 23:26:57 ---
I saw similar behave when trying to debug why games crashed in process creation
when launched from steam using self compiled wine.

I was able to make explorer.exe "partialy" crash with winedbg. After that
closing steam let crashed explorer.exe stay running and old wineserver. After
that all notification icons didn't appear untill I killed explorer.exe and old
wineserver.

[Bug 15382] Tray icons won't appear

http://bugs.winehq.org/show_bug.cgi?id=15382

--- Comment #14 from Austin English   2009-06-08 11:53:01 ---
Is this still an issue in current (1.1.23 or newer) wine?

[Bug 15382] Tray icons won't appear

http://bugs.winehq.org/show_bug.cgi?id=15382

John P Sims  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from John P Sims   2009-09-21 23:54:18 ---
Works fine for me - wine-1.1.29-410-gbae9e56. It's been working for awhile.

[Bug 15382] Tray icons won't appear

http://bugs.winehq.org/show_bug.cgi?id=15382

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #16 from Austin English   2009-09-22 01:35:58 ---
Reported fixed.

[Bug 15382] Tray icons won't appear

http://bugs.winehq.org/show_bug.cgi?id=15382

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #17 from Alexandre Julliard   2009-09-25 12:24:51 ---
Closing bugs fixed in 1.1.30.