[Bug 30631] New: Steam client crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=30631

Bug #: 30631
           Summary: Steam client crashes on exit
           Product: Wine
           Version: 1.5.3
          Platform: x86
               URL: http://cdn.steampowered.com/download/SteamInstall.msi
        OS/Version: Linux
            Status: UNCONFIRMED
          Keywords: download, regression
          Severity: normal
          Priority: P2
         Component: winmm&mci
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
    Classification: Unclassified
   Regression SHA1: 31291cdc6ccc4c172ccf86f383c6a90f31a50ba1

Created attachment 40102
  --> http://bugs.winehq.org/attachment.cgi?id=40102
terminal output

You don't need to have a Steam account to reproduce the problem.

1. Install Steam client.
2. When the login window appears click on the close (x) button in the upper
right corner.

The crash occurs fairly often (maybe 8 times out of 10 attempts) but not
always. On rare occasions Steam exits cleanly.

Fedora 16 x86
Alsa 1.0.25
Pulseaudio is not running
Audio device: nVidia Corporation MCP61 High Definition Audio (rev a2)

[Bug 30631] Steam client crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=30631

--- Comment #1 from GyB  2012-05-09 10:47:55 CDT ---
Created attachment 40103
  --> http://bugs.winehq.org/attachment.cgi?id=40103
+tid,+mmdevapi,+winmm,+driver,+midi,+dsound,+dmusic,+mci,+alsa log

[Bug 30631] Steam client crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=30631

--- Comment #2 from GyB  2012-05-09 10:53:13 CDT ---
Sorry, this was missing from my previous comment:

31291cdc6ccc4c172ccf86f383c6a90f31a50ba1 is the first bad commit
commit 31291cdc6ccc4c172ccf86f383c6a90f31a50ba1
Author: Andrew Eikum 
Date:   Mon May 7 09:58:04 2012 -0500

winmm: Close open wave devices upon process detach.

:040000 040000 3768c38fdafc656c5e18e14ad70884ea7864b758
ced89c43a6ee96b54896a01dbc679f6e0084e872 M    dlls

[Bug 30631] Steam client crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=30631

--- Comment #3 from Andrew Eikum  2012-05-09 10:55:59 CDT ---
Thanks. Looks like mmdevapi is getting closed first, then winmm is trying to
shutdown and calling invalid mmdevapi COM objects. I'm looking into it...

[Bug 30631] Steam client crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=30631

--- Comment #4 from Andrew Eikum  2012-05-09 13:44:31 CDT ---
Created attachment 40105
  --> http://bugs.winehq.org/attachment.cgi?id=40105
winmm: Don't call MMDevAPI during process exit

Just submitted this patch to fix the issue.

[Bug 30631] Steam client crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=30631

Julian Rüger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 30631] Steam client crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=30631

--- Comment #5 from Andrew Eikum  2012-05-11 11:10:58 CDT ---
Similar patch is in Wine as 47332210dd029379f6fe8a1344225e98e8941257. Please
retest to confirm it's fixed.

[Bug 30631] Steam client crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=30631

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |47332210dd029379f6fe8a13442
                   |                            |25e98e8941257
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from GyB  2012-05-11 11:36:59 CDT ---
Tested with wine-1.5.3-278-gcf89638. Fixed indeed. Thanks.

[Bug 30631] Steam client crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=30631

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  2012-05-11 13:22:17 CDT ---
Closing bugs fixed in 1.5.4.