[Bug 24606] New: 1.3.4 update just stopped MSOFFICE from working...

http://bugs.winehq.org/show_bug.cgi?id=24606

Summary: 1.3.4 update just stopped MSOFFICE from working...
           Product: Wine
           Version: 1.3.4
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: critical
          Priority: P2
         Component: ole32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=31084)
 --> (http://bugs.winehq.org/attachment.cgi?id=31084)
Backtrace of MS Dialog problem.

Upgraded Wine to 1.3.4 this afternoon.

Was working on a Word doc, in MSOFFICE 2007 through Wine.

Did the upgrade.

Then went and reloaded the document, it loaded fine.
However, as soon as I tried to open or save (file dialogs) I would receive the
Windows has crashed error, and given the debug button or restart office.
If I click debug, then wine crashes.

Tried changing all of my libraries to native, or builtin, or both, or disabled,
still happens.

All other software worked fine in Wine.

Adobe products... Fine. 
Browsers... Fine.

MS products file dialogs, all broken...

Thanks guys, Backtrace attached.

Marcus

[Bug 24606] 1.3.4 update just stopped MSOFFICE from working...

http://bugs.winehq.org/show_bug.cgi?id=24606

Andrew Nguyen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
          Component|ole32                       |-unknown
           Severity|critical                    |normal

--- Comment #1 from Andrew Nguyen  2010-10-02 22:26:12 CDT ---
The severity isn't critical; see
http://bugs.winehq.org/page.cgi?id=fields.html#importance for correct usage. I
don't see any evidence that the problem is related to ole32, so I'm changing
the component field to unknown. Please perform a regression test:

http://wiki.winehq.org/RegressionTesting

[Bug 24606] 1.3.4 update just stopped MSOFFICE from working...

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #2 from Marcus Eby  2010-10-02 22:30:29 CDT ---
I updated via Ubuntu USA Servers 3 days ago, and no new wine, I updated today
and new wine version.

1.3.4

Whatever version was released to Ubuntu's update servers in the past 3 days,
would be the version.

I'm not doing regression testing, sorry, not setup for it.

Marcus

[Bug 24606] Office 2007 crashes at open/save file dialogs

http://bugs.winehq.org/show_bug.cgi?id=24606

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|1.3.4 update just stopped   |Office 2007 crashes at
                   |MSOFFICE from working...    |open/save file dialogs

--- Comment #3 from Jeff Zaroyko  2010-10-02 23:24:31 CDT ---
(In reply to comment #2)
> I'm not doing regression testing, sorry, not setup for it.

If the instructions aren't clear, please visit http://forum.winehq.org to ask
for help with the regression test.

[Bug 24606] Office 2007 crashes at open/save file dialogs

http://bugs.winehq.org/show_bug.cgi?id=24606

nick ves  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from nick ves  2010-10-10 15:41:53 CDT ---
Also affect me, same backtrace as OP.

ubuntu 10.10 wine ver 1.3.4

[Bug 24606] Office 2007 crashes at open/save file dialogs

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #5 from nick ves  2010-10-10 15:45:20 CDT ---
Created an attachment (id=31212)
 --> (http://bugs.winehq.org/attachment.cgi?id=31212)
backtrace-ves

backtraace for comparison

[Bug 24606] Office 2007 crashes at open/save file dialogs

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #6 from Nikolay Sivov  2010-10-10 16:03:09 CDT ---
Install wine debug symbols (or build it yourself) and attach a +tid,+shell log.

[Bug 24606] Office 2007 crashes at open/save file dialogs

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #7 from nick ves  2010-10-10 16:21:18 CDT ---
Created an attachment (id=31213)
 --> (http://bugs.winehq.org/attachment.cgi?id=31213)
+tid,+shell log (compressed an otherwise too big log)

+tid,+shell log

[Bug 24606] Office 2007 crashes at open/save file dialogs

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #8 from Nikolay Sivov  2010-10-10 16:43:21 CDT ---
(In reply to comment #7)
> Created an attachment (id=31213)

--> (http://bugs.winehq.org/attachment.cgi?id=31213) [details]
> +tid,+shell log (compressed an otherwise too big log)
>
> +tid,+shell log

There's no crashes in this log.

[Bug 24606] Office 2007 crashes at open/save file dialogs

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #9 from Rosanne DiMesio  2010-10-10 22:57:18 CDT ---
I can't reproduce this, but I'm on openSUSE.

[Bug 24606] Office 2007 crashes at open/save file dialogs

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #10 from Nikolay Sivov  2010-10-10 23:03:40 CDT ---
(In reply to comment #9)
> I can't reproduce this, but I'm on openSUSE.

Yes, looks like it's about ubuntu libc build:

---
/lib32/libc.so.6(__fortify_fail+0x50)[0xf7544a90]
/lib32/libc.so.6(+0xe39ca)[0xf75439ca]
/lib32/libc.so.6(__strcpy_chk+0x44)[0xf7542d44]
/usr/bin/../lib32/wine/shell32.dll.so(_ILCreateEntireNetwork+0x5c)[0x7e1e19ac]
/usr/bin/../lib32/wine/shell32.dll.so(+0x683c5)[0x7e20b3c5]
/usr/bin/../lib32/wine/shell32.dll.so(SHELL32_ParseNextElement+0x99)[0x7e21dcd9]
/usr/bin/../lib32/wine/shell32.dll.so(+0x60521)[0x7e203521]
---

[Bug 24606] Office 2007 crashes at open/save file dialogs

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #11 from Dmitry Timoshkov  2010-10-10 23:17:56 CDT ---
There was a patch for this kind of the crash:
http://www.winehq.org/pipermail/wine-patches/2010-September/093377.html

[Bug 24606] Office 2007 crashes at open/save file dialogs

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #12 from nick ves  2010-10-11 07:13:25 CDT ---
(In reply to comment #11)
> There was a patch for this kind of the crash:
> http://www.winehq.org/pipermail/wine-patches/2010-September/093377.html

(In reply to comment #7)
> Created an attachment (id=31213)

--> (http://bugs.winehq.org/attachment.cgi?id=31213) [details]
> +tid,+shell log (compressed an otherwise too big log)
>
> +tid,+shell log

It's a 'soft crash, meaning word catches the the exception, gives you the
option to report about the crash and exits with the option in next run to
recover the document (which works A-ok)

[Bug 24606] Office 2007 crashes at open/save file dialogs

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #13 from Marcus Eby  2010-10-11 14:51:44 CDT ---
> It's a 'soft crash, meaning word catches the the exception, gives you the
> option to report about the crash and exits with the option in next run to
> recover the document (which works A-ok)

So thats great that its a soft crash, its still a crash to me, and I can't save
any documents.

So since it happened after the upgrade and was fine before the upgrade, please
tell me how I can fix it.

Thanks

Marcus

[Bug 24606] Office 2007 crashes at open/save file dialogs

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #14 from nick ves  2010-10-11 18:33:43 CDT ---
(In reply to comment #13)
> > It's a 'soft crash, meaning word catches the the exception, gives you the
> > option to report about the crash and exits with the option in next run to
> > recover the document (which works A-ok)
>
> So thats great that its a soft crash, its still a crash to me, and I can't save
> any documents.
>
> So since it happened after the upgrade and was fine before the upgrade, please
> tell me how I can fix it.
>
> Thanks
>
> Marcus

If you're on ubuntu you can find the previous packages here :

10.10 (maveric)
https://launchpad.net/~ubuntu-wine/+archive/ppa/+packages?field.name_filter=...

10.04 (lucid)
https://launchpad.net/~ubuntu-wine/+archive/ppa/+packages?field.name_filter=...

previous version is 1.3.3 if I not mistaken

[Bug 24606] Office 2007 crashes at open/save file dialogs

http://bugs.winehq.org/show_bug.cgi?id=24606

Kyle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from Kyle  2010-10-12 16:09:37 CDT ---
I can confirm this bug and that in fact the patch supplied by Mike Frysinger
noted in comment 12 works perfectly.

x86_64 gentoo w/ wine 1.3.4.

[Bug 24606] Office 2007 crashes at open/save file dialogs

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #16 from Marcus Eby  2010-10-12 16:26:31 CDT ---
(In reply to comment #15)
> I can confirm this bug and that in fact the patch supplied by Mike Frysinger
> noted in comment 12 works perfectly.
>
> x86_64 gentoo w/ wine 1.3.4.

Thanks Kyle.
How do I apply the patch? 
Sorry to sound ignorant, but I'm still learning Ubuntu/Linux.

Marcus

[Bug 24606] Office 2007 crashes at open/save file dialogs

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #17 from Kyle  2010-10-12 16:32:58 CDT ---
Created an attachment (id=31235)
 --> (http://bugs.winehq.org/attachment.cgi?id=31235)
patch to fix the problem

This is just mikes patch with some white space fixups that don't come through
on the email message in the link on comment 12.

[Bug 24606] Office 2007 crashes at open/save file dialogs

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #18 from Kyle  2010-10-12 16:38:54 CDT ---
(In reply to comment #17)
> Created an attachment (id=31235)

--> (http://bugs.winehq.org/attachment.cgi?id=31235) [details]
> patch to fix the problem
>
> This is just mikes patch with some white space fixups that don't come through
> on the email message in the link on comment 12.

On Ubuntu this is going to be tricky, and almost impossible as there is no easy
way to install your own custom version of wine (well there is, read up on it if
you are interested). The best thing to do would be find out who packages wine
for Ubuntu and point them to this bug, and specifically the patch here.

They will know what to do, and will rebuild the wine package and push it out
through the normal channels (hopefully).

If you're feeling adventurous, download wine from git, and the patch above. Put
the patch in the root of the wine/ git checkout and do a

patch -p1 < fix-msoffice.patch

when you are in the root directory of the wine/ git checkout at a terminal.

Best of luck (also, don't feel bad if you can't do this ... this is outside the
scope of regular operating system users and should be taken care of by
developers)

[Bug 24606] Office 2007 crashes at open/save file dialogs

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #19 from nick ves  2010-10-13 16:56:52 CDT ---
Why szName is defined with length of 1 if it gives an exception in certain
situations in the first place?

[Bug 24606] Office 2007 crashes at open/save file dialogs

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #20 from Alexandre Julliard  2010-10-13 17:07:06 CDT ---
(In reply to comment #19)
> Why szName is defined with length of 1 if it gives an exception in certain
> situations in the first place?

The code is perfectly correct, and doesn't give any exceptions unless it's
built with broken crap like Fortify.

[Bug 24606] Office 2007 crashes at open/save file dialogs

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #21 from Kyle  2010-10-14 01:09:39 CDT ---
Yep, as Alexandre stated this bug disappears when -D_FORTIFY_SOURCE=0 is passed
in CFLAGS. So yeah sorry for the noise and this bogus patch that fixes a
non-existent problem.

On a side note, what the hell are distributions doing compiling wine with
fortify source on? I'm on Gentoo right now and I trust their package
maintainers more than other distributions and this is just worrisome.

Alexandre, would you say it is never a good idea to use -D_FORTIFY_SOURCE when
compiling wine?

[Bug 24606] Office 2007 crashes at open/save file dialogs

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #22 from Alexandre Julliard  2010-10-14 02:43:57 CDT ---
(In reply to comment #21)
> Alexandre, would you say it is never a good idea to use -D_FORTIFY_SOURCE when
> compiling wine?

It's definitely not a good idea. We already had to disable the broken longjmp
checks that were causing crashes, and also to turn off some warnings because
Fortify causes spurious ones. Now it looks like we need to disable the strcpy
checks too. And with all the trouble it gave us, I have never seen it catch any
real problem. I'm seriously considering turning it off globally in configure.

[Bug 24606] Office 2007 crashes at open/save file dialogs because of Fortify (not a Wine bug)

http://bugs.winehq.org/show_bug.cgi?id=24606

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Office 2007 crashes at      |Office 2007 crashes at
                   |open/save file dialogs      |open/save file dialogs
                   |                            |because of Fortify (not a
                   |                            |Wine bug)

[Bug 24606] Office 2007 crashes at open/save file dialogs because of Fortify (not a Wine bug)

http://bugs.winehq.org/show_bug.cgi?id=24606

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|regression                  |

[Bug 24606] Office 2007 crashes at open/save file dialogs because of Fortify (not a Wine bug)

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #23 from nick ves  2010-10-17 09:02:00 CDT ---
(In reply to comment #21)
> Yep, as Alexandre stated this bug disappears when -D_FORTIFY_SOURCE=0 is passed
> in CFLAGS. So yeah sorry for the noise and this bogus patch that fixes a
> non-existent problem.
>
> On a side note, what the hell are distributions doing compiling wine with
> fortify source on? I'm on Gentoo right now and I trust their package
> maintainers more than other distributions and this is just worrisome.

The dev packages that one of my computers use are maintained ( and compiled )by
Scott Richie

[Bug 24606] Office 2007 crashes at open/save file dialogs because of Fortify (not a Wine bug)

http://bugs.winehq.org/show_bug.cgi?id=24606

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #24 from [e-mail] 2010-10-17 11:14:58 CDT ---
It seems the problem has been acknowledged, the issue identified, and a
reasonable, certain, and straightforward correction suggested.  Why is this
still marked Unconfirmed?

[Bug 24606] Office 2007 crashes at open/save file dialogs because of Fortify (not a Wine bug)

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #25 from Juan Lang  2010-10-21 14:28:20 CDT ---
It's actually invalid, see the summary, and especially comment 20.  I'm
guessing we're holding it open to prevent a flood of duplicates.

[Bug 24606] Office 2007 crashes at open/save file dialogs because of Fortify (not a Wine bug)

http://bugs.winehq.org/show_bug.cgi?id=24606

Jaime  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #26 from Jaime  2010-10-22 04:45:22 CDT ---
I am hitting this bug on ubuntu maverick, the patch worked fine, but I am
guessing that a lot of plp (without wine compile - patching knowledge) would be
affected seriously by this bug.

[Bug 24606] Office 2007 crashes at open/save file dialogs because of Fortify (not a Wine bug)

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #27 from Marcus Eby  2010-10-22 09:33:37 CDT ---
As Jaime stated those (without wine compile - patching knowledge) would be
seriously affected includes me.

I waited for the latest update to wine via the ubuntu channels, but nothing was
fixed.

If someone could spell out the patch for the masses like me, who don't know how
to patch, would be outstanding.

Thanks

[Bug 24606] Office 2007 crashes at open/save file dialogs because of Fortify (not a Wine bug)

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #28 from Dmitry Timoshkov  2010-10-22 10:50:31 CDT ---
(In reply to comment #27)
> If someone could spell out the patch for the masses like me, who don't know how
> to patch, would be outstanding.

It's not about patching Wine, it's about using certain compiler defines
which break the Wine binary. The Comment 21 contains the details. Just
file a bug with Ubuntu and ask them to compile Wine without Fortify.

[Bug 24606] Office 2007 crashes at open/save file dialogs because of Fortify (not a Wine bug)

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #29 from Jaime  2010-10-22 13:32:19 CDT ---
On ubuntu i filled this bug:

https://bugs.launchpad.net/ubuntu/+source/wine1.2/+bug/665270

[Bug 24606] Office 2007 crashes at open/save file dialogs because of Fortify (not a Wine bug)

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #30 from Austin English  2010-10-22 13:36:09 CDT ---
'Fixed' by
http://source.winehq.org/git/wine.git/?a=commitdiff;h=105793bff75f6a869bd9cc...

[Bug 24606] Office 2007 crashes at open/save file dialogs because of Fortify (not a Wine bug)

http://bugs.winehq.org/show_bug.cgi?id=24606

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID

--- Comment #31 from Dmitry Timoshkov  2010-10-22 22:35:14 CDT ---
Time to resolve this bug then.

[Bug 24606] Office 2007 crashes at open/save file dialogs because of Fortify (not a Wine bug)

http://bugs.winehq.org/show_bug.cgi?id=24606

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #32 from Dmitry Timoshkov  2010-10-22 22:35:32 CDT ---
Closing invalid.

[Bug 24606] Office 2007 crashes at open/save file dialogs because of Fortify (not a Wine bug)

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #33 from Marcus Eby  2010-10-31 20:46:22 CDT ---
Fixed in the last ubuntu release, Oct, 30th, 2010

[Bug 24606] Office 2007 crashes at open/save file dialogs because of Fortify (not a Wine bug)

http://bugs.winehq.org/show_bug.cgi?id=24606

Andrew Nguyen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #34 from Andrew Nguyen  2010-11-06 22:58:03 CDT ---
*** Bug 25055 has been marked as a duplicate of this bug. ***

[Bug 24606] Office 2007 crashes at open/save file dialogs because of Fortify (not a Wine bug)

http://bugs.winehq.org/show_bug.cgi?id=24606

Andrew Nguyen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #35 from Andrew Nguyen  2010-11-08 02:30:22 CST ---
*** Bug 25073 has been marked as a duplicate of this bug. ***

[Bug 24606] Office 2007 crashes at open/save file dialogs because of Fortify (not a Wine bug)

http://bugs.winehq.org/show_bug.cgi?id=24606

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #36 from Nikolay Sivov  2010-11-08 11:32:48 CST ---
*** Bug 25076 has been marked as a duplicate of this bug. ***

[Bug 24606] Office 2007 crashes at open/save file dialogs because of Fortify (not a Wine bug)

http://bugs.winehq.org/show_bug.cgi?id=24606

Scott Ritchie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
   Target Milestone|---                         |1.2.x

--- Comment #37 from Scott Ritchie  2010-11-23 13:00:52 CST ---
Nominating the configure change for 1.2.2

[Bug 24606] Office 2007 crashes at open/save file dialogs because of Fortify (not a Wine bug)

http://bugs.winehq.org/show_bug.cgi?id=24606

--- Comment #38 from Austin English  2010-11-23 13:53:43 CST ---
(In reply to comment #37)
> Nominating the configure change for 1.2.2

This bug was closed invalid, I'm not sure if it will be picked up for 1.2.2...

[Bug 24606] Office 2007 crashes at open/save file dialogs because of Fortify (not a Wine bug)

http://bugs.winehq.org/show_bug.cgi?id=24606

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.2.x                       |---

--- Comment #39 from Alexandre Julliard  2010-12-03 12:51:39 CST ---
Removing 1.2.x milestone from bugs included in 1.2.2.

[Bug 24606] Office 2007 crashes at open/save file dialogs because of Fortify (not a Wine bug)

https://bugs.winehq.org/show_bug.cgi?id=24606

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://launchpad.net/bugs/
                   |                            |665270
         Resolution|INVALID                     |UPSTREAM