[Bug 18776] New: VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

Summary: VBALink: GBC roms open at an incorrect resolution
           Product: Wine
           Version: 1.1.22
          Platform: PC
               URL: http://www.vbalink.info/download/vbalink180b0.zip
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Steps to reproduce:
- Download VBALink and any GB/GBC rom (untested with GBA roms)
- Open the rom with VBALink with default settings

The window resizes to the screen's height, this doesn't happen under Windows;
see screenshot.
The following is the only console output available:

fixme:win:EnumDisplayDevicesW ((null),0,0x32ec50,0x00000000), stub!
fixme:dsalsa:IDsDriverBufferImpl_SetVolumePan (0x173ba0,0x173b28): stub
fixme:menu:GetMenuBarInfo (0x20036,0xfffffffd,0x00000000,0x32ead0)
fixme:d3d_surface:IWineD3DBaseSurfaceImpl_Blt Can't handle WINEDDBLT_ASYNC flag
right now.

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

--- Comment #1 from Adys   2009-06-04 07:48:12 ---
Created an attachment (id=21544)
 --> (http://bugs.winehq.org/attachment.cgi?id=21544)
Screenshot

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

Adys  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

--- Comment #2 from Adys   2009-06-04 07:51:06 ---
Sidenote: VBALink requires MFC42.DLL from Windows XP.

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

--- Comment #3 from Rein Klazes   2009-06-04 09:41:55 ---
The GetMenuBarInfo fixme is the cause. I have a partial implementation in my
tree that should fix it. 
I will polish it a bit up and upload in a moment.

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

--- Comment #4 from Rein Klazes   2009-06-04 09:44:58 ---
Created an attachment (id=21547)
 --> (http://bugs.winehq.org/attachment.cgi?id=21547)
partial implementation of GetMenuBarInfo

Please give this patch a try.

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

--- Comment #5 from Adys   2009-06-04 10:08:57 ---
(In reply to comment #4)
> Created an attachment (id=21547)

--> (http://bugs.winehq.org/attachment.cgi?id=21547) [details]
> partial implementation of GetMenuBarInfo
>
> Please give this patch a try.

(In reply to comment #4)
> Created an attachment (id=21547)

--> (http://bugs.winehq.org/attachment.cgi?id=21547) [details]
> partial implementation of GetMenuBarInfo
>
> Please give this patch a try.

This patch fixes the issue.

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

--- Comment #6 from Austin English   2009-06-04 11:20:12 ---
(In reply to comment #2)
> Sidenote: VBALink requires MFC42.DLL from Windows XP.

Use winetricks instead.

Is there a download of a free & legal rom available?

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

--- Comment #7 from Adys   2009-06-04 11:32:11 ---
(In reply to comment #6)
> (In reply to comment #2)
> > Sidenote: VBALink requires MFC42.DLL from Windows XP.
>
> Use winetricks instead.
>
> Is there a download of a free & legal rom available?

I downloaded it from the msdn installer; I suppose winetricks does the same?

And there probably are dummy test roms available somewhere. I'll have a look.

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

--- Comment #8 from Adys   2009-06-04 11:45:26 ---
Found an unlicensed hello world rom which reproduces the issue. I can attach it
if necessary but for now this link works:
http://devcub.com/~adys/hello-world.gb

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

--- Comment #9 from Rein Klazes   2009-06-05 00:47:26 ---
(In reply to comment #5)
> > Please give this patch a try.
>
> This patch fixes the issue.

OK. I am still working on adding a few tests, before I can submit.

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

Rein Klazes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #10 from Rein Klazes   2009-06-11 03:58:16 ---
Improved patch submitted:

http://www.winehq.org/pipermail/wine-patches/2009-June/074119.html

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

--- Comment #11 from Jerome Leclanche   2009-10-24 04:26:47 ---
(In reply to comment #10)
> Improved patch submitted:
>
> http://www.winehq.org/pipermail/wine-patches/2009-June/074119.html

It's never been committed, AFAIK.

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

--- Comment #12 from Jerome Leclanche   2009-10-31 17:01:55 ---
(In reply to comment #10)
> Improved patch submitted:
>
> http://www.winehq.org/pipermail/wine-patches/2009-June/074119.html

Rein, any update on the patch? You might want to send the tests in a different
one, might be why it's not been committed.

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |user32

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

--- Comment #13 from Jerome Leclanche   2010-08-26 06:33:05 ---

(In reply to comment #12)
> (In reply to comment #10)
> > Improved patch submitted:
> >
> > http://www.winehq.org/pipermail/wine-patches/2009-June/074119.html
>
> Rein, any update on the patch? You might want to send the tests in a different
> one, might be why it's not been committed.

Ping.

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

--- Comment #14 from Jerome Leclanche  2010-09-29 06:39:04 CDT ---
An improved patch was sent but fails tests:
http://source.winehq.org/patches/data/66436

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

--- Comment #15 from Jerome Leclanche  2010-10-16 17:50:22 CDT ---
http://source.winehq.org/patches/data/67089 has been "Pending" for a week;
would be nice to get a comment from another dev.

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

--- Comment #16 from Andrew Eikum  2010-10-18 10:47:33 CDT ---
Created an attachment (id=31365)
 --> (http://bugs.winehq.org/attachment.cgi?id=31365)
Nearly complete patch. Tests need improvement.

(In reply to comment #15)
> http://source.winehq.org/patches/data/67089 has been "Pending" for a week;
> would be nice to get a comment from another dev.

Was going to post similar myself.

The issue is with the tests.  Julliard commented that the tests for the
fBarFocused and fFocused members should not be done in the input thread.  I
don't understand how Windows's UI stuff works well enough to fix this myself,
so I'm going to attach the patch here and abandon it.  I'd welcome someone to
fix it themselves, or point me in the right direction.

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

Andrew Eikum  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

--- Comment #17 from Jerome Leclanche  2011-07-17 07:26:51 CDT ---
(In reply to comment #16)
Andrew, ping. Any update on the patch?

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

--- Comment #18 from Andrew Eikum  2011-07-25 12:57:33 CDT ---
No, sorry, no updates. I've been rebasing this patch for nearly a year now :)

I took a short look at it again last week, but the right thing to do wasn't
obvious to me. Really need someone who understands the message loop and win32
GUI to fix the tests. Most of that stuff is foreign to me.

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

--- Comment #19 from Jerome Leclanche  2011-10-26 07:21:24 CDT ---
(In reply to comment #18)
It's a shame this patch is still not getting it because of tests. Did you ask
Dmitry? I believe he is familiar with the message loop.

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

Ariel Ben-Yehuda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #20 from Ariel Ben-Yehuda  2012-03-25 03:01:52 CDT ---
Still broken in Wine 1.4

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

--- Comment #21 from Jerome Leclanche  2012-05-12 07:31:52 CDT ---
Piotr sent a patch series for it.

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

--- Comment #22 from Ariel Ben-Yehuda  2012-05-12 09:55:59 CDT ---
When it will land on git?

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

Piotr Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #23 from Piotr Caban  2012-05-17 03:08:31 CDT ---
It's already committed (cd08b5a40abfe33bae339d4514d3611a0abf7648).

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

Andrew Eikum  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |cd08b5a40abfe33bae339d4514d
                   |                            |3611a0abf7648
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #24 from Andrew Eikum  2012-05-18 10:23:05 CDT ---
Tested this as fixed with VBALink180b0 and hello-world.gb. Thanks Piotr!

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

--- Comment #25 from Ariel Ben-Yehuda  2012-05-19 03:00:20 CDT ---
Confirming fixed on g6c51c1b. Thanks a lot.

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #26 from Alexandre Julliard  2012-05-25 13:42:29 CDT ---
Closing bugs fixed in 1.5.5.

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.4.x

[Bug 18776] VBALink: GBC roms open at an incorrect resolution

http://bugs.winehq.org/show_bug.cgi?id=18776

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.4.x                       |---