https://bugs.winehq.org/show_bug.cgi?id=42547
Bug ID: 42547 Summary: error: expected ')' before '*' token Product: Wine Version: 2.2 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: winex11.drv Assignee: wine-bugs@winehq.org Reporter: version2013@openmailbox.org Distribution: ---
Created attachment 57449 --> https://bugs.winehq.org/attachment.cgi?id=57449 log.txt
# gcc --version gcc (GCC) 4.2.2
# uname -r 2.6.30.5
# ldd --version ldd (GNU libc) 2.6.1
applying patches from: https://bugs.winehq.org/show_bug.cgi?id=42478#c2 https://bugs.winehq.org/show_bug.cgi?id=42483#c5
wine-2.2 does not finish compiling.
https://bugs.winehq.org/show_bug.cgi?id=42547
--- Comment #1 from Bruno Jesus 00cpxxx@gmail.com --- Hi, can you explain better what you are trying do? The mentioned patches cannot affect winex11.drv.
Where did you get wine source from? Was it from git?
The code mentioned in the error log was added by a different patch: http://source.winehq.org/git/wine.git/commitdiff/448433ae034841b47b79af1c652...
Could it be a problem of old headers? Did you try make clean && make?
https://bugs.winehq.org/show_bug.cgi?id=42547
--- Comment #2 from Nathan version2013@openmailbox.org --- The source was from: https://sourceforge.net/projects/wine/files/Source/
The two patches I mentioned were required to get to the point in the compilation where it failed, thus this bug report.
The error is possibly because of old headers. The distro is an older version of Puppy Linux.
I did not try: make clean && make.
https://bugs.winehq.org/show_bug.cgi?id=42547
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Regression SHA1| |448433ae034841b47b79af1c652 | |c1a7f45d2895f Status|UNCONFIRMED |NEW Summary|error: expected ')' before |winex11.drv compilation |'*' token |fails on systems without | |XInput2 support Ever confirmed|0 |1
--- Comment #3 from Bruno Jesus 00cpxxx@gmail.com --- It looks like XIAnyClassInfo is a XInput2 only thing. And that your system does not have XInput2 support. Other related code is protected by HAVE_X11_EXTENSIONS_XINPUT2_H but not in this case.
A similar error can be seen if a #undef HAVE_X11_EXTENSIONS_XINPUT2_H is added in mouse.c. I believe this is a regression.
commit 448433ae034841b47b79af1c652c1a7f45d2895f Author: Carlos Garnacho carlosg@gnome.org Date: Wed Feb 8 01:50:31 2017 +0100
winex11: Use XIAllDevices to select for XI_RawMotion.
Instead of selecting for XI2 events for every slave device individually, do it for XIAllDevices, and store the current device's relative X/Y valuators so they can be quickly looked up in the XI_RawMotion events received.
Signed-off-by: Carlos Garnacho carlosg@gnome.org Signed-off-by: Henri Verbeet hverbeet@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
https://bugs.winehq.org/show_bug.cgi?id=42547
Kol kol@MV8660.spb.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kol@MV8660.spb.edu
--- Comment #4 from Kol kol@MV8660.spb.edu --- I can confirm that Wine 2.2 can be built flawlessly on the system without XInput2 support if the definition of update_relative_valuators() function in "dlls/winex11.drv/mouse.c" is enclosed in
#ifdef HAVE_X11_EXTENSIONS_XINPUT2_H ... #endif .
https://bugs.winehq.org/show_bug.cgi?id=42547
--- Comment #5 from Bruno Jesus 00cpxxx@gmail.com --- I just noticed that there is already a pending patch for this: http://source.winehq.org/patches/data/130697
https://bugs.winehq.org/show_bug.cgi?id=42547
--- Comment #6 from Bruno Jesus 00cpxxx@gmail.com --- Should be fixed by http://source.winehq.org/git/wine.git/?a=commit;h=9c83e5ccf2f4c9d8662baa85c3...
https://bugs.winehq.org/show_bug.cgi?id=42547
winetest@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |version2013@openmailbox.org | |, winetest@luukku.com
https://bugs.winehq.org/show_bug.cgi?id=42547
Nathan version2013@openmailbox.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|2.2 |2.1
--- Comment #7 from Nathan version2013@openmailbox.org --- (In reply to Bruno Jesus from comment #6) Applying that patch, plus the other two patches from comment #0, resulted in 'wine build complete'. The patch is much appreciated.
https://bugs.winehq.org/show_bug.cgi?id=42547
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |9c83e5ccf2f4c9d8662baa85c35 | |f5147ccaae883 Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #8 from Bruno Jesus 00cpxxx@gmail.com --- Thanks for testing.
https://bugs.winehq.org/show_bug.cgi?id=42547
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #9 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 2.3.
-
wine-bugs＠winehq.org