[Bug 29122] New: Sonic R has rendering (color keying) issues in Direct3D mode

http://bugs.winehq.org/show_bug.cgi?id=29122

Bug #: 29122
           Summary: Sonic R has rendering (color keying) issues in
                    Direct3D mode
           Product: Wine
           Version: 1.3.32
          Platform: x86-64
               URL: http://www2.sega.co.jp/download/pc/sonicr/sonicr.exe
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: directx-ddraw
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified
   Regression SHA1: c8901d6f6253f6c97610eb1068ac4ff89758ed0a

When Sonic R is run with the Direct3D renderer, it has some rendering issues
(various objects have a green background instead of transparent) as seen in
this screenshot: http://appdb.winehq.org/appimage.php?iId=9421

The DirectDraw renderer works without this problem. According to bug 21878,
comment 5, it's a regression caused by:

commit c8901d6f6253f6c97610eb1068ac4ff89758ed0a
Author: Stefan Dösinger 
Date:   Fri Jun 9 19:36:12 2006 +0200

ddraw: Rewrite most of ddraw using WineD3D.

Attachment 36962 from that bug fixes the issue.

The demo has the same problem. It will most likely crash on startup due to a
game bug unless the CPU power available to it is limited somehow, e.g. by
running a program with high CPU usage while starting it.

[Bug 29122] Sonic R has rendering (color keying) issues in Direct3D mode

http://bugs.winehq.org/show_bug.cgi?id=29122

A Wine user  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, patch, regression

[Bug 29122] Sonic R has rendering (color keying) issues in Direct3D mode

http://bugs.winehq.org/show_bug.cgi?id=29122

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 29122] Sonic R has rendering (color keying) issues in Direct3D mode

http://bugs.winehq.org/show_bug.cgi?id=29122

David Korth  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from David Korth  2011-11-18 22:09:20 CST ---
The startup crash is caused by the game using the difference between two time
values as a divisor in order to calculate system speed. (I'm guessing it's
using GetTickCount().)

It's possible to fix this crash with a bit of hex editing.
http://info.sonicretro.org/SCHG:Sonic_R_(PC) has instructions for fixing the
retail version. (The fix basically NOPs out the timing code.)

I might take a shot at writing a test case for the color key code this weekend.

[Bug 29122] Sonic R has rendering (color keying) issues in Direct3D mode

http://bugs.winehq.org/show_bug.cgi?id=29122

--- Comment #2 from David Korth  2011-11-18 22:10:01 CST ---
The URL for the patch got eaten by Bugzilla.

http://info.sonicretro.org/SCHG:Sonic_R_%28PC%29 is the correct URL, this time
with encoded parentheses.

[Bug 29122] Sonic R has rendering (color keying) issues in Direct3D mode

http://bugs.winehq.org/show_bug.cgi?id=29122

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|directx-ddraw               |directx-d3d

[Bug 29122] Sonic R has rendering (color keying) issues in Direct3D mode

http://bugs.winehq.org/show_bug.cgi?id=29122

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |551c732d744d3f5991af114b315
                   |                            |7b641ccdcbac2
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Stefan Dösinger  2012-01-31 14:13:55 CST ---
Should be fixed by 551c732d744d3f5991af114b3157b641ccdcbac2, please retest.

[Bug 29122] Sonic R has rendering (color keying) issues in Direct3D mode

http://bugs.winehq.org/show_bug.cgi?id=29122

--- Comment #4 from A Wine user  2012-02-01 05:19:00 CST ---
(In reply to comment #3)
> Should be fixed by 551c732d744d3f5991af114b3157b641ccdcbac2, please retest.

Yes, everything is rendered correctly now. There is new regression here, but
nothing serious (message about a lost surface on starting D3D mode).

(In reply to comment #1)
> It's possible to fix this crash with a bit of hex editing.
> http://info.sonicretro.org/SCHG:Sonic_R_(PC) has instructions for fixing the
> retail version. (The fix basically NOPs out the timing code.)

Thanks for the info!

[Bug 29122] Sonic R has rendering (color keying) issues in Direct3D mode

http://bugs.winehq.org/show_bug.cgi?id=29122

--- Comment #5 from A Wine user  2012-02-01 05:25:53 CST ---
(In reply to comment #4)

The new regression has nothing to do with
551c732d744d3f5991af114b3157b641ccdcbac2 by the way, in case it wasn't clear.
:) I'll file a new bug for it.

[Bug 29122] Sonic R has rendering (color keying) issues in Direct3D mode

http://bugs.winehq.org/show_bug.cgi?id=29122

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  2012-02-02 13:37:58 CST ---
Closing bugs fixed in 1.4-rc2.