[Bug 21179] New: Acclaim Re-Volt: Unhandled page fault on read access during Battle Tags and Nhood1

http://bugs.winehq.org/show_bug.cgi?id=21179

Summary: Acclaim Re-Volt: Unhandled page fault on read access
                    during Battle Tags and Nhood1
           Product: Wine
           Version: 1.1.35
          Platform: x86
               URL: http://www.abandonia.com/en/games/908/Re-Volt.html
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=25429)
 --> (http://bugs.winehq.org/attachment.cgi?id=25429)
Unhandled page fault on read access to 0x772f3a83 at address 0x40ba52 (thread
0009), starting debugger...

The first track in the game (nhood1/Toys in the Hood) is totally unplayable on
all versions of the game on wine 1.1.35. RV versions 1.0, 1.10 (1207), and 1.10
(0916) are borked, also the Battle Tags in multiplayer races get this error.

I have attached a log showing all three tests I ran.

[Bug 21179] Acclaim Re-Volt: Unhandled page fault on read access during Battle Tags and Nhood1

http://bugs.winehq.org/show_bug.cgi?id=21179

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Wylda   2009-12-31 05:11:21 ---

Hi Luke, if you want you can take a closer look how to fill a bug report for
next time, because in my humble opinion my report is better than yours ;-)) So
next time, right?

1. Confirming, please consider UNCONFIRMED->NEW and KEYWORDS: +REGRESSION,
+DOWNLOAD

2. Did a regression test between 1.1.27 and 1.1.28:

ecd2dc7603382388665daa83a60fa0e4a5eadb38 is first bad commit
commit ecd2dc7603382388665daa83a60fa0e4a5eadb38
Author: Henri Verbeet 
Date:   Fri Aug 14 09:23:25 2009 +0200

wined3d: Make RTL_READTEX the default rendertarget locking method.

For most cards this should make more sense than RTL_READDRAW, even if e.g.
    surface_upload_data() has some room for improvement.

:040000 040000 cc7143b222409b613cb6a8d2299fd6119daa71e1
1f23cb38ca38458424babb6bdbed76b40ec5b6bf M      dlls

3. No other bug report suffers from this commit.

4. Revert of this patch on top of current git (wine-1.1.35-330-gc3e9de0) makes
that problem go away.

5. Adding author of this patch to CC.

--private keyword: bisected

Demo is affected the same way, so if someone has a problem with "abandonware
license", there is alternative demo download (also smaller to download):
http://download.cnet.com/Re-Volt-demo/3000-7518_4-10030315.html

[Bug 21179] Acclaim Re-Volt: Unhandled page fault on read access during Battle Tags and Nhood1

http://bugs.winehq.org/show_bug.cgi?id=21179

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 21179] Acclaim Re-Volt: Unhandled page fault on read access during Battle Tags and Nhood1

http://bugs.winehq.org/show_bug.cgi?id=21179

--- Comment #2 from Wylda   2009-12-31 05:16:34 ---

http://appdb.winehq.org/objectManager.php?sClass=version&iId=5932 says:

"this game is not abadonware anymore so it is ILLEGAL to download because
throwback entertainment has acquire all his rights. "

[Bug 21179] Acclaim Re-Volt: Unhandled page fault on read access during Battle Tags and Nhood1

http://bugs.winehq.org/show_bug.cgi?id=21179

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #3 from Austin English   2009-12-31 05:45:45 ---
Confirming.

[Bug 21179] Acclaim Re-Volt: Unhandled page fault on read access during Battle Tags and Nhood1

http://bugs.winehq.org/show_bug.cgi?id=21179

--- Comment #4 from Austin English   2009-12-31 06:59:10 ---
(In reply to comment #2)
> http://appdb.winehq.org/objectManager.php?sClass=version&iId=5932 says:
>
> "this game is not abadonware anymore so it is ILLEGAL to download because
> throwback entertainment has acquire all his rights. "

Abandonware is not a legal concept anyway, the only way to lose copyright is
for it to expire or to waive the copyright. Not protecting the copyright is
irrelevant.

[Bug 21179] Acclaim Re-Volt: Unhandled page fault on read access during Battle Tags and Nhood1

http://bugs.winehq.org/show_bug.cgi?id=21179

--- Comment #5 from Henri Verbeet   2009-12-31 07:37:16 ---
That commit only changed the default, so setting RenderTargetLockMode to
"readdraw" should also fix this. I'll see if I can reproduce and fix this with
the demo, though probably next week.

[Bug 21179] Acclaim Re-Volt: Unhandled page fault on read access during Battle Tags and Nhood1

http://bugs.winehq.org/show_bug.cgi?id=21179

--- Comment #6 from Wylda   2009-12-31 08:21:33 ---
> That commit only changed the default, so setting RenderTargetLockMode to
> "readdraw" should also fix this. I'll see if I can reproduce and fix this with
> the demo, though probably next week.

Hi Henri, thank you for the tip. I tried current git (wine-1.1.35-330-gc3e9de0)
and

[HKEY_CURRENT_USER\Software\Wine\Direct3D]
"RenderTargetLockMode"="readdraw"

This tip allowed me to run the demo. Setting to:

[HKEY_CURRENT_USER\Software\Wine\Direct3D]
"RenderTargetLockMode"="readtex"

causes demo to crash during initial splash screen. BTW all the test done under
Win98 mode (was not mentioned earlier ~ i guess full versions says it can run
only under 95/98 not NT, so i set winecfg to Win98 and did all the testing with
it).

[Bug 21179] Acclaim Re-Volt: Unhandled page fault on read access during Battle Tags and Nhood1

http://bugs.winehq.org/show_bug.cgi?id=21179

--- Comment #7 from Luke   2009-12-31 09:15:21 ---
(In reply to comment #4)
> (In reply to comment #2)
> > http://appdb.winehq.org/objectManager.php?sClass=version&iId=5932 says:
> >
> > "this game is not abadonware anymore so it is ILLEGAL to download because
> > throwback entertainment has acquire all his rights. "
>
> Abandonware is not a legal concept anyway, the only way to lose copyright is
> for it to expire or to waive the copyright. Not protecting the copyright is
> irrelevant.

Thanks for the better bug report and defining the download policy. However, I
am running on dial-up here and found it nearly impossible to download git
regression testing... well maybe after 48hrs of leaving my computer run at
26kbps but that isn't overly practical lol.

Also, I contacted Throwback Entertainment personally and they never game me any
verifiable evidence that they own the rights to the game, other than "we own
teh rights". The internet page which makes the blunt statement seems to have
also gone offline recently. I wonder about their validity.

I'll see if I can't report things a bit better in the future. Thanks for your
time. :D

[Bug 21179] Acclaim Re-Volt: Unhandled page fault on read access during Battle Tags and Nhood1

http://bugs.winehq.org/show_bug.cgi?id=21179

--- Comment #8 from Henri Verbeet   2010-01-05 08:30:05 ---
The demo doesn't work for me with either RTL mode in current git. I get a
different problem though:

err:seh:setup_exception_record nested exception on signal stack in thread 0009
eip 7efbd2b0 esp 7ffdbc7c stack 0x242000-0x340000

This looks pretty similar to bug 20380. The exact location where this happens
isn't very consistent, but it's always during DIB access, either by the
application or by wined3d. I didn't try with a version before 1.1.30 yet, so
it's possible the game is affected by two different regressions.

[Bug 21179] Acclaim Re-Volt: Unhandled page fault on read access during Battle Tags and Nhood1

http://bugs.winehq.org/show_bug.cgi?id=21179

--- Comment #9 from Luke   2010-01-28 18:26:59 ---
Created an attachment (id=25932)
 --> (http://bugs.winehq.org/attachment.cgi?id=25932)
Wine 1.1.37 log + backtrace attempt

Just decided to test it on the latest build of wine, still an issue. Also the
debugger locks up.

[Bug 21179] Acclaim Re-Volt: Unhandled page fault on read access during Battle Tags and Nhood1

http://bugs.winehq.org/show_bug.cgi?id=21179

--- Comment #10 from Luke   2010-01-28 18:53:35 ---
Just did another interesting test. If you use the v0.01gamespot demo download
from Softpedia:
http://games.softpedia.com/progDownload/Re-Volt-Download-43719.html

Choose the Sprinter XL car and it will work in Single Race and Time Trial. All
other cars get the page fault.

[Bug 21179] Acclaim Re-Volt: Unhandled page fault on read access during Battle Tags and Nhood1

http://bugs.winehq.org/show_bug.cgi?id=21179

Luke  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Luke   2010-02-09 19:41:56 ---
w00t! ^_^ No longer seems to be an issue in 1.1.38, demo works flawlessly on
nhood1 as does patch 1207. I did find another bug which seems to be new but
unrelated to this, I'll open another one explaining that... :P

[Bug 21179] Acclaim Re-Volt: Unhandled page fault on read access during Battle Tags and Nhood1

http://bugs.winehq.org/show_bug.cgi?id=21179

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard   2010-02-19 12:32:22 ---
Closing bugs fixed in 1.1.39.

[Bug 21179] Acclaim Re-Volt: Unhandled page fault on read access during Battle Tags and Nhood1

http://bugs.winehq.org/show_bug.cgi?id=21179

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |ecd2dc7603382388665daa83a60
                   |                            |fa0e4a5eadb38