[Bug 28373] New: occasional build failures with "make -j8"

http://bugs.winehq.org/show_bug.cgi?id=28373

Summary: occasional build failures with "make -j8"
           Product: Wine
           Version: 1.3.28
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: build-env
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

On my i7, where I build with make -j8, I have started seeing occasional strange
build failures.  For instance,

config.status: creating dlls/browseui/Makefile
make[1]: Entering directory
`/home/bob/wineslave.dir/sandbox/slave/runtests-heaptest/build/dlls/browseui'
../../tools/makedep  -C. -S../.. -T../..  aclmulti.c aclsource.c
browseui_main.c compcatcachedaemon.c progressdlg.c browseui.rc rsrc_Da.rc
rsrc_De.rc rsrc_En.rc rsrc_Es.rc rsrc_Fr.rc rsrc_He.rc rsrc_Hu.rc rsrc_It.rc
rsrc_Ja.rc rsrc_Ko.rc rsrc_Lt.rc rsrc_Nl.rc rsrc_No.rc rsrc_Pl.rc rsrc_Pt.rc
rsrc_Ro.rc rsrc_Ru.rc rsrc_Si.rc rsrc_Sr.rc rsrc_Sv.rc rsrc_Uk.rc rsrc_Zh.rc   
       browseui_classes_r.res     
make[1]: Leaving directory
`/home/bob/wineslave.dir/sandbox/slave/runtests-heaptest/build/dlls/browseui'
config.status: creating dlls/browseui/tests/Makefile
make[1]: Entering directory
`/home/bob/wineslave.dir/sandbox/slave/runtests-heaptest/build/dlls/browseui/tests'
make[1]: Leaving directory
`/home/bob/wineslave.dir/sandbox/slave/runtests-heaptest/build/dlls/browseui/tests'
make[1]: *** No rule to make target `depend'.  Stop.
make: *** [dlls/browseui/tests/Makefile] Error 2
make: *** Waiting for unfinished jobs....

I've also seen make complain that a Makefile had no separator on line 16XXX,
as if one process was reading it while another was still writing it.

I'll try running "make depend" explicitly as a workaround.

[Bug 28373] occasional build failures with "make -j8"

http://bugs.winehq.org/show_bug.cgi?id=28373

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Jerome Leclanche  2011-11-02 16:13:24 CDT ---
In over a year of using make -j8 without make depend, I never had this issue.

% lscpu
Architecture:          x86_64
CPU op-mode(s):        32-bit, 64-bit
Byte Order:            Little Endian
CPU(s):                8
On-line CPU(s) list:   0-7
Thread(s) per core:    2
Core(s) per socket:    4
CPU socket(s):         1
NUMA node(s):          1
Vendor ID:             GenuineIntel
CPU family:            6
Model:                 30
Stepping:              5
CPU MHz:               1200.000
BogoMIPS:              5617.12
Virtualization:        VT-x
L1d cache:             32K
L1i cache:             32K
L2 cache:              256K
L3 cache:              8192K
NUMA node0 CPU(s):     0-7

[Bug 28373] occasional build failures with "make -j8"

http://bugs.winehq.org/show_bug.cgi?id=28373

--- Comment #2 from Dan Kegel  2011-11-02 17:34:49 CDT ---
Perhaps it's just so rare, only a bot would notice.

Ever since I added the explicit "make depend", I haven't seen this problem,
so I guess that's a sufficient workaround.

[Bug 28373] occasional build failures with "make -j8"

http://bugs.winehq.org/show_bug.cgi?id=28373

--- Comment #3 from Jerome Leclanche  2011-11-02 17:38:14 CDT ---
wontfix/abandon then?

[Bug 28373] occasional build failures with "make -j8"

http://bugs.winehq.org/show_bug.cgi?id=28373

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX

--- Comment #4 from Dan Kegel  2011-11-02 18:01:35 CDT ---
I think it's valid, and I would be happy to see it fixed, but it's below
zero on anyone's priority, so WONTFIX for now.

[Bug 28373] occasional build failures with "make -j8"

http://bugs.winehq.org/show_bug.cgi?id=28373

Damjan Jovanovic  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Damjan Jovanovic  2011-11-03 09:57:00 CDT ---
I've noticed this sporadically even with "make -j 4" when compiling 35000+
versions of Wine
(http://www.winehq.org/pipermail/wine-devel/2011-October/092888.html).

My workaround was to try "make" when "make -j 4" fails. "make -j 4 install"
also fails sporadically whereas "make install" works. GNU make is so buggy...

[Bug 28373] occasional build failures with "make -j8"

http://bugs.winehq.org/show_bug.cgi?id=28373

--- Comment #6 from Jerome Leclanche  2011-11-08 11:09:42 CST ---
http://source.winehq.org/patches/data/80605

Does this have anything to do with this bug?

[Bug 28373] occasional build failures with "make -j8"

http://bugs.winehq.org/show_bug.cgi?id=28373

--- Comment #7 from Dan Kegel  2011-11-08 11:48:30 CST ---
I don't think so - this bug is about a Makefile not getting generated in time,
I think.

But any fix to the build is welcome.

[Bug 28373] occasional build failures with "make -j8"

http://bugs.winehq.org/show_bug.cgi?id=28373

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Austin English  2011-11-14 14:25:38 CST ---
Closing.