https://bugs.winehq.org/show_bug.cgi?id=49514
Bug ID: 49514 Summary: Wine-staging 5.12 package building fails Product: Wine-staging Version: 5.12 Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: dimesio@earthlink.net CC: leslie_alistair@hotmail.com, z.figura12@gmail.com Distribution: ---
The wine-devel 5.12 packages built without any problem, but most of the wine-staging 5.12 packages failed.
The only ones that successfully built were for the two oldest distros we package for, Debian 9.0 and Ubuntu 16.04. What those two distros have in common is that they can't be built with FAudio support.
I've attached the failed build log from Fedora 32 here; logs for the other distros we build for are on https://build.opensuse.org/package/show/Emulators:Wine:Fedora/wine-staging and https://build.opensuse.org/package/show/Emulators:Wine:Debian/wine-staging.
https://bugs.winehq.org/show_bug.cgi?id=49514
--- Comment #1 from Rosanne DiMesio dimesio@earthlink.net --- Created attachment 67642 --> https://bugs.winehq.org/attachment.cgi?id=67642 Failed build log from Fedora 32
https://bugs.winehq.org/show_bug.cgi?id=49514
Ker noa blue-t@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |blue-t@web.de
https://bugs.winehq.org/show_bug.cgi?id=49514
Sveinar Søpler cybermax@dexter.no changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cybermax@dexter.no
--- Comment #2 from Sveinar Søpler cybermax@dexter.no --- Compile seems fixed on Ubuntu 64-bit (did not test 32-bit) with this patch: https://github.com/wine-staging/wine-staging/commit/3f3a05f91c85cb5ccdc4c818...
So, i guess it will be oki by wine-staging-5.13
https://bugs.winehq.org/show_bug.cgi?id=49514
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bero@lindev.ch
--- Comment #3 from Alexandre Julliard julliard@winehq.org --- *** Bug 49516 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=49514
--- Comment #4 from Bernhard Rosenkränzer bero@lindev.ch --- Created attachment 67649 --> https://bugs.winehq.org/attachment.cgi?id=67649 Fix for issue remaining after applying 3f3a05f91c...
The patch from Comment 2 is not sufficient to fix the build in OpenMandriva, but it reduces the problem to what seems to be a simple typo.
With the patch from Comment 2 + the patch I'm attaching, the problem is fixed here as well.
In file included from /home/bero/temp/abf/wine/BUILD/wine-5.12/dlls/xaudio2_7/tests/xact.c:27: /home/bero/temp/abf/wine/BUILD/wine-5.12/dlls/xaudio2_7/tests/xact.c: In function ‘test_global_properties’: /home/bero/temp/abf/wine/BUILD/wine-5.12/include/xact3.h:682:65: error: ‘const struct IXACT3EngineVtbl’ has no member named ‘Initialze’; did you mean ‘Initialize’? 682 | #define IXACT3Engine_Initialize(p,a) (p)->lpVtbl->Initialze(p,a) | ^~~~~~~~~ /home/bero/temp/abf/wine/BUILD/wine-5.12/include/xact3.h:682:65: note: in definition of macro ‘IXACT3Engine_Initialize’ 682 | #define IXACT3Engine_Initialize(p,a) (p)->lpVtbl->Initialze(p,a) | ^~~~~~~~~ make[1]: *** [Makefile:185: xact.cross.o] Error 1
https://bugs.winehq.org/show_bug.cgi?id=49514
--- Comment #5 from Sveinar Søpler cybermax@dexter.no --- (In reply to Bernhard Rosenkränzer from comment #4)
Created attachment 67649 [details] Fix for issue remaining after applying 3f3a05f91c...
The patch from Comment 2 is not sufficient to fix the build in OpenMandriva, but it reduces the problem to what seems to be a simple typo.
When i tested i build with --disable-tests , so that would explain why it might not trigger this one perhaps.
Anyway, good catch :)
The xact3.h was committed here: https://source.winehq.org/patches/data/188167
https://testbot.winehq.org/JobDetails.pl?Key=74613 found no errors. Guess the testbot tested that it could apply the patch tho.. And that's nice :)
https://bugs.winehq.org/show_bug.cgi?id=49514
Rosanne DiMesio dimesio@earthlink.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |3f3a05f91c85cb5ccdc4c8185bc | |c862c6e96cd52 Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #6 from Rosanne DiMesio dimesio@earthlink.net --- (In reply to Sveinar Søpler from comment #2)
Compile seems fixed on Ubuntu 64-bit (did not test 32-bit) with this patch: https://github.com/wine-staging/wine-staging/commit/ 3f3a05f91c85cb5ccdc4c8185bcc862c6e96cd52
So, i guess it will be oki by wine-staging-5.13
The WineHQ packages are built with --disable-tests, so that patch was enough to fix the issue. The wine-staging-5.12 packages have been built and synced over.
https://bugs.winehq.org/show_bug.cgi?id=49514
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #7 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- Closing bugs fixed in Staging 5.15.
-
WineHQ Bugzilla