[Bug 26013] New: Brigade E5 crashes at startup

http://bugs.winehq.org/show_bug.cgi?id=26013

Summary: Brigade E5 crashes at startup
           Product: Wine
           Version: 1.3.12
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=33178)
 --> (http://bugs.winehq.org/attachment.cgi?id=33178)
Console log of crash with +tid, +d3dxof and +d3dxof_parsing

When launching Brigade E5, the intro movies play and then the game crashes when
it would normally be turning on the main menu. I've sorted through a +all
trace, and the only warn preceding the crash process was:

warn:d3dxof:IDirectXFileEnumObjectImpl_GetNextDataObject Object is not correct

Review the d3dxof trace shows that the parser had been reading the input file
into templates, until the one immediately before the warn. There were some heap
allocation activity when the first line in what should have been the new
template should have been detected, but I'm not sure if that is expected.

The demo available at
http://games.softpedia.com/progDownload/Brigade-E5-New-Jagged-Union-Demo-Dow...
has the same problem.

I've attached a console log of the crash with traces of d3dxof and
d3dxof_parsing on.

[Bug 26013] Brigade E5 crashes at startup

http://bugs.winehq.org/show_bug.cgi?id=26013

--- Comment #1 from Michael Curran  2011-04-09 20:18:27 CDT ---
Created an attachment (id=34019)
 --> (http://bugs.winehq.org/attachment.cgi?id=34019)
Patch for first half of problem

Looks like parsing.c is ignoring optional elements in templates, I've attached
a patch that corrects it in this case.

[Bug 26013] Brigade E5 crashes at startup

http://bugs.winehq.org/show_bug.cgi?id=26013

--- Comment #2 from Michael Curran  2011-04-09 20:20:28 CDT ---
Created an attachment (id=34020)
 --> (http://bugs.winehq.org/attachment.cgi?id=34020)
Patch for second half of problem

After allowing for templates to be processed (more) completely (see patch
above), parsing.c once again fails when it encounters a string with a space in
it. This patch allows parsed strings to have spaces.

[Bug 26013] Brigade E5 crashes at startup

http://bugs.winehq.org/show_bug.cgi?id=26013

Michael Curran  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Michael Curran  2011-04-15 06:26:32 CDT ---
Patches accepted, problem no longer exists in version from Git, marking as
resolved.

[Bug 26013] Brigade E5 crashes at startup

http://bugs.winehq.org/show_bug.cgi?id=26013

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  2011-04-15 12:50:39 CDT ---
Closing bugs fixed in 1.3.18.